openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	93faf5b5dd	[37278] Treat system_user as user type as well (#9287 ) https://community.openproject.org/wp/37278	4 years ago
Oliver Günther	065dfbddc4	[36467] Add API users form and schema endpoints (#9090 ) * Add Users form endpoints * Avoid cache_if as it caches properties for new_record? as well * Add specs * Add missing custom_field_values method * Fix missing firstname lastname api conversions * Disable cached_representer on user payload * Add patch to allow using our custom setter in case of nil values https://github.com/trailblazer/representable/issues/234 * Add test for changing status * Fix expectation with changed attribute mapping * Disable rendering name property for users The name property is not accessible directly for users * Fix attribute names for first and lastname for writable * Ensure password is marked writable even though its not an attribute * Avoid explicitly setting to_ar_name conversion * Reuse AssignableCustomFieldValues concern * Fix structure of users.apib to be flat * Extend requests with custom fields * Output name, but dont mark as writable attribute * Fix id indentation * Rename schema email property * Fix param for user update form * Fix schema docs	4 years ago
Oliver Günther	37bef43cea	Introduce visible scope to principals When a user has the manage_users permission in any project, they are eligible to view all users for inviting them to the project. This however is not reflected in the principals API, where only users in all visible projects are found.	4 years ago
ulferts	e1fbbf1fd4	Fix/deleted user representation (#9025 ) * fix displaying deleted user in representer For now, we simply use the user representer. In the long run, this might be changed to a specific representer * consolidate user polymorphy in api * use class comparison	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	a65992c354	Allow placeholder and group assignment to custom field (#8972 ) * Allow placeholder and group assignment to custom field * Review feedback	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937 ) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Benjamin Bädorf	e848d44dea	Fix/update wysiwyg styles (#8844 ) This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances. * Initial class definitions * Added more classes * Added Table of Contents basics * CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote * CKEditorInspector removed * op css class for headings * op css class for paragraphs * op css class for code/code block * adapt specs to altered markdown/html generation * adapt grid/budget representers to altered signature * op css class for lists * op css class for toc * op css class for links * Start working on typography css * op css class for tables * Fixing more typography, trying out larger headers * Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros * adapt specs to altered link classes * op css class for images * apply user content container class throughout application * CSS alignment custom classes applied to table * op css class for task list checkbox * Added task checkbox class * amend list checkbox class in backend * op css class for table thead element * adapt specs on image html generation * Updated table and typography styles * Update typography and figure styles * Figure overflow handling * Table alignment styles + ckEditor styles removed * rename wiki-anchor to op-uc-link_permalink * wrap table in div as well as figure * Updated code-block * Update permalinks * Fixed a lot about tables * Removed Description header from work-packages page * Fix frontend styles * Add placeholder styling, fix toc * Fixed figure print * working with table aligns * Custom class add to task lists * Custom classes applied to theads * op-uc-container custom class added to container * Codeblocks inside pre elements * Fix: single <code> and <a> tags * explicitly require overwritten gem class Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode * adapt spec expectation to altered toc rendering * CkInspector removed * Latest ckeditor changes * remove highlight css class from wiki content * allow html pipleline to handle macros with additional classes * Fixed a lot of print css for tables * Add general print css back in * Update Table of Contents styling * Custom classes on ul, ol, li and task-lists * Revert "Custom classes on ul, ol, li and task-lists" This reverts commit `0d27d28137`. * Custom classes on ul, ol, li and task-lists * Custom classes on column's th * remove placeholder class when rendering * WOrking on task lists * Changing task-list classes, changed tests * Updated list styles * Remove unused todo list styles * remove checked in binstubs * Fix table of contents * adapt todo list handing in backend pipeline * adapt specs to altered css classes * Add numbers to table of contents * Better comments in table of contents * Fix: wrap single <table> with a <figure> * Fixes to todo list design * Updated todo list scss to fix nested lists * adapt selectors in table spec * Update table styles * Improve table borders more * Custom classes specs * Fix: no need to remove regular list classes when its type changes * Add modifier for inline headings * Update table editing styles * Remove break-word tests * wrap images just like tables * Update figure content styles * Fix: All tests passing (ul.op-uc-list_task-list) * div.op-uc-figure--content wrapping tables * Specs for figures wrappers div.op-uc-figure--content * Fix: add custom classes to links and codes again * Table wrapper div reverted + specs * Fix inline palceholders * Custom macro type classes * Add basic macro placeholder changes * Move heading permalink after text * Fix word-break spec * Sending figure styles to the backend (width) * extend test to take ckeditor placeholder into account * avoid adding bem classes multiple times * attempt to fix flickering spec * Removing image spinner when uploading finishes * adapt spec expectations Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765 ) * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308 ) * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
Oliver Günther	0791c55870	Remove the internal setting with 500 max entries Instead, use the maximum allowed page size for the maximum number. This will match what the users have selected and be reasonable without adding another user-visible setting. https://community.openproject.com/wp/30103	6 years ago
Jens Ulferts	804d59c735	use correct subclass link for assignee and responsible	6 years ago
Jens Ulferts	c1853a5cdd	fix expected namespace for groups on assignee and responsible property	6 years ago
Jens Ulferts	6922f46311	don't create user representer if nothing is going to be embedded	7 years ago
Jens Ulferts	ac59ad6a89	introduce group resource stub	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Jens Ulferts	8842558aac	refactor for code quality	7 years ago
Wieland Lindenthal	4e22681e78	User mentions feature (#5897 ) * Extend syntax for linking users via their ID * Allow login names for linking user profiles. * User require_relative for legacy tests * Add specs for login name based user links; Fixes other specs, too. * Notify mentioned users * Notify linked users; - require quotes for login names in user links as login names can contain spaces, dots that are typical word boundaries - Adding specs * For the decision who gets notified due to mentions only the visibility permissions of the recipient are relevant. * Rubucop satisfaction * Add autocomplete for user names to work pack package descriptions and activity - Uses API V3 Principals endpoint. - Extends API endpoint with name filter and name order. - Make it activate when user types an "@" or a "user#" - Still for work packages only. * Directly show a list of users after typing '@' and allow navigating list with cursor keys * Add an '@' before the rendered user link * Adopting spec as WP autocompleter now expects whitespace before hash sign * Adding spec for using user autocompleter * Introduce magic pageSize of 0 for maximum length * Add id filter for principals * Allow pagination for principals and protect from falling back to a too low default value * Fixing specs * fixing typo in spec * Add magic number 0 for user custom fields * Add a toParams method for ApiV3FilterBuilder * User ApiV3FilterBuilder in path helper service * Add test for mentions principals to path helper * WIP * Convert auto complete helper to TS [ci skip]	7 years ago
ulferts	39bbf082bf	fix author filter for projectless users (#5718 ) As the principals returned by the principals API where limited to those that are members in projects the user can see, users not having any project would not be returned. This is intended in so far as to prevent getting all users easily. But the user herself should be visible in any case. [ci skip]	7 years ago
Jens Ulferts	892a76d4a1	return principals ordered by name	8 years ago
Jens Ulferts	b25b266cbf	reduce duplication	8 years ago
Jens Ulferts	c4bef2247d	adding filter instance schemas	8 years ago

25 Commits (43ffbc362d94d58ece33b3753183299726f94f75)