openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	38907c3273	[39130] Validate the whitelist on finishing a direct upload https://community.openproject.org/wp/39130	3 years ago
Oliver Günther	b3ab397c94	Fix expects in specs after whitelist bypass	3 years ago
Oliver Günther	b6237fcc88	Fix tsv spec	3 years ago
Oliver Günther	69eb40e7a3	Expect changed content_type	3 years ago
Oliver Günther	d30352ccaa	Use admin user in backup spec	3 years ago
Oliver Günther	0c437c3f05	Fix stubbed attachment service in export job spec	3 years ago
Markus Kahl	b7c0e9cb83	cleaned up and amended comments	3 years ago
Markus Kahl	72e755d87f	test correct reloading of mailer config in jobs	3 years ago
Markus Kahl	6156d4b837	fixed attachments deletion in backup_job, and more (#9221 )	4 years ago
Markus Kahl	8c8b8bbfa7	create backups via UI (#9136 ) * create backups via UI * Fix import of modal service * introduced backup token and addressed remaining comments * allow disabling permissions * improvements - only make user wait to use backup token in if really necessary - notify admins of new backup token - disable 'include attachments' option in UI if unavailable - documentation - misc * spec fixes * fixed feature spec * allow setting capybara host in every case * removed unused style file * addressed review feedback, added further feature specs * polish (code climate) * Avoid empty attachments * Don't raise filesize validation for internal exports Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	5920ace376	[37024] Make system user permanent admin (#9192 ) * [37024] Make system user permanent admin https://community.openproject.org/wp/37024 * Yield self from run_given * Fix count for admin in bim seeder	4 years ago
Oliver Günther	06bcfbbb06	Add user job to provide system user with privileges (#9191 )	4 years ago
ulferts	d1f419385f	Feature/member custom notifications (#9173 ) * include custom message in membership forms * keep pristine params to be able to pass it to the state * fix indentation on projects api docs * pass grape instance around in default endpoints The grape instance has readily available access to all the objects (params, current_user) so less individual parameters need to be passed. This also avoids having to store the grape endpoint in a potentials not thread safe variable * send custom message out on membership creation * send custom message on membership update * send custom message even if setting disabled * restore params interface * add custom message description to schema * describe notificationMessage in the api documentation * extract meta payload functionality into mixin * ensure password in spec meets requirements * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	820d2b4178	[37014] Remove any special characters from target filename https://community.openproject.org/wp/37014	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958 ) * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	f50297227b	[34444] Projects copy APIv3 (#9149 ) * Create copy project endpoint * Add representers * Add _meta representer for copy module information * Add Meta payload representer * Extract parsing of copy attributes into service * Extract enqueue job for projects copy * Keep request object available in the bodied endpoint this allows us to access grape (e.g., for redirecting) * Add DelayedModify endpoint that redirects to job status * Use DelayedModify endpoint for copying projects * Add api paths for form/copy * Disable cache on ProjectCopyPayload * Add spec * Add resource spec * Extend schema for meta * Extend docs * Don't pass service result, but state as meta to forms * Use copy dependencies for naming copy options in API * Add description property for counting * Remove unused action attribute * Skip writable checks on meta property for payloads * Use prepend to allow create(...) usage with meta * Extend copy spec with custom fields usage * Add spec for copy flags * Add todos * Pass errors correctly to copy settings * Remove invalid parameters to copy that are now caught through project service * Remove duplicated validation * Linting * Make count a human readable, formattable description string * Make source count string readable * Provide the source project for generating the counts * Extract copying of attachments into sepearate dependent services This will allow the API to dynamically generate a copy association schema from each dependent service * Add spec for copy schema representer * Add payload representer spec * Also validate the model to pass the validations when copying * Make description optional and add note to schemas.apib * Add send_notifications to representer * Allow to configure sendNotifications * Allow bodied to receive a state process callback That allows us to manage the meta state on the API level, not on the service level * Make other services compatible with BaseCallable * Fix params passing from BaseCallable Wrapping a single hash into kwargs obviously loses their key indifference and we can't expect all services to use a single params object. Older services use kwargs * Copy wiki page with parent_id This will save some memory instead of memoizing the entire wiki page * Fix typo * Default to true for all copy associations That means if only a true value is passed, all other options will still be true * Do not try to copy attachments if the base dependency wasnt copied * Ensure null identifier gets rendered * Fix paths to the form and commit * Change redirect to an URL * Extend documentation on meta properties as table * Ensure we pass a default params if incoming params are nil Now that SetAttributes needs to splat params, they do no longer correctly get the no-param-default behavior of Ruby, so we need to explictly assign a default params hash * Fix expect for trailing path	4 years ago
Oliver Günther	f4dfd6c6c6	[36238] Extract and fix user references in other objects (#9007 ) * Move replacing invalid references into separate job for principals * Write migration to remove existing invalid custom values and responsible * Fix other specs * Fix other specs * rewrite replacing user in records * consolidate principal deletion * include placeholder users in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
ulferts	2744673ec8	avoid updating the lock version on finishing an attachment upload (#8934 ) If the lock version is increased, it might happen while the user is still editing the description. The user might have added an image to the description and continues typing. In the backend, the FinishDirectUploadJob is run before the user presses the checkmark to send the updated description. In that case, a 409 conflict would be signaled if the lock version were to be updated in the meantime.	4 years ago
ulferts	38cae188ad	Fix/journals on direct uploads (#8933 ) * linting * use Carrierwave's replacement for filename This avoids having the name altered by Carrierwave later on in the Attachments::FinishDirectUploadJob job where the file is fetched and then the attachment is stored. * separate cases for no attachment and no local file * correct journalizing on direct upload In case the container of an attachment is journalized, the container needs to have added a journal to it when an attachment is uploaded. Without that, the attachment is only picked up in the journals once the container is altered again (possibly by a different user). This will then lead to a history which does not reflect the actual upload.	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	ae2edad19b	Fix/copy project wiki notifications (#8777 ) * rename to convey applicability to all journal notifications * adapt journal completed job to handle wiki content * remove empty module * create wiki_content mail service * introduce copy/create service and contract for wiki pages * specify set attributes and create contract for wiki pages * copy the content attributes * use wiki page create service when copying wiki * introduce specifc service for copying wiki pages The contract disables checks for permissions on the wiki page. The copy_projects permission should suffice to copy everthing in a project * copy wiki pages top down to rewrite hierarchy * limit copied attachments to copied type	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	605f6b8355	Refactor copy project into service	4 years ago
Oliver Günther	45fc54b7e0	Allow jobs to define a title for the job status modal	4 years ago
Oliver Günther	88cb21a594	Fix export spec	4 years ago
Oliver Günther	d0c0fdd871	Correctly upsert statuses in all cases In case of tests, jobs never are running through the 'queued' step. This causes jobs to be missing in later updates. To avoid this, ensure that we just use upsert, which is faster anyway.	4 years ago
Oliver Günther	c94c1951b9	[33413] Use around hook to reload config in jobs https://community.openproject.com/wp/33413	5 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
Oliver Günther	f10e5bcafc	[33111] Always assign query_props to change persisted queries In case of a persisted query, the export job only received that query without any (unsaved) query_props, resulting in changes to it never being applied. Since a saved query is only passed for manual sorting, the problem only occurs there. https://community.openproject.com/wp/33111	5 years ago
ulferts	4cb0d0ff91	Feature/delayed bcf export (#8275 ) * delayed bcf export * remove unnecessary eager loading * Update rxjs polling statement with loading indicator * Avoid error handling due to JSON parsing * delay all wp list exports Co-authored-by: Oliver Günther <mail@oliverguenther.de> [ci skip]	5 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Yegor Tovstik	b503f579e0	PR fixes	5 years ago
Yegor Tovstik	ee2762e8ef	Send email on watcher being removed	5 years ago
ulferts	3dabb46dd9	allow copying projects without parent project reference	5 years ago
ulferts	73a017988d	fix spec location	5 years ago
Oliver Günther	7a09d8fcdd	delay all jobs	5 years ago
ulferts	67e3a7a15a	let mail sending rely on notifications That way, the two are no longer intermingled and we can build on the notifications in other use cases like it is already done for the webhooks	5 years ago
ulferts	e86d757cb5	limit notification disabling to mail only	5 years ago
ulferts	f6226524dd	extract shared code into module	5 years ago
Oliver Günther	a7ed2e9da0	Rewrite jobs to use ActiveJob syntax	5 years ago
Oliver Günther	2fc4416601	Store User.current in current thread	5 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308 ) * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
ulferts	1850622f20	Feature/versions api update (#7299 ) Feature/versions api update [ci skip]	6 years ago
Oliver Günther	c67cc392ce	Prepare for core integration	6 years ago
Oliver Günther	727d081626	Fix error message in extract job [ci skip]	6 years ago
Oliver Günther	f2ceec1c78	Set DJ priorities and lower max attempts	6 years ago
Jens Ulferts	57c8aeb5aa	add job to cleanup uncontainered attachments	7 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago

1 2

93 Commits (45d1a0caa2dcd424d6f727f01f6a3fb610596805)