openproject

Commit Graph

Author	SHA1	Message	Date
Alexander Bach	7e0c7c352e	Move event to fire after its sure that a journal will stay	9 years ago
Alexander Bach	0cf0468ebf	Add default value for send_notification	9 years ago
Alexander Bach	ee14628c09	Move send_notification to event origin	9 years ago
Alexander Bach	a5f4eb1e8b	First event-based draft Unifies Journal- and WorkPackageObserver Removes them as observers Makes new JournalListener more classy	9 years ago
Alexander Bach	c22ce53a7a	Add journal_created event	9 years ago
Alex Coles	28098977ba	Fix Project methods that should pass through User `user` argument appears to be have ineffective since these methods were originally introduced in `c1bfd520`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	41c04c201f	Replace hand-rolled Project.find w/FriendlyId's This is the simplest possible usage of FriendlyId: responsibility for setting and validating Project identifiers still lies with our own application code (although `FriendlyId::Slugged` provides such functionality). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	d906650a16	Remove AssociationsMapper remnants in WorkPackage Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	17940bf02c	change validation of WP children - do not add error on a symbol called :#123 (123 is the childrens ID) - this is against the semantics of ActiveRecord::Errors - creating symbols in a loop used to be a bad idea (might be better today) - it breaks error messages in the APIv3 (which is due to APIv3 working beyond the borders of AR errors, not the best of ideas...) - use :base instead, the place for unlocatable errors - include the fact that #123 refers to a child element in the error message Basically I feel that this makes the children validation cleaner and better. But somehow I fear, that there is some code out there that depends on the fact that error keys like :#123 existed...	9 years ago
Jan Sandbrink	218c75e765	fix update_by! user when not providing notes - previously the created Journal Entry would have been made by the specified user or the User.current, dependent whether :notes were provided or not - now the journal entry is always made by the specified user	9 years ago
Alex Coles	29d9814347	Prefer Project.allowed_to to .allowed_to_condition Use `ActiveRecord::Relation#merge` to merge scopes. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	b3a54ec3e8	Add Project.allowed_to returning AR::Relation Same purpose as (and calls to) `Project.allowed_to_conditions`, but builds an `ActiveRecord::Relation` instead of a SQL String. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	df9e56c8e0	Remove duplication in News.latest(_for) methods Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	e712a45cf2	Remove duplication in Project.latest(_for) methods Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	e2d9a7746f	Remove unloadable from models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	bbd6943928	Fix block delimiter in MailHandler Missed by rubocop auto-correct. [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	8fd535769a	Fix bad rubocop auto-correct in journal_manager.rb Reported as issue upstream: https://github.com/bbatsov/rubocop/issues/2021 [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	093a6a8a98	Minor indent fix in News model for Rubocop [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	12d891ceb8	Fix missing space around blocks in MailHandler Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	c967e61097	Revert "Work-around Project nested set errors on PG" This issue should be fixed in our Rails 4(.1)-compatible fork of awesome_nested_set. See: `7bd473e845` This reverts commit `0c56b72d2a`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	5a25c32b2f	Revert "Work-around WorkPackage nested set errors on PG" This issue should be fixed in our Rails 4(.1)-compatible fork of awesome_nested_set. See: `7bd473e845` This reverts commit `2ea2c776e3`.	9 years ago
Alexander Bach	c42dad3270	Correct comment	9 years ago
Alexander Bach	2f9c9178df	Fix regex properly	9 years ago
Alexander Bach	248f11fba8	Correct style	9 years ago
Alex Coles	7cb1e43d53	Restore CustomField.for_all include option Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	c02804b0eb	Teach acts_as_searchable a references option * Update usages in models. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	8afb27578f	Add missing explicit join reference in Version Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	fb8dfed1a4	Minor indent fix in Version for Rubocop [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	91ee3dee20	Replace deprec. with_scope in Project.find_visible Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ae59a6985a	Teach User.authorize_within ActiveRecord::Relation Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	787a35c9db	Add explicit join references in models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	624b50d5bb	Remove deprecated Relation#all in models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alexander Bach	1a52cc1292	Suppress the hound	9 years ago
Alex Coles	0a44da8251	Teach Project#allowed_permissions how to pluck Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	b2790b8db1	Migrate deprecated .update_all with conditions Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	6d93fa3d76	Add Query#connection to avoid deprecation warnings Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	355e7e0ff4	Replace deprecated calls to Model#connection	9 years ago
Alex Coles	0c729dae54	Replace deprecated calls to Model.scoped Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	2ea2c776e3	Work-around WorkPackage nested set errors on PG See also `0c56b72d`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alexander Bach	851f8bf3d1	Make validation regex comply with hint	9 years ago
Alex Coles	67c84961a0	Migrate model has_many conditions to lambda Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ecfa05fad9	Rename Project.public scope to public_projects Avoid collision with `public` class method. As of Rails 4.1, `public` is explicitly black-listed as a scope name: https://github.com/rails/rails/pull/14582	9 years ago
Alex Coles	2c741c4b7f	Prune dead scope from Project Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	5557f58e80	Migrate model scopes to use lambda/block Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0f9240037a	Fix TimeEntry cleanup on work package bulk delete Fix `WorkPackage.cleanup_associated_before_destructing_if_required` semantics so that the first argument can either be an individual `WorkPackage` (as the spec originally expected) or a collection (as in actual usages). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	064d66449a	Migrate AR finder/query methods in models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	df51b6ed99	Fix syntax (w/Rubocop) in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	16720d2d7c	Rework DeletedUser.first to avoid stack overflow `.find_or_create_by` will call `.first`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	9f4ebc04a5	fix moving of WPs without specifying a status attributes without a value are actually represented by empty strings. Thus only take the status_id if it is :present? (the inverse of :blank?)	9 years ago

... 3 4 5 6 7 ...

2685 Commits (463aa185da51bdd1b6285d84e8f186ebe9d7dee2)