openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	f42ff4bdd6	[28543] Validate Type#attribute_groups in contract Validating attribute groups is only relevant when creating or updating the type in the administration. There's no need to validate this in the type itself. https://community.openproject.com/wp/28543	6 years ago
Oliver Günther	d05c1ff087	[27940] Don't sort members of attribute groups This will result in wrong orders https://community.openproject.com/wp/27940	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Oliver Günther	e8216bb16e	[27611] Restore relations tab (#6300 ) * [27611] Restore relations tab * Remove default children query [ci skip]	7 years ago
Oliver Günther	0904ed5dbf	[27487] Properly reset custom fields when resetting attribute groups CF on types can still be set through `custom_field_ids=` and is used in e.g., a number of tests as is the standard way to define custom fields. This is no problem until resetting the attribute groups, where the default attribute groups will contain the custom fields formerly defined. Thus, explicitly resetting the attribute groups must also reset the custom_field_ids. https://community.openproject.com/wp/27487	7 years ago
Oliver Günther	1acccb444a	Fix attribute groups model now that fixed children query is removed	7 years ago
Jens Ulferts	519cc56d24	allow attribute_type spec to work with plugins	7 years ago
Jens Ulferts	17d7d2c511	handle query saving, updating, deletion	7 years ago
Jens Ulferts	5a5e3494f9	turn attribute group into dedicated object	7 years ago
Jens Ulferts	a33b0bbbbd	WIP - return Query as an attribute group * only default query for now * only returned when no custom configuration is applied * start to turn attribute groups into ressources	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	39eb01ad42	Reload cached types in attribute groups spec [ci skip]	7 years ago
ulferts	c0b709530c	Fix/replace deprecations (#5533 ) * replace alias_method_chain * remove deprecation silencing * bump controller-testing * introduce permitted params for settings * replace various deprecations in controllers * remove deprecation silencing for legacy_specs * remove `puts` from spec * replace deprecated access to errors * remove unnecessary AR::Parameters usage in spec * specify error to expect * replace deprecations * replace deprecated action calls in legacy function specs * replace deprecations in functional controller tests * replace deprecations in controllers/controller_specs * remove params parser which does not seem to be in effect It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code. * replace deprecations in unit specs * replace alias_method_chain [ci skip]	7 years ago
Oliver Günther	8956700408	[25374] Remove attribute visibility	7 years ago
Oliver Günther	ae8c499517	Fix failing specs on CE/myproject config	8 years ago
Oliver Günther	5d50acc50e	[25288] Re-add translations to default attribute groups (#5515 ) * [25288] Re-add translations to default attribute groups Uses symbols to mark internal attribute groups and translates them in the schema representer to the user's locale. * Extend form configuration front end for translated default groups * fixing specs * fix feature spec for attribute groups * Add symbol test to attribute groups [ci skip]	8 years ago
Jens Ulferts	2672fb20ae	allow empty groups in type form configuration	8 years ago
Oliver Günther	01351399d5	Cache all_work_package_form_attributes Especially with lots of custom fields, this is otherwise called once per represented WP and is quite costly.	8 years ago
Oliver Günther	8d381651c8	Fix specs	8 years ago

23 Commits (4667ba0aee5943615e6bba324c834043bcab4af6)