openproject

Commit Graph

Author	SHA1	Message	Date
Wieland Lindenthal	468b5602d1	Stabilyze Revit Add-in navigation spec	3 years ago
Wieland Lindenthal	00f4181156	Fix: Revit Add-in - Correct successState for creating BCF issues (#9673 ) Currently after creating a BCF issue in Revit Add-in the redirect goes to the work package module's full view. Instead it should redirect to 'bim.partitioned.show'. This fix here has no corresponding bug work package on community.	3 years ago
Wieland Lindenthal	35124c876d	Add Refresh button for Revit Add-in from dev into 11.4 (#9670 ) Originally implemented in PR 9461. - A feature spec was added here on top. - The navigation spec for the revit add-in got more stable. https://community.openproject.org/wp/38028	3 years ago
Wieland Lindenthal	23e6f67ce6	Fix: BCF XML export: Don't write comment author's mail unless it exists (#9367 )	3 years ago
Wieland Lindenthal	31c1bdc9f9	Feature #37401 : Bump XEOKIT to use XKT files version 8. Migrate all IFC models. (#9300 ) * bump xeokit to xkt version 8 * Bump @xeokit/xeokit-gltf-to-xkt to version 1.3.1 - Remove all logic for extracting and providing metadata JSON - Update seeder - Update seeded XKT demo hospital model files - Update conversion service to join GLTF and metadata into XKT file - Fix feature spec for viewpoints. * Remove specs for metadata attachment checking * Update modules/bim/db/migrate/20210521080035_update_xkt_to_version8.rb Co-authored-by: Markus Kahl <machisuji@gmail.com>	3 years ago
Wieland Lindenthal	892322a0a2	Stop create BCF feature spec from flickering (#9344 )	3 years ago
ulferts	0c2d87b4eb	choose wp type by position only (#9297 ) There was a misconception in the code related to the `is_default` field. The `is_default` field only governs whether a type is enabled by default in a new project or not.	4 years ago
ulferts	e60f403d7c	attempt to fix flickering spec	4 years ago
ulferts	b813e8b93f	Fix/bump gems (#9259 ) * bump aws-partitions * bump database_cleaner-active_record * bump rb-fsevent * bump recaptcha * bump sentry-ruby & sentry-ruby-core * bump terminal-table * bump date_validator * bump factory_bot & factory_bot_rails * avoid eager loading models via factories	4 years ago
Wieland Lindenthal	33443c154e	Update IFC Viewer with latest Xeokit updates (#9207 ) * Bump @xeokit/xeokit-gltf-to-xkt to version 1.0.0 * Bump Xeokit SDK and Xeokit BIM Viewer * Overwrite XEOKIT orthogonal/perspective toggle icon * Add styles for section tool and its menu * Remove SAO deactivation for non default models. Performance of SAO has improved ever since Xeokit's FastNavPlugin was created. * bump xeokit sdk and bim viewer * IFC viewer toolbar adoption for section plane tool. * Fix spec after xeokit bump * Feature 33880 Add Edit/Delete/Add model buttons in Models tab * Paths to xeokit's bim viewer code changed * Bumping xeokit packages * Fix default_spec.rb for scopes	4 years ago
Oliver Günther	5920ace376	[37024] Make system user permanent admin (#9192 ) * [37024] Make system user permanent admin https://community.openproject.org/wp/37024 * Yield self from run_given * Fix count for admin in bim seeder	4 years ago
Philipp Tessenow	bd906716e5	[#36153 ] link manually created pull request to a work package using the GitHub integration plug-in (#9070 ) * Receiving and Parsing GitHub webhooks * added services for upserting PullRequests, GitHub users, and, checks. * added the datamodels for storing these entities * added logic to parse GitHub webhooks and save the entities above * fix some specs, added model specs * let UpsertPartialPullRequest return the upserted PR * added the last missing specs * avoid double-posts when editing pull requestsx * attempt to reduce flakiness * added pull requests API endpoint * handle edge case of converting partial PRs to full PRs * name raw input of an upsert service 'payload' to differentiate it from the prepared params * handle edge case: partial upsert after full PR creation * github_user does not reference users anymore * fixed a doc comment * use enums instead of custom validations * WIP * pairing with jens and some cleanup and test writing * better migration, clear up old PRs with a cron job * handle case of non-edit events which do not introduce new linked work packages, but still require a comment	4 years ago
Benjamin Bädorf	2667cd1581	Refactor/app header (#9110 ) * [35527] Add quick add button menu in top menu * Add quick menu item to top menu * Refactor top_menu.sass to follow BEM * Only render project-based path if persisted * Render project types when in project context * Add headline and determine if any types are visible * Hide quick add menu for unauthorized users * Fix login menu dropdown by adding class * Add schematic for correctly generating components * Add augment service for triggering invite user modal * Fix allowed_to? check in menu * Add spec * Highlight types and show all * Fix help menu overridden * Extend spec * Add parent_id to project in dropdown and expand advanced settings * Reload the page if the modal returned any data * Fix invalid url allowed check if there is no URL to check * Basic BEM changes * Remove old classes * Update more classes * Update togling logic * Fixed menu opening and some styles * Added op-menu * Fix some help menu styles * Add op-menu to help menug * Add avatar border * Fix auth_provider_spec * Fix zen mode * Fix static link help menu * Fixed top menu specs * Fix self registration specs * Fix logout spec * Fix bim revit navigation spec * Fixed menu permissions spec * Fix homescreen onboarding tour spec * Fix top menu item spec * Remove unused file * Fix a lot of mobile styles * Fix more mobile styles * Fixed build * Move quick add menu to right hand side * Improve quick-add-button styles, fix main-menu-toggle close icon * Remove add new project spec * Fix spec * Update project dropdown styles * Fix click handler for chrome mobile, update some styles Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	dfe575ca9c	[36269] Add "other" to pluralization rules for one (#9102 ) * [36269] Add "other" to pluralization rules for one For languages that do not have "one" as a pluralization rule (japanese, for example), the pluralization rule defined by I18n.js does not return a valid string for count: 1. Since we probably do not want to define custom pluralization rules for all languages, we can fall back to the "other" key if "one" is not defined. https://community.openproject.com/wp/36269 * Explicitly wait before clicking on viewpoint The click happens before the side tree is rendered by xeokit, and not being updated afterwards	4 years ago
Oliver Günther	1d163f93bb	Move retry block outside checkbox selector	4 years ago
Aleix Suau	3569dbe8f0	Timing issue solved with retry_block	4 years ago
Aleix Suau	2b07cb2d23	Timing issue solved with retry_block	4 years ago
ulferts	7ecf08e005	rework changed_by_system (#9043 ) Before, it was implemented by passing the changed attribut keys over to the contract to whitelist them. This lead to: * The contract interface becoming bloated * Having to rely on the knowledge of the developer not to falsely whitelist an attribute. The developer would also have to make sure to not perform a mass assignment after the attribute has been whitelisted The new approach it to integrate the behaviour into the model which is first altered in the service before it is scrutinized in the contract. The information about the changed attributes is now stored inside the model which removes the necessity to flag the whitelisted attribute separately. Additionally, the exact change is tracked. So if an attribute is set to one value inside a whitelisted block there is no risk in later on performing a mass assignment. This comes at the cost of extending the models which is weird also it is build into the default SetAttributesService so child classes do not have to worry. One might include the module into every AR model but currently we only need it for a very specific use case.	4 years ago
Aleix Suau	44cf9e0c5e	Epic/placeholder users frontend (#8977 ) * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Open invite user modal from user selection * Remove console and debugger calls * Opening modal from CreateAutocompleterComponent * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Refactor/op modal (#8978) * Initial modal refactoring * Updated modal imports * More modal module imports * Fix one more import * Fixed some styles * Fixed failing modal specs * Fix more spec selectors * Fix more specs * Updated backend modals * Improved code style * Fix export modal styles * Fix wiki export modal * Fix more specs * Fix webhooks modal * Added loading indicator back into modals * Fixed wp preview modal * InviteUserButtonComponent in * InviteUserButtonComponent in * InviteUserButtonComponent in MultiSelectEditFieldComponent and SelectEditFieldComponent * Remove extraneous module * Add Dragula import * Remove empty spec * Fix option-list component * Remove group creation from invite user modal * Write feature spec * Fix TS errors * Add Placeholder and Group apis to the frontend * Better api typing * Remove unnecessary interface * Remove group creation call Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Benjamin Bädorf <hello@benjaminbaedorf.eu>	4 years ago
Oliver Günther	cb5fbb6a72	Use the configured variable for expiry https://github.com/opf/openproject/pull/8941	4 years ago
Oliver Günther	8df966abff	Use the configured variable for expiry (#8985 ) https://github.com/opf/openproject/pull/8941	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
Oliver Günther	90d8dec296	Rewrite duplicated CreateService specs (#8959 ) * Add common base service create service examples * Rewrite user service spec into the common service * Rewrite CustomFields::CreateService spec into common * Rewrite Messages::CreateService into common * Rewrite Projects::CreateService with common example * Rewrite Grids::CreateService spec with common examples * Rewrite BIM::IfcModels::CreateService with common examples * Rewrite Bim::Bcf::Issues::CreateService with new common examples	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943 )	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Wieland Lindenthal	50e2f7d4d7	Increase wait time for IFC model presence	4 years ago
Wieland Lindenthal	ce5729af46	Increase wait time for IFC model presence	4 years ago
Benjamin Bädorf	5f45ee07ab	Move development docker-compose file to the main directory (#8798 ) * Move development docker-compose file to the main directory This requires us to move some other files around, like the pullpreview and example docker-compose file for production setups. This commit also does some housekeeping, like removing some old files and deduping configuration. * Updated to selenium grid * Fix in-Docker Selenium tests The Selenium tests now run inside a Docker Chrome Container. Backwards compatability with non-docker setups is not guaranteed, though it should not be hard to implement with a couple of small fixes. * Updated docker development documentation * Improved test timings, changed the documentation * Updated docker testing again * Run npm in the frontend directory * Really run npm in the frontend directory * Also run npm in frontend when setting up travis cache * Change directory for one command only * Change default test driver name * CI test change fixes * Fixed syntax error * Added dev check * Trying to fix firefox resizing * Trying to get tests running * Stop resizing firefox * Fixed apple icon spec * fix host in url helpers for omniauth spec * Fix omniauth specs * Fix docs * Small fixes to docker tests * Added package.json back in * Change env variables Co-authored-by: Markus Kahl <machisuji@gmail.com>	4 years ago
Wieland Lindenthal	e31cdfbec2	Fix updating of IFC models (#8791 ) * Fix: Correct version pinning for gltf2xkt and improved BIM setup_dev script (inspired by Cyril's docker/setup/preinstall-common.sh * Fix: libSass conform @extend * Fix IfcModelController when updating a model * Refactor IFC Model Update Service and adopt spec.	4 years ago
Wieland Lindenthal	49fca20ec6	Fix: IFC model management feature spec was broken. For example, before it checked that a models title was the page's title. Now, it actually checks that the model's checkbox in the xeokit "Models" tab are actually checked/unchecked.	4 years ago
Wieland Lindenthal	dd7f161bb9	Improve wording of titles and buttons on BCF module.	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
Aleix Suau	5e56a6ce90	Hiding 'Manage models' button on plugins (Revit) (#8534 ) * Hiding 'Manage models' button on plugins (Revit) * Comment clarification * Added spec to handle this use case (models button hidden)	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	4dfc333867	Merge spec from https://github.com/opf/openproject/pull/8545	4 years ago
Aleix Suau	51955661c7	Test: opens new work package form in full view	4 years ago
Aleix Suau	97f4abcbeb	Test failing	4 years ago
Wieland Lindenthal	1e205f8da3	Fix bug spec introduced by resolving merge conflicts. Also correct spelling, rename "addin" to "add-in".	4 years ago
Wieland Lindenthal	affd9aa2d6	Adding specs for Revit Addin settings button	4 years ago
Aleix Suau	4255907a04	Fix: revit addin test removed	4 years ago
Wieland Lindenthal	92e57194fb	Readding a spec that I removed to quickly.	4 years ago
Wieland Lindenthal	122e0f7506	Fix the BIM Revit Navigation spec	4 years ago
Aleix Suau	bec924b9ad	Test fixes + css improvements	4 years ago
Wieland Lindenthal	4eaa948d29	Fix timeout issues in bim_navigation_spec	4 years ago
Aleix Suau	62b972b179	Removed failing test because of timing issues	4 years ago
Aleix Suau	b19c996ecf	Code climate fixes	4 years ago
Wieland Lindenthal	760cdafe8c	Added Revit test configuration and some tests	4 years ago
Aleix Suau	a8acafab11	Table display mode working with failing test	4 years ago

1 2 3 4

172 Commits (468b5602d17a966a8d827198a298552acccac3ba)