1443 Commits (46b33419839b176b5d91a83ede13f4463c6231cf)

Author	SHA1	Message	Date
Jens Ulferts	994c2d469c	avoid adding non writeable filters multiple times ... When the create_class method is called on WorkPackagePayloadRepresenter, a subclass of the class is created that includes the relevant custom fields. That class gets the PayloadRepresenter module included. The payload representer adds a render_filter to the attributes to avoid rendering unwriteable attributes. But when adding the filter, it is not added to an instance of the attribute in the subclass (WorkPackagePayloadRepresenter + CustomFields)but rather to the one in the superclass (WorkPackagePayloadRepresenter). The filter list instance is shared by all subclasses. That sideeffect is not dangerous per se as we want all WorkPackagePayloadRepresenters to have the filter. But as we have one instance of an array, adding to that array will lead to having the filter multiple times which will then all have to be evaluated on every rendering pass. By checking if the filter is already included before adding it, we can avoid this behaviour. The better fix would be to rework the way custom fields are handled in the representers. This could be done by having one representer for the static attributes and one for the dynamic custom fields. Those two representers could be rendered/parsed independently and the results could then be merged. This approach however takes considerably more time.	6 years ago
Jens Ulferts	98ed6b521c	allow filtering by accountable group	6 years ago
Jens Ulferts	58f6e9a172	eager load attachments to avoid n+1 query ... The attachments are needed for rendering the work package description where attached images are rendered inline	6 years ago
Jens Ulferts	66acc49818	eager load attachments to avoid n+1 query ... The attachments are needed for rendering the work package description where attached images are rendered inline	6 years ago
Oliver Günther	3a69c1a6d8	[28452] Avoid adding a CF multiple times to eager loaded WPs ... If there is a custom field that is for_all, and it occurs multiple times in the custom_fields_projects join table, it will be added multiple times to the work packages availabe CFs. https://community.openproject.com/wp/28452	6 years ago
Oliver Günther	aa9897561b	[28455] Ensure model contracts are initiaited immediately before saving	6 years ago
Oliver Günther	8438848838	[28435] Fix custom field with is_for_all eager loading ... When a custom field is `is_for_all`, and in the join table from custom fields to projects, there exist a value to project A (e.g., before the CF was marked is_for_all in the first place): Lookups to the work packages in Project B with eager loading will result in this custom field missing, because the `LEFT OUTER JOIN` in usages have already mapped it to Project A. https://community.openproject.com/wp/28435	6 years ago
Oliver Günther	3d936d99dd	[28431] Don't render attachment with downloadLocation ... The downloadLocation may contain a temporary URL as it is with the case of AWS. https://community.openproject.com/wp/28431	6 years ago
Oliver Günther	f3e2100247	Save highlighting mode to query	6 years ago
Jens Ulferts	804d59c735	use correct subclass link for assignee and responsible	6 years ago
Jens Ulferts	3091064031	linting	6 years ago
Jens Ulferts	c1853a5cdd	fix expected namespace for groups on assignee and responsible property	6 years ago
Jens Ulferts	bc9aa302c9	let writability of query public attribute depend on permission	6 years ago
Oliver Günther	223284c401	[28171] Output claimed attachments on wiki representer ... https://community.openproject.com/wp/28171	6 years ago
Oliver Günther	0b96d2876c	Cached avatar image	6 years ago
Jens Ulferts	0d22112e0e	replace rails based attachment forms and lists completely	6 years ago
Oliver Günther	b08a5874f5	Remove project responsible and type	6 years ago
Jens Ulferts	7f740a8178	extend to posts and plugins	6 years ago
Jens Ulferts	c7b54471d3	use angular component for attachments on wiki page	6 years ago
Jens Ulferts	cc7f257caa	fix context links used for previewing	6 years ago
Jens Ulferts	17d9cba625	do not throw internal error on invalid custom field	6 years ago
Oliver Günther	8bfbf59edb	Add functionality of uploading images on existing wiki pages	6 years ago
Jens Ulferts	97ad5e0008	reenable previews	6 years ago
Jens Ulferts	319f33e924	remove textile	6 years ago
Oliver Günther	4823f8cfa5	PDF attachments embedding in table export	6 years ago
Jens Ulferts	312dbba5a1	fix wrong method name for external attachments	6 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Jens Ulferts	5dae0ef4d5	add endpoint for unattached attachments	7 years ago
Jens Ulferts	6a8a1eb495	add download endpoint to attachment resource	7 years ago
Jens Ulferts	441735fb4f	extend attachments api to board posts	7 years ago
Jens Ulferts	9b2458c23c	extend attachments api to wiki_pages	7 years ago
Jens Ulferts	3b8a520ff2	avoid wrapping on wp payload ... Wrapping can interfere with a couple of method e.g. setting the errors	7 years ago
Markus Kahl	6126b4311a	added error handling in create too	7 years ago
Markus Kahl	f2919d3cb6	show dependent errors if work package update (PATCH) fails	7 years ago
Jens Ulferts	2956d0b652	bust filter dependency cache on form_embedded changes	7 years ago
ulferts	e1027189bb	eager load associated work packages of relations (#6315) ... [ci skip]	7 years ago
Jens Ulferts	26320fe614	eager load for relations	7 years ago
Jens Ulferts	6922f46311	don't create user representer if nothing is going to be embedded	7 years ago
Jens Ulferts	d04b86da9c	introduce custom eager loading for work package list ... Reduces the amount of AR models instantiated when handing wp#index requests by: * Calculating part of the checksum for caching in the db. This is done by using the id and the updated_at/on field of associated models whose representation is cached in the wp representer. * Reusing instantiated models for multiple associations. e.g instances of Project are used in various places (the work package itself, it's ancestors and children). Instead of using Rails' eager loading which would instantiate a project potentially once for every association path, the code now assigns the same instance to all those associations. Additionally, the commit streamlines the creation of custom field injected representers. Now only one class is created for all work packages when before it would be one class for every uniq set of custom fields. On top of that, the class can be reused if the set of custom fields does not change.	7 years ago
Oliver Günther	85b2ef6c87	Render priorities and statuses with same display renderer	7 years ago
Oliver Günther	2f0e9c1c07	Add color to status	7 years ago
Oliver Günther	fbff2bf5fb	[27685] Allow to disable certain tabs of the embedded configuration modal (#6301) ... Also ensures that the hierarchy mode is always disabled for the embedded modal in the type configuration https://community.openproject.com/wp/27685 [ci skip]	7 years ago
Oliver Günther	ce64a30625	Add columns to query_params_representer, and allow different format ... depending on the target: - URL params: Rails automatically transforms arrays to `column[]=val1&column[]=val2" - JSON: Pass columns as `columns[]` so that frontend encodeUri will automatically pass multiple values for this key, resulting in the Rails query scheme.	7 years ago
Oliver Günther	d591e8ae4c	[27600] Add link to query_form to represent allowing new queries to be saved (#6293) ... When an existing query (and its form) is loaded, members with permissions to create new queries, but NOT to update existing ones can not save existing queries as new ones. This is due to the `create`, `update` and `commit` (on form) links are dependent on the query resource itself, not on general permissions of the queries project. https://community.openproject.com/wp/27600 [ci skip]	7 years ago
ulferts	eefbb413e7	performant visible condition on relations query (#6290) ... [ci skip]	7 years ago
Jens Ulferts	ac59ad6a89	introduce group resource stub	7 years ago
Jens Ulferts	ce21ee20f7	cached representers	7 years ago
Jens Ulferts	311c9a642f	eager load enabled_modules	7 years ago
Jens Ulferts	5a5e3494f9	turn attribute group into dedicated object	7 years ago
Jens Ulferts	77116b5cdb	ensure not to have user specific query cached in schema	7 years ago