27 Commits (46b85e5a47f01c25250df8df39057f8d54a92a2f)

Author	SHA1	Message	Date
ulferts	9fa5599392	Feature/member notifications (#8958) ... * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	f4dfd6c6c6	[36238] Extract and fix user references in other objects (#9007) ... * Move replacing invalid references into separate job for principals * Write migration to remove existing invalid custom values and responsible * Fix other specs * Fix other specs * rewrite replacing user in records * consolidate principal deletion * include placeholder users in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987) ... AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943)	4 years ago
Oliver Günther	769be47723	[35815] Add visible show page for all users to groups (#8949) ... To that end, move the show group routes out of /admin, that requires we use a different path helper for it as `group_path` will still link to the first admin resource.	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Oliver Günther	3ffadd5b24	Add spec to ensure member is removable after group removed	4 years ago
Oliver Günther	80e747e0c6	Fix test by calling service with system user ... Adds this to the factory to avoid using the system user all over the place	5 years ago
Oliver Günther	e4dcc6c5ea	Avoid usage of `users <<` pattern in group ... This will no longer trigger the addition	5 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230) ... Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Henriette Dinger	57529d73c4	Adapt tests to new tab row structure	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Henriette Dinger	bb28eaf8db	Adapt tests for extended Group filter functionality	5 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot ... Removes the deprecation	7 years ago
Jens Ulferts	8b6fa75664	bump capybara, cucumber-rails & capybara-screenshot	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Markus Kahl	58524d486d	updated membership spec to use group specific calls	8 years ago
Markus Kahl	fa5409ba13	fixed specs mostly	8 years ago
Peter Lehwess	5c316baf29	Fix a grammar error for my/page dashboard	9 years ago
Markus Kahl	8d2d8e3c5f	adapted specs to reflect latest i18n change	9 years ago
Markus Kahl	24941f3b74	simplified page module structure	9 years ago
Markus Kahl	6d14f46b6d	run without js where possible	9 years ago
Markus Kahl	6fa0b07e1e	whitespace	9 years ago
Markus Kahl	80a17229aa	replaced groups cuke by feature spec	9 years ago
Markus Kahl	867a511e70	fixed group memberships feature (as feature spec) ... dropped cuke, dropped redundant scenarios, fixed remaining ones	9 years ago
Markus Kahl	8bbf5da2e4	dropped membership.feature; rewrote as adapted feature spec ... The cuke was broken due to changes in the members view. Writing and adapting cukes is a pain, hence I removed the cuke and replaced it by a feature spec using page objects.	9 years ago