openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	5cb227796c	Fix/hook service to openproject (#9214 ) * move specs from legacy * move Hook into OpenProject namespace * replace class variables	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code Found via `codespell v2.1.dev0`	4 years ago
ulferts	8af2d6e582	fix version links on roadmap (#8936 ) * adds an id to the version link to be anchorable * adds an achor element to the link in the version list * whitelists the possible filter parameters for the version list links The solution has an insufficiency in that the browser unnecessarily reloads the page if the user had filtered before and then clicks on a link. I find that acceptable.	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Wieland Lindenthal	5b084dccd7	Fix: Always allow custom styles when in BIM edition (#8813 ) This fixes the following bug with BIM Community Editions (in other words: no Enterprise Edition, but BIM Edition). A package based installation in which the "bim" edition was selected did not show the BIM theme. Instead it showed the normal OP theme. This PR - extracts the check if custom styles shall be applied to a helper. - adds a spec for the new helper.	4 years ago
Henriette Darge	031936605c	Test for semver version instead of full string as it was changed earlier in commit #bc635851917106978a5e718983d5cad24297ceec	4 years ago
ulferts	01b97b4a07	restructure version/project helper specs	5 years ago
Henriette Dinger	f1f81f919e	Add spec for extensible tabs with Lambdas as paths	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	57f7da4f39	reuse project services in controller	5 years ago
ulferts	08391c7807	replace my_project_page by grid implementation	5 years ago
Oliver Günther	aaba57f038	Remove myproject overview page angularjs	5 years ago
ulferts	13e0707f6a	replace rabl template	6 years ago
Markus Kahl	e10f7c4d77	Setting.installation_uuid has a custom implementation not backed by Setting[]	6 years ago
Jens Ulferts	fdaa449236	avoid initial search on work package tab	6 years ago
Cyril Rohr	214c8fb502	Add whether Enterprise Edition is used when checking release status	6 years ago
Cyril Rohr	27564608db	Display a security badge with the installation status vulnerable, unknown, up to date, update available	6 years ago
Oliver Günther	7dbecdcf79	Prepare for core integration	6 years ago
Oliver Günther	ad43a7ea95	Prepare for core integration	6 years ago
Oliver Günther	5b49b33b21	Prepare for core integration	6 years ago
Oliver Günther	d06de1034f	Set which setting values need to be included in cache key	6 years ago
Oliver Günther	950515ebe4	Fix highlight class being used in rouge highlighting	6 years ago
Jens Ulferts	97ad5e0008	reenable previews	6 years ago
Oliver Günther	52444e1495	[27521] Fallback to default icon when no gravatar default exists This uses the `404` gravatar fallback to return an error when the icon does not exist. Using an error event handler, we can then replace all avatars on the page with their defined fallbacks.	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Oliver Günther	dc12e456bd	FactoryGirl => FactoryBot (opf/openproject#6304 )	7 years ago
Oliver Günther	61afac09cc	FactoryGirl => FactoryBot (belongs to opf/openproject#6304 )	7 years ago
Jens Ulferts	5a5e3494f9	turn attribute group into dedicated object	7 years ago
Oliver Günther	e93c49ecd7	Restore activity tab spec functionality	7 years ago
Oliver Günther	28ff6e0fc9	Remove onclick with csp-onclick helper It adds to a nonced javascript tag per page. This allows a faster migration without changing too much code.	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	26dff6132e	Remove default route (#6137 ) * Remove default route * Fix and clean legacy specs * Fix specs * Fix missing ID in request parameters in view specs https://stackoverflow.com/a/21789313 * Fix more invalid routes in specs * Pass parameter to omniauth spec * Add required ID parameter to types controller * Fix invalid omniauth URL * Fix project_id params in repository controller spec * Fix missing project id in projects controller spec * Fix missing params and failure url for omniauth * Fix invalid route name * Temporarily skip broken specs on dev [ci skip]	7 years ago
Oliver Günther	a0150fffa0	Remove timelines	7 years ago
Jens Ulferts	503e3e09b4	show hierarchy icons when project before is ancestor	7 years ago
Oliver Günther	d62b1288b2	OpenProject Avatars plugin extracted from core	7 years ago
Oliver Günther	b9cd75e07e	Remove gravatar functionality from core [ci skip]	7 years ago
Oliver Günther	03250f74f2	Fix avatar spec [ci skip]	7 years ago
Oliver Günther	1d0b09fa5f	Merge release/7.1 into dev (#5667 ) * [25580] Remove Settings callbacks from avatar_helper `register_callbacks` will not work if its used to update a class-level variable. We might want to think about removing this entirely, however impermanent-memberships is still using it to update the database after a change. https://community.openproject.com/projects/openproject/work_packages/details/25580 * change toolbar button height (#5664) https://community.openproject.com/projects/openproject/work_packages/255 11/activity [ci skip] * Fix/relations drawing (#5663) * improved drawing of timeline relation lines * Improved relations data flow * Timeline relations: Load relations once the timeline becomes visible * - Fixed SwitchState failing test - Version bump ReactiveStates - cleanup [ci skip] * Set indention of breadcrumb for correct alignment * remove wiki icon for wiki submenu in main menu (#5665) [ci skip] * Add missing class * Fix table hierarchies previous values [ci skip]	8 years ago
Oliver Günther	0ae7d320e6	[25580] Remove Settings callbacks from avatar_helper `register_callbacks` will not work if its used to update a class-level variable. We might want to think about removing this entirely, however impermanent-memberships is still using it to update the database after a change. https://community.openproject.com/projects/openproject/work_packages/details/25580	8 years ago
ulferts	cf78b9fd5a	Fix/roadmaps wp list links (#5577 ) * robustness on missing sort criteria * use v3 names in url Not strictly necessary as the api can also handle the AR identifiers * adapt specs [ci skip]	8 years ago
Jens Ulferts	15479793ab	move custom value string representation to strategy	8 years ago
Oliver Günther	8d381651c8	Fix specs	8 years ago
Wieland Lindenthal	8c5be6eda7	Fix spec: Problem was that attributes must exist, otherwise they get removed	8 years ago
Wieland Lindenthal	19aba22a7c	Add validation for field `attribute_groups`	8 years ago
Wieland Lindenthal	bbbb9726c1	Latest WIP [ci skip]	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	701f196c25	eager load user and version custom fields in wp representer	8 years ago

1 2 3 4

193 Commits (46b85e5a47f01c25250df8df39057f8d54a92a2f)