251 Commits (488674bdbf3f5b2643712499b5f64ccd11466bed)

Author	SHA1	Message	Date
Oliver Günther	471a396bb3	[23775] Avoid adding a separate placeholder value (#4767) ... Since we're no longer copying select values since PR #4645, adding an empty option is now made on the actual schema values. This is fine, but closing and opening the field a second time causes the empty option to be re-added.	8 years ago
Oliver Günther	3ce2a2a807	Do not show overflow in table edit-fields	8 years ago
Alex Dik	4c5eae5b2d	Fix error resource handling	8 years ago
Alex Dik	3105acaaa6	Replace apiV3 dependency with halRequest in HalLink	8 years ago
Oliver Günther	04eb2ac6a3	Fix exiting new state where workPackageId is undefined	8 years ago
Oliver Günther	0fa357128e	Extend mocked ConfigurationService in karma tests	8 years ago
Oliver Günther	a6a554f799	Respect user configuration on exit warning	8 years ago
Oliver Günther	b9b5f4888e	[23746] Fix leaving the page upon editing ... When in an active edit mode: 1. Moving from new/copy to other states wasn't caught by the edit mode alert handler 2. Moving to other (non-angular) pages weren't caught by the edit mode https://community.openproject.com/work_packages/23746	8 years ago
Oliver Günther	37c3bfab21	Unload work package activity after save	8 years ago
Henriette Dinger	03b7c90feb	Increase clickable area of checkboxes	8 years ago
Oliver Günther	2f4919cbe5	[23615] Show error response when user is not allowed to create WPs (#4687)	8 years ago
Markus Kahl	ef523d1e1e	only prevent hiding for fields with focus	8 years ago
Oliver Günther	3b0f83b292	[23643] Use wpNotificationsService to handle error response in relations (#4681) ... A removed method in ErrorResource caused removing children to fail when the resource was invalid. https://community.openproject.com/work_packages/23643/activity	8 years ago
Oliver Günther	ebae2da48f	[23592] Fix attachments in create mode (#4682) ... This fixes the attachments section (wpAttachments and wpAttachmentsFormattableField) for the create mode. https://community.openproject.com/work_packages/23592/activity fix default delayed attachments upload fix insertion and delayed upload via drag and drop show attachments section depending on the existance of pending attachments fix removal of pending attachments show uploaded attachments without hard-refresh... Supersedes https://github.com/opf/openproject/pull/4640 with using the cache service hook	8 years ago
ulferts	6a3496d26e	prevent editing a work package while saving takes place (#4658) ... Otherwise, especially in IE with their custom change handler for select boxes, it was possible to make a change, trigger saving and while saving takes place, change another attribute and change that. Only the first change would work while the second would fail because of optimistic locking.	8 years ago
Oliver Günther	8a8aac580f	Avoid posting an empty object to textile API (#4673)	8 years ago
ulferts	0ad9a3a2df	remove non performant copy as the values are not altered anyway (#4645)	8 years ago
Henriette Dinger	f99958aa68	Set focus after submit (#4550)	8 years ago
Oliver Günther	36a926e556	Avoid posting empty objects to preview ... https://community.openproject.com/work_packages/23584	8 years ago
Oliver Günther	667dcdde52	Add wpNotificationService helper method to handle error responses	8 years ago
Oliver Günther	ec1b97041b	Always save the WP when it is new ... Otherwise, copying work packages will break.	8 years ago
Oliver Günther	f705e4d9ac	Rewrite comment directive in TypeScript without inplace	8 years ago
Oliver Günther	ea6b930582	Show 'Open in full screen' notification only when not in fullscreen ... https://community.openproject.com/work_packages/23574/activity	8 years ago
ulferts	a25717ab83	Fix/move project empty options (#4610) ... * linting * show "Please select" when the current value is invalid It is considered invalid if the value is null and it is a required field or when the value is not within the list of allowed values * remove unused variable	8 years ago
ulferts	b664210d39	Fix/force datepicker open upon first focus (#4606) ... * remove unused variable * explicilty show the datepicker upon initialization This leads to the datepicker being opened when focusing for the first time. Without it, the datepicker is only shown on the wp create page after the second focus	8 years ago
Oliver Günther	62ca484428	Allow tab read-only display fields, but highlight them ... This styles the background of read-only values when focussing or hovering them. Also, all fields regain a tabindex value of 0 to make them reachable. https://community.openproject.com/work_packages/23546/activity	8 years ago
Alex Dik	ab807b8847	Stop exposing $route on HalLink's callable directly	8 years ago
Oliver Günther	0ed6bfeca6	Swap condition in WorkPackageResource#save ... Now values can be `null` and the check is no longer valid.	8 years ago
Oliver Günther	d07ec7a3eb	Rename wpNotificationsService	8 years ago
Alex Dik	f7a9f6e51f	Refactor wpEditForm controller	8 years ago
Alex Dik	b80d224f05	Refactor wpNotification service	8 years ago
Jens Ulferts	6f4e49333b	correctly hide datepicker upon selection	8 years ago
Jens Ulferts	bc02799de9	allow refocusing when field is errorenous	8 years ago
Jens Ulferts	bb109fcfc8	linting	8 years ago
Jens Ulferts	c5d4c132c0	less magic more datepicker	8 years ago
ulferts	d800fb25c8	don't submit an unchanged wp resource (#4575) ... Checks the wp's dirty flag before actually submitting the wp. Thereby, updateWorkPackage becomes a noop if a wp has no changes.	8 years ago
Oliver Günther	efdc044a29	Avoid wpEditMode in Create Service ... Inline creation doesn't use wpEditMode.	8 years ago
Alex Dik	7e8c9beea4	Add success state redirect after new WP is saved	8 years ago
Alex Dik	c7096bb220	Add subject field ... Add subject field	8 years ago
Alex Dik	58d5ee0072	Allow saving of the work package	8 years ago
ulferts	6ed3160937	do not focus an already active field (#4567) ... Otherwise, changes to a resource will lead to a reinitialization which will lead to a refocus	8 years ago
Oliver Günther	009fe4894c	Fix execution of cancelling edit-mode confirmation	9 years ago
Jens Ulferts	7cb1c0a122	i18n for internal error	9 years ago
Jens Ulferts	4b06a41ba3	provide api independent error message for date format errors	9 years ago
Jens Ulferts	4a1274d6a3	extract wp notifications into separate service	9 years ago
Jens Ulferts	124987499a	submit date on blur when in accessibility mode ... As the accessibility mode has no date picker, we can submit it right away	9 years ago
ulferts	344c0c92ab	Fix/activate inplace edit in ie (#4560) ... * no longer require an isolated scope for clickOnKeypress As that directive is so small and is oftentimes used on the root element of a directive, having an isolated scope limits the usage of directive * reapply click-on-keypress to trigger inplace edit Otherwise, the IE will not be able to trigger the element	9 years ago
Oliver Günther	74b52eaab8	[23300] Fix date fields not being updated (#4556) ... * Fix date fields not being updated For Milestone rows, start and due date are both mapped to `date` and thus collide with the wpEditForm#callbacks helper that propagate changes from the `wpCacheService` down to edit and display fields. This fails to update the last field since they registers callbacks based on their attribute name. This commit instead suggests to use the wpCacheService directly, since the scopedObservable will handle deregistration correctly on its own. * Remove no-longer-required wpEditForm	9 years ago
Jens Ulferts	ea745865ad	remove focusability/role on non editable elements	9 years ago
ulferts	1d99206232	Fix/accessible error messages (#4529) ... * add error messages to each field * move role=alert up so that success messages are also covered * remove focus code from notification-box directive The box does not need to be focused as it has the role=alert which will lead to it being read out. * remove specific focusing behaviour for accessibility mode The mode was introduced to present error messages to user requiring assistive technology e.g. screen readers. By setting role=alert on the error fields and additionally labeling the fields with the errors, this should no longer be necessary	9 years ago