openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	769be47723	[35815] Add visible show page for all users to groups (#8949 ) To that end, move the show group routes out of /admin, that requires we use a different path helper for it as `group_path` will still link to the first admin resource.	4 years ago
ulferts	ef948465a1	fix atom export (#8952 ) The feed is opened in a new window so that the url can then be copied into a client while the original view persisted. The solution is not optimal as it requires to call the backend twice but as this function should be used very little, it should be enough	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code Found via `codespell v2.1.dev0`	4 years ago
Behrokh Satarnejad	f0669247a5	[33163] Add work package filter for child work packages(implementing the component in another way) (#8826 ) * implementing the component in another way * refactoring the code * resolving codeclimate errors * indentation fix * resolving quotation marks errors * resolving the travis errors * resolving codeclimate errors * implementing the component in another way * refactoring the code * resolving codeclimate errors * indentation fix * resolving quotation marks errors * resolving the travis errors * resolving codeclimate errors * implementing the component in another way * refactoring the code * resolving codeclimate errors * indentation fix * resolving quotation marks errors * resolving the travis errors * resolving codeclimate errors * focus the component after inintialization and use array functions instead of lodash * adding a test for parent filter Co-authored-by: Aleix Suau <info@macrofonoestudio.es>	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Aleix Suau	055086577d	Fix/34711 swap background colors of sum rows and group rows (#8767 ) * Total sums row: changed title and moved above 'create wp' row * Tests fixed * Total sum row: no height when void + overflow ellipsis on title * Total sums row: changed title and moved above 'create wp' row * Show 'Total Sum' full-width * Total sums row: changed title and moved above 'create wp' row * Tests fixed * Total sum row: no height when void + overflow ellipsis on title * Total sums row: changed title and moved above 'create wp' row * Show 'Total Sum' full-width	4 years ago
Inga Mai	5a79243953	[32928] Move cost reports to a submenu (#8627 ) * Move cost reports entries to submenu and adapt html structure to other submenus * Adapt styling to wp query menu and make styles generic * Highlight menu entry and sub entries on select, let submenu stay opened and make catergories toggleable * Adapt styling of project and global cost reports to other submenus * Only show category if it is not emtpy * Fix failing spec * WIP: Don't show empty submenu * Add placeholder for empty queries and show categories again * Fix menu entry highlighting Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	7a4826e6c9	attempt to fix flickering spec	4 years ago
ulferts	5e33c4b637	ensure all enqueued jobs are run	4 years ago
Benjamin Bädorf	488cd3eff9	Fix/wysiwyg changes (#8884 ) * Only set styling on code-block when editing * CKEditor fixes Adds op-uc-figure--content fix for tables, Adds op-uc-container to preview, * Left align figure content by default, making the changes in appearance less severe * Revert wrapping table in op-uc-figure--content in edit mdoe * Update CSS Classes spec * Resize figcaption together with image * Add underlines to headings on wiki pages * Remove word breaking from tables * Left align images in editor * Avoid break inside all figures, including images * linting * restrict lines under headings to h1 only * remove ckeditor changes * adapt spec to altered l10n string * revert expected css classes since ckeditor remains unchanged Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Benjamin Bädorf	7c36920ab8	Only set styling on code-block when editing (#8880 ) * Only set styling on code-block when editing * Only overflow code blocks in view mode * Update code-block styles to wrap text in edit mode * Fixed language indicator for code blocks * Fix spec class	4 years ago
Aleix Suau	53f8e985ff	Fixed: figcaption kept inside the image (#8882 ) * Fixed: figcaption kept inside the image * adapt specs to altered figcaption handling Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	7a738cebc6	Feature/group fold button (#8863 ) * add fold/unfold groups button * wip * introduce service to communicate fold state * fix colspan on folding/unfolding groups * move state handling into service * refreshAllGroupHeaderCells when allGroupsChanged too * have correct order for states to update * rely on refreshView to trigger collapsedRowRefreshing The refreshView method is called whenever a group is folded/expanded. Therefore, the listeners for the states are just extra and lead to the code being executed twice. * remove code made obsolete by commit before * show group toggle button only when grouping * use plus/minus icon for button * shorten code * remove duplicated code * linting * dropdown for expand/collapse * add icon to button * alter button position and switch icons * remove text from group toggle button * have unique html id on fold button * Rerendering only group rows when grouping changes * Disable unavailable menu collapse option + merge old collapse state * refreshAllGroupHeaderCells when allGroupsChanged too * Disable collapse options handling mixed scenarios * Working with different grouping & updating grouping options disable * Code climate fixes * Fix + Types with headers extracted to service * Test fixes * CodeClimate fixes Co-authored-by: Aleix Suau <info@macrofonoestudio.es>	4 years ago
ulferts	df65b83d81	attempt to stabilize flickering spec	4 years ago
ulferts	2ad215fed1	add milestone type filter for default project gantt query (#8869 )	4 years ago
Benjamin Bädorf	e848d44dea	Fix/update wysiwyg styles (#8844 ) This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances. * Initial class definitions * Added more classes * Added Table of Contents basics * CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote * CKEditorInspector removed * op css class for headings * op css class for paragraphs * op css class for code/code block * adapt specs to altered markdown/html generation * adapt grid/budget representers to altered signature * op css class for lists * op css class for toc * op css class for links * Start working on typography css * op css class for tables * Fixing more typography, trying out larger headers * Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros * adapt specs to altered link classes * op css class for images * apply user content container class throughout application * CSS alignment custom classes applied to table * op css class for task list checkbox * Added task checkbox class * amend list checkbox class in backend * op css class for table thead element * adapt specs on image html generation * Updated table and typography styles * Update typography and figure styles * Figure overflow handling * Table alignment styles + ckEditor styles removed * rename wiki-anchor to op-uc-link_permalink * wrap table in div as well as figure * Updated code-block * Update permalinks * Fixed a lot about tables * Removed Description header from work-packages page * Fix frontend styles * Add placeholder styling, fix toc * Fixed figure print * working with table aligns * Custom class add to task lists * Custom classes applied to theads * op-uc-container custom class added to container * Codeblocks inside pre elements * Fix: single <code> and <a> tags * explicitly require overwritten gem class Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode * adapt spec expectation to altered toc rendering * CkInspector removed * Latest ckeditor changes * remove highlight css class from wiki content * allow html pipleline to handle macros with additional classes * Fixed a lot of print css for tables * Add general print css back in * Update Table of Contents styling * Custom classes on ul, ol, li and task-lists * Revert "Custom classes on ul, ol, li and task-lists" This reverts commit `0d27d28137`. * Custom classes on ul, ol, li and task-lists * Custom classes on column's th * remove placeholder class when rendering * WOrking on task lists * Changing task-list classes, changed tests * Updated list styles * Remove unused todo list styles * remove checked in binstubs * Fix table of contents * adapt todo list handing in backend pipeline * adapt specs to altered css classes * Add numbers to table of contents * Better comments in table of contents * Fix: wrap single <table> with a <figure> * Fixes to todo list design * Updated todo list scss to fix nested lists * adapt selectors in table spec * Update table styles * Improve table borders more * Custom classes specs * Fix: no need to remove regular list classes when its type changes * Add modifier for inline headings * Update table editing styles * Remove break-word tests * wrap images just like tables * Update figure content styles * Fix: All tests passing (ul.op-uc-list_task-list) * div.op-uc-figure--content wrapping tables * Specs for figures wrappers div.op-uc-figure--content * Fix: add custom classes to links and codes again * Table wrapper div reverted + specs * Fix inline palceholders * Custom macro type classes * Add basic macro placeholder changes * Move heading permalink after text * Fix word-break spec * Sending figure styles to the backend (width) * extend test to take ckeditor placeholder into account * avoid adding bem classes multiple times * attempt to fix flickering spec * Removing image spinner when uploading finishes * adapt spec expectations Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765 ) * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
ulferts	7f34799a33	Chore/reimplement global roles (#8730 ) * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter	4 years ago
ulferts	8c554ba0c9	Feature/mentions rewrite (#8853 ) * update ckeditor * output user-mention link on mention tag * spec revisiting a user mention * amend mention recipients by tag * handle wp mentions	4 years ago
Aleix Suau	459bbcb80a	Feature/32616 show children in row on collapsed parents (#8800 ) * Showing milestones on collapsed project rows * Showing milestone's labels on hover * Milestones adapting to zoom changes + refactor * Refactor to make it applicable to other wp types * Calculate timeline width including wps shown in collapsed rows * Tests * Custom labels for duplicated cells * Custom labels for duplicated cells * Hide empty labels on hover * All tests passing (switched to isMilestone function) * Make up * Showing milestones on collapsed project rows * Showing milestone's labels on hover * Milestones adapting to zoom changes + refactor * Refactor to make it applicable to other wp types * Calculate timeline width including wps shown in collapsed rows * Tests * Custom labels for duplicated cells * Custom labels for duplicated cells * Hide empty labels on hover * All tests passing (switched to isMilestone function) * Make up * Refactor fix * Empty line at the end of the file * Empty line at the end of the file * Hide non hover labels on group rows * Only include header cells for wp with date or startDate * Add group header cells into Autozoom width calculations * Showing labels on group headers * LabelRight's padding reduced * group-row class name changed to modifier -group-row * withCustomLabels moved to WorkPackageCellLabels class * withCustomLabels renamed to withAlternativeLabels * isDuplicatedCell and withAlternativeLabels moved into RenderInfo * Typings improvements * Duplicated code extracted to getWorkPackagesToCalculateTimelineWidthFrom * Conditional flag moved out of manageCollapsedGroupHeaderCells * manageCollapsedGroupHeaderCells setup extracted to a method * manageCollapsedGroupHeaderCells setup extracted to a method * manageCollapsedGroupHeaderCells setup extracted to a method * Group logic extrated to groupTypeFromIdentifier and groupIdFromIdentifier methods * Remove 'project' hardcoded reference from createCollapsedGroupHeaderCells * Common pipes grouped in a getter * Codeclimate fixes	4 years ago
Benjamin Bädorf	5f45ee07ab	Move development docker-compose file to the main directory (#8798 ) * Move development docker-compose file to the main directory This requires us to move some other files around, like the pullpreview and example docker-compose file for production setups. This commit also does some housekeeping, like removing some old files and deduping configuration. * Updated to selenium grid * Fix in-Docker Selenium tests The Selenium tests now run inside a Docker Chrome Container. Backwards compatability with non-docker setups is not guaranteed, though it should not be hard to implement with a couple of small fixes. * Updated docker development documentation * Improved test timings, changed the documentation * Updated docker testing again * Run npm in the frontend directory * Really run npm in the frontend directory * Also run npm in frontend when setting up travis cache * Change directory for one command only * Change default test driver name * CI test change fixes * Fixed syntax error * Added dev check * Trying to fix firefox resizing * Trying to get tests running * Stop resizing firefox * Fixed apple icon spec * fix host in url helpers for omniauth spec * Fix omniauth specs * Fix docs * Small fixes to docker tests * Added package.json back in * Change env variables Co-authored-by: Markus Kahl <machisuji@gmail.com>	4 years ago
ulferts	f511f8d4f5	set default role when copying project as non admin (#8824 )	4 years ago
Wieland Lindenthal	c919da0550	Fix: #35132 Activity broken for wiki pages with slashes in title (#8823 )	4 years ago
ulferts	5a7176e6e1	Fix/search for projects (#8815 ) * fix searching for projects * only provide search options active in the project	4 years ago
Markus Kahl	a8f04ae044	make sure API settings controller is loaded by declaring the API acronym (#8792 )	4 years ago
ulferts	0e6072aefa	fix accessibility spec expectations	4 years ago
ulferts	a842f44bda	[22048] Destroy journals after destroying journalized * clenaup journal data upon aaj model removal * remove unused methods * simplify aaj options handling * delete orphaned journaled data via migration Existing instances might already have journal data for which the journal itself is deleted. This migration removes them.	4 years ago
ulferts	bf89e934b3	set the default value for newly build custom values Most of the time, the getter #custom_field_values is used with unbeknown to the caller will build custom values for not covered custom values. This method always assigned nil to the value of the newly build custom value when it should have used the default value. Once that is fixed, all models including acts_as_customizable will again have set the default values for custom fields correctly. This is true regardless of wether the custom value is added before or after the creation of the model. Only for work_packages is the additional method #set_default_values! required as the availble_custom_field might change during a request upon a switch in project and/or type.	4 years ago
ulferts	8dfc5e8803	fix touching the customizable on removing custom_values Before the commit, the existing custom_values where attempted to be reused but there was no deterministic behaviour with which reusing them was attempted. Additionally, the existing values where always changed (or they would receive the current value again) whenever values where provided, regardless of whether those values actually changes. There was no explicit flag that a value was removed. This poses a couple of problems: * Even if no new values where provided the order of the custom values as stored in the db might change leading to journal entries that where not actually caused by the user. * If values where only removed, due to the missing explicit removal flag, it became luck whether an existing custom value was actually changed. Only then would the customized object be touched leading to an update of cached fragments, i.e. representers. * Because the values where updated all the time, the performance would suffer. * Removed custom values where removed right away and not only after save. This commit introduces an explicit flag for removal and does not alter existing custom values. This might have the drawback of creating a custom value even when a value, chosen to be removed by the user, could be reused but this should be negligible. It also has the drawback of introducing a flag to be maintained.	4 years ago
Oliver Günther	76823ca581	[34446] Fix direct upload with backend-generated resources https://community.openproject.com/wp/34446	4 years ago
Oliver Günther	d29266f5bd	[34291] Use placeholder for new resource dates https://community.openproject.com/wp/34291	4 years ago
ulferts	8969afe617	close time entry modal on enter (#8653 ) * close time entry modal on enter As the time entry is saved anyway once the user saves the form, e.g. by pressing enter in the hours field, we can close the whole modal along with it. The "Save" and "Cancel" buttons do not make sense then anymore * attempt to stabilize flickering spec * fix ruby 2.7.1 hash parameter deprecations	4 years ago
Oliver Günther	6881f3d347	[33696] Retain autologin cookied request in session https://community.openproject.com/wp/33696	4 years ago
Oliver Günther	2e2f520130	Avoid updating the just created user to retain id information We need to track whether the user was just created to show a different message. For this, avoid any calls that save the user _after_ RegisterUserService.	4 years ago
Oliver Günther	5969d8239b	Correctly continue activation after registration error	4 years ago
Oliver Günther	841e1149c2	Don't show an error when the user just registered In case the user still needs to activate e.g., via mail, it should not be shown an error message, but instead the success message from the registration service	4 years ago
ulferts	245a7ddfcf	Fix/duplicate work packages across pages (#8651 ) * deprecated method * remove apparently unused methods * append id desc sorting to work packages * enforce sorting is applied in query results * ensure deterministic order in base query	4 years ago
Oliver Günther	506ad2e4eb	Use slide toggle on the project boolean filter (#8643 ) * Allow the slide toggle to be used on project as well * Add slide toggle to styleguide * Change spec to test slide toggle filter * Rename filterValue to active	4 years ago
Oliver Günther	a91ab2e686	[33766] Show errors when CF is invalid in project form https://community.openproject.com/wp/33766	4 years ago
Oliver Günther	1774f3fc45	Only filter for active projects	4 years ago
ulferts	a9dfb35150	avoid modifying frozen string from nil	4 years ago
Oliver Günther	3a0020f17a	Add title to explain what the button does and disable if no results	4 years ago
Oliver Günther	2e62fb8b22	Remove matrix in favor of multiselect	4 years ago
Oliver Günther	213153721e	Ensure cache is cleared for settings	4 years ago
ulferts	2562bd6475	Fix/bump gems (#8613 ) * bump em-http-request * bump warden * hopefully stabilize flickering spec	4 years ago
Oliver Günther	4aad0c8b72	Generate URL params for gantt view and insert projects	4 years ago
ulferts	05c9e3fca6	Feature/default dates for children (#8605 ) * fix start_date expectation based on setting * extract methods * set dates of parent work package * pass parent on form request * have initial dates displayed correctly in wp create form	4 years ago
Oliver Günther	becefba1c4	Allow template to set the default advanced settings once selected Previously, advanced settings were simply hidden when project templates were selected. This however prohibits setting/overriding certain attributes, such as the parent project. This commit results in: - Selecting a template will reload the page - When advanced settings were opened, confirms from the user that the page should be reloaded - The template is being applied to the new project to ensure the attributes are being used - The user can then override or delete whatever params she wnats	4 years ago
Oliver Günther	e2db9e2063	Use firefox headless on the code block	4 years ago
Behrokh Satarnejad	c92c750625	[30242] Extend work package autocompleter with more useful information (#8554 ) * WP auto completer changes in global search box * resolve the travis check errors	4 years ago

1 2 3 4 5 ...

2068 Commits (499fd3c2075bc779543e5daf8ece3cd3768391b6)