openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	1f66b19112	Fix double escaping of repository path params	9 years ago
Oliver Günther	1360639341	Fix URI escaping of svn checkout paths The paths weren't properly escaped for URLs. This fix allows any subdirectory of arbitrary chars to be displayed as a checkout URL. This also fixes an escaping issue in the adapter that prohibits checking folder with special characters which SVN doesn't care about.	9 years ago
Oliver Günther	396dcdd859	Add path-based checkout for SVN	9 years ago
Oliver Günther	d36c7d6591	Fix committers array access When adding a new committer to a repository, the user collection was `compact!`ed, which no longer exists on relations with Rails 4+. Thanks to @gehasia for spotting and proposing a fix for the bug.	9 years ago
Stefan Botzenhart	1f53f5472e	Code style enhancements to fight against bad scoring	9 years ago
Oliver Günther	dc90d71942	Replace severer warnings with danger zone This commit removes the `.-severe` warning notification type in favor of the danger zone.	9 years ago
Oliver Günther	bef80793a0	Small visual corrections for checkout This commit provides: * An integrated annotation warning display, when the entry could not be annotated (most often due to it being binary). * Hide current rev_id for subversion when no branch/revision is given.	9 years ago
Oliver Günther	1481afb666	Corrections from review	9 years ago
Oliver Günther	6661f2b6d5	Refuse to delete a repository in OpenProject on FS permission errors This commit changes the behavior of removing repositories. It is no longer possible to remove a managed repository (model) when the underlying repository directory could not be removed. This error originally occurred when Apache committed changes to the repository through mod_svn, which resulted in the OpenProject user being unable to delete a particular subdirectory.	9 years ago
Jan Sandbrink	f9cb083481	in production handle internal API errors gracefully - still allow for useful errors during development - let all own exceptions inherit from StandardError, the thing you should use for own errors...	9 years ago
Oliver Günther	dfb8ac4853	Add basic checkout instructions This commit adds very basic checkout instructions similar to `openproject-checkout` to repositories. Issues: * Uses table style for checkout component, as exact styling is unclear * Adds compressed table style with less padding * Checkout settings are best organized in a Hash with keys per SCM * vendor. Using default settings, a lot of new setting values would be introduced * Checks for Hash in SettingsController * Currently can't use SettingsHelper, as it requires single setting values	9 years ago
Oliver Günther	0b583c3ccf	Extend autofetching of commits into update repository information This commit extends the previous functionality of autofetch commits into internal updating of repository information, which encompasses: * Commit information (changesets) * Disk space information They are now both retrieved when browsing the repository and the latter is fetched asynchronously whenever the last update is older than the timeout setting. This timeout setting is now user-configurable.	9 years ago
Oliver Günther	3ccde73519	Allow automatic creation of manageable repositories through a setting This commit allows manageable repositories to be automatically created by default whenever a new project is created and the repository module is activated. Relevant work package: https://community.openproject.org/work_packages/21277	9 years ago
Oliver Günther	06d203141e	Remove outdated flash message Managed repositories are always deleted, even if the configuration states otherwise. The specific flash message concerning deletion of managed repositories is thus wrong and was removed.	9 years ago
Oliver Günther	c5b200d7a0	Review corrections - Remove repositories paths using project.id instead of `project_id` - Allow managed repositories to be unlinked in the instance (But doesn't remove repository directory). - Remove leftover settings partial	9 years ago
Oliver Günther	0284d11f21	Corrections from review - destroy_info: remove superfluous JS confirm dialog. - destroy_info: change notification type into severe warning - destroy_info: Remove delete button highlight and back button for consistency with styleguide. TODO: think of other ways to guide the user back (also applies to project destroy_info) - remove typo in 'repositories.errors.unauthorized' - empty repository: Render warning view (repositories/empty) instead of 500 exception notification. - revert reformat on code changed in rails4 branch. - create repository: Show managed flash part only when the repository is managed - delete repository: Show error when configuration no longer allows manageable (other ways tbd.) - repository controller: JS redirect wrapped inside format.js - repository settings: Select hidden when instance exists Specs: - Add routing spec for `get #destroy_info`	9 years ago
Oliver Günther	319bd21daf	Moved managed repository lifetime entirely to the model.	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	b0c0d0a53f	Avoid fishy factory delegation.	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the legacy specs for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Alex Coles	8b4be7f749	Indent fix in RepositoriesController for Rubocop [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0ad3cfb4b2	Prefer do…end for controller respond_to blocks `rubocop -a` does not currently normalise formatting consistently (see `ec1bb39f`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0942d7335b	Add explicit join references in controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ec1bb39f9b	Fix syntax (w/Rubocop) in (Rails) controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	13e0940171	only display scm options if they are configured	10 years ago
Jens Ulferts	b37ea687e2	showing error messages on scm updates	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Alex Coles	8a28b1a730	Prefer #map over #collect in (Rails) controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	bb0e6e6aa5	Fix syntax (w/Rubocop) in (Rails) controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	336446c59d	Use 1.9+ Hash syntax in (Rails) controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago
Jens Ulferts	dc98efb5ac	fixes route globbing for repositories	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Michael Frister	774be9fc43	Don't embed commits per author graph for unauthorized users	11 years ago
Michael Frister	a9d2520b00	Deny access to repository commit author stats for unauthorized users	11 years ago
Hagen Schink	0030de86be	Adapts format handling	11 years ago
Hagen Schink	1edbf747cf	Adapts Rails3's changed route globbing behavior In Rails3, globbed routes are strings and not arrays.	11 years ago
Jens Ulferts	6c720a8d5d	changes the last controllers to will_paginate Uses page_param and per_page_param calculation from PaginationHelper for all of the controllers Adapts the api views	12 years ago
Jens Ulferts	09b1c00e69	uses will_paginate for changesets	12 years ago
Jens Ulferts	21459a384f	provide every possible file with a short copyright notice This was done using the rake task: rake copyright:update	12 years ago
Philipp Tessenow	ec3829e11b	be careful with nested namespace'd controllers in our controllers	12 years ago
Martin Linkhorst	6200acf6f6	fix some active record queries for postgres and apply a patch from redmine at the same time	12 years ago
Martin Linkhorst	09e496f54b	REVIEW: get the changes by joining with the changesets in order to have access to the #committer of the changesets as required in the tests which group changes by the committer	12 years ago
Dennis Schmidt	958f58a4f2	remove default ordering for count(*) query (Postgres)SQL requires columns in ORDER BY to 'appear in the GROUP BY clause or be used in an aggregate function' which doesn't really make sense here: as we are grouping, ORDERing is pointless anyway.	12 years ago
Martin Linkhorst	aa297a2a99	fix repositories subversion controller	12 years ago

1 2 3

139 Commits (4a2afe49023c5d463fc6b3a3f0679066a16fbd5e)