openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	e652268b44	Avoid explicitly testing html output	8 years ago
ulferts	3b1976a5aa	Fix/accessible pre and suffix (#4601 ) * accessible form pre- and suffix Both pre- and suffix are attributes with aria-hidden="true". This should lead to them no longer being read out of context. In order to have them read when appropriate, the prefix is turned into a part of the label which is hidden for sighted users. The suffix is referenced in the form element via aria-describedby. * extract method refactoring	9 years ago
Oliver Günther	d49ba37e0a	Remove explicit required label for impaired users Denote inputs with `aria-required="required"` instead of a separate span within the label, which causes double mentions of the field being required (once through the html5 attribute when the screenreader is compatible) as well as in the label span.	9 years ago
Oliver Günther	bbfe941e77	Refactor required star into separate spans Seperate spans for visible and impaired users allows us to replace the spelled out Asterisk from pseudo content with a proper aria-label.	9 years ago
Oliver Günther	86a061b6e7	Add separate span with error message for the current field	9 years ago
Oliver Günther	ce503e3306	Add error handling to form labels This re-enables an `-error` state for labels when the associated field is erroneous. Also shows an error icon next to the label and changes the font style.	9 years ago
Oliver Günther	412becb62e	Fix icon-add missing spec	9 years ago
Mohamed Wael Khobalatte	03cce5e25d	Avoid defining same constants in multiple specs	9 years ago
Alex Coles	acb2aa7eb1	Fix TabularFormBuilder HTML matching Use #be_html_eql matcher in TabularFormBuilder spec (see `1f42f127`) to avoid relying on specific order of attributes. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	51b335fe35	Fix FormBuilder method signatures in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jens Ulferts	7bdef98f0e	set de and fr as default locales	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	6bd66e3876	Append -required modifier class rather than markup Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e7be3c2b51	Add spec coverage for required form field labels Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	da4d6ef6a7	Simplify TabularFormBuilder field label specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	a2e02d8202	Update FormBuilder specs for removed default opts. Rails 4 no longer sets default values for `size`, `cols` and `rows` on `input`, `textarea` tags. See `3384ee24ad` (part of https://github.com/rails/rails/pull/5366) Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	f781a4d6ff	increase robustness when no label is specified on tabular form field	10 years ago
Florian Kraft	042b16b2cc	fix using the label method in conjunction with OpenStruct	10 years ago
Florian Kraft	f145a1c31f	remove superfluous call to squish	10 years ago
Florian Kraft	91440250ab	please the hound [ci skip]	10 years ago
Florian Kraft	ab54a57165	upgrade the labels in formbuilder this will add a title attribute to labels to make them readable when collapsed	10 years ago
Florian Kraft	9041b2bf25	refactor form builder option handling Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Florian Kraft	03577a6334	please the hound [ci skip] Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Florian Kraft	bf620c7443	add radio button to tabular form builder adds a labelled version for radio buttons to the tabular form builder Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Jens Ulferts	387b1b7cd0	fix spec expectation	10 years ago
Alex Coles	763e576be7	Add a #within_path option to #be_html_eql matcher * Update TabularFormBuilder spec to use #within_path Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	8e291d3b08	Minor Hash formatting fix for Rubocop Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	90b1405140	Teach TabularFormBuilder prefix/suffix options Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	3189ce519b	Obey line length limits in TabularFormBuilder spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	1f42f12747	Use #be_html_eql matcher in TabularFormBuilder spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Florian Kraft	d46b8a0edf	do not replace existing classes also, add some tests Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Jens Ulferts	46258c6e0b	remove duplicate form-container + unnecessary dom attributes	10 years ago
Jens Ulferts	44f122ed4b	extract custom_fields form logic into separate builder	10 years ago
Jens Ulferts	8acfdadab0	add custom field to form builder - apply to version	10 years ago
Alex Coles	48569e11fc	Add classes to TabularFormBuilder localized fields Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	647a1e7aca	Add specs for TabularFormBuilder localized fields Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	65de31a7c7	use tabular form builder for project module selection * Extends the tabular form builder with the ability to generate check boxes for values that are an array. * Fixes module_enabled? to actually return a boolean * Adapts projects_controller to changed params structure.	10 years ago
Alex Coles	978bfb7077	Fix TabularFormBuilder handling of custom classes Multiple classes were not delimited properly with a space. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e6397977ce	Extract duplicated shared examples into own file Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	1e122b9518	Do not double wrap fields with no_label option Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	3db2f0f638	Update TabularFormBuilder for multiple fields/row Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	8663ceeb6e	Update TabularFormBuilder to apply form classes Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	494a81d726	Obey line length limits in TabularFormBuilder spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	a9340b22d5	Test more exact output in TabularFormBuilder spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	bc011ea375	Add basic spec for TabularFormBuilder Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago

47 Commits (4aae575459c42b12a8c9950cdc4f5af1dcf66ee2)