openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	d4182ef24e	[25877] Validate the correctness of a CF regexp https://community.openproject.com/work_packages/25877	7 years ago
ulferts	c0b709530c	Fix/replace deprecations (#5533 ) * replace alias_method_chain * remove deprecation silencing * bump controller-testing * introduce permitted params for settings * replace various deprecations in controllers * remove deprecation silencing for legacy_specs * remove `puts` from spec * replace deprecated access to errors * remove unnecessary AR::Parameters usage in spec * specify error to expect * replace deprecations * replace deprecated action calls in legacy function specs * replace deprecations in functional controller tests * replace deprecations in controllers/controller_specs * remove params parser which does not seem to be in effect It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code. * replace deprecations in unit specs * replace alias_method_chain [ci skip]	7 years ago
ulferts	75f501e897	Fix/custom field lacking options (#5768 ) * enforce having at least one custom option for a list cf Removes the hand written nested attributes handling by accept_nested_attributes_for. Removes the arbitrary boundary of having 500 custom options. * i18n for custom option mgmt [ci skip]	7 years ago
Oliver Günther	86c17f5c22	[25829] Don't provide start/due date as help texts We don't have an option to show them in the combined start/due date fields of the single view. [ci skip]	7 years ago
ulferts	4b7e3ff26d	Feature/limit attribute help text visibility (#5749 ) * code prettification * avoid help text for newly added cf requiring restart When using the class method statically, the values are determined upon reading the class. By that, a restart is required before newly added custom fields are added to the list and removed custom fields will still be listed * limit visibility of attribute help texts [ci skip]	7 years ago
Oliver Günther	52fdada767	Fix/help text bugs (#5745 ) * [25778] Sort available help attributes * [25799] Use proc for inclusion check Otherwise, that value is never re-evaluated. A newly created CF will fail to be found. https://community.openproject.com/wp/25779/ * [25780] Remove paragraph signs in headings of help text modal * [25781] Overflow help text modal after 50vh * [25782] Add ellipsis to modal header [ci skip]	7 years ago
Oliver Günther	9fabaaaf13	Show only attributes from the type attributes and status, project	7 years ago
Oliver Günther	57356059af	Create /help_texts endpoint	7 years ago
Oliver Günther	39e11c72dc	Create backend for help text CRUD	7 years ago
Oliver Günther	8956700408	[25374] Remove attribute visibility	7 years ago
ulferts	39bbf082bf	fix author filter for projectless users (#5718 ) As the principals returned by the principals API where limited to those that are members in projects the user can see, users not having any project would not be returned. This is intended in so far as to prevent getting all users easily. But the user herself should be visible in any case. [ci skip]	7 years ago
Oliver Günther	dae84cffb0	Extract editing member into a separate service Would have liked to use the contract here to validate the role_ids before they're being written to attributes, but that doesn't seem to work.	7 years ago
Oliver Günther	b2b499a7fd	[25686] Use collection_check_box in membership page This adds a hidden field for when no checkbox is selected, however it adds the caveat that non-selected values are transmitted as empty values, thus we have to filter them again in the backend.	7 years ago
ulferts	fc139e55df	limit visibility of relations index (#5703 ) [ci skip]	7 years ago
ulferts	fb9e9088a0	append file type to export (#5704 ) broken in `267f9b0ea2` [ci skip]	7 years ago
ulferts	c70aa76ea0	mimic AR join alias calculation for query (#5682 ) * mimic AR join alias calculation for query * remove unused columns parameter on v3 query get [ci skip]	8 years ago
ulferts	3a890a5645	Fix/remove relation columns from export (#5652 ) * provide common interface to exporters - exclude relation columns * code prettification [ci skip]	8 years ago
Wieland Lindenthal	7d42817f49	feature #25517 Allow custom favicon and touch icon upload (#5653 ) * Allow custom favicon and touch icon upload * fix tiny copy and paste error that lead to error in pull preview [ci skip]	8 years ago
Oliver Günther	bbd10c8dfe	Review remarks	8 years ago
Jens Ulferts	9323ded10b	add missing ) to watcher filter sql statement	8 years ago
Markus Kahl	e8eefcbdaf	migrate from chiliproject 2.11 (#5340 ) * make User#system work on old database Assigning a password fails on an old database version. We don't need one so let's drop it. * added rake task for migrating version and project attachments * fixed old migrations to work with current code (WIP) * fixed wiki migration (slug was not visible yet) * added rake task allowing to move files again outside a migration * moved main logic into separate modules * implemented sequence skip for mysql; don't reset anymore [ci skip]	8 years ago
ulferts	e64adffead	fix csv export/xls import if first column is 'ID' (#5646 ) [ci skip]	8 years ago
ulferts	16f0cace89	Fix/wp copy with cf (#5638 ) * fix copying cf values on wp copy * use angular copy form if only one wp copied [ci skip]	8 years ago
ulferts	f4b36edccb	Feature/save zoom in query 7 1 (#5637 ) * Implement timeline zoom level as query enum * Implement query zoom handling in frontend Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query. * Extend feature spec for zoom saving * Refactor URLParamsHelper into TS service * Fix comparison in table query services * Remove reference to allowedValues [ci skip]	8 years ago
Oliver Günther	2c0ebf0a6e	Add relationType to relationOfType column So we can avoid matching the id/href in the frontend.	8 years ago
Oliver Günther	8dc3d58780	Apply sorting check in huge_list https://github.com/opf/openproject/pull/5635	8 years ago
Oliver Günther	f273825199	Compare sorted output of allowed values Otherwise, sort of input is relevant for validity	8 years ago
ulferts	55695ed756	adds query columns by relation type (#5625 ) [ci skip]	8 years ago
ulferts	3f4bfb52ee	memoize custom_field evaluation for default_attribute_group (#5627 ) This can become quite costly when the same calculation is done 200 times (for each custom field that could be active on the type) [ci skip]	8 years ago
ulferts	cea23ce333	Fix/sort version filter options (#5630 ) * have version filter options ordered by name * Fixes filter options on global queries (returned types instead of versions) * Adds the name order to be available generally * code prettification [ci skip]	8 years ago
ulferts	20dd8a6e0a	Feature/work package id filter (#5614 ) * add filter for work packages by id to query * hide the id filter in front end As we do not yet have satisfying means to display the filter values for selection, we hide the filter and use it internally only [ci skip]	8 years ago
ulferts	2f7f60e3b2	add missing ) to watcher filter sql statement (#5629 ) [ci skip]	8 years ago
ulferts	ace7098eb3	add relations columns to query (#5606 ) * add relations columns to query * refactory query columns * rename QueryColumn to QueryColumn::Property QueryColumn is now only an abstract supertype [ci skip]	8 years ago
ulferts	41aea10480	fix user/version cf rendering in forms (#5610 ) [ci skip]	8 years ago
Oliver Günther	6b372acae6	Implement timeline zoom level as query enum	8 years ago
ulferts	346647e583	fix comparing available_values to values (#5609 ) Need to force the available values to strings [ci skip]	8 years ago
Oliver Günther	5b5326db4c	[25438] Fix only saving changed column positions (#5608 ) When changing only the positions of the default query columns, the query incorrectly checked only for the permutation of the default columns, not the actual order. Thus the columns were not actually saved in the query. Additionally, the `observeUntilChanged` incorrectly reflects previous values which causes the movement of a column twice to only result in a move by one position. As this was already suggested to remove in https://github.com/opf/openproject/pull/5597, let's resolve this together in this PR. [ci skip]	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465 ) * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	94234bd5ee	[25432] Correctly transmit hasDefault to frontend (#5603 ) The default value for CFs is '', which is obviously not nil despite not being a default, however the frontend only _always_ shows the attribute when it is required and has no default. This PR also adds a 'always visible' flag to the form configuration when the CF is set required. [ci skip]	8 years ago
Markus Kahl	9312bef8bc	use precision 3 to show sizes below 100mb correctly (#5598 ) [ci skip]	8 years ago
ulferts	b396a4d97b	fix sorting by parent (#5580 ) The default direction is still ASC. But when applying the ASC statement directly to the sortable string, it becomes impossible to filter DESC. [ci skip]	8 years ago
ulferts	d9aab230fd	Fix/empty filters on export (#5579 ) * place empty filter set in representation url This will allow the empty filter set to override the default filter (status - open) * remove now unused method * persist having no filter in the url params Otherwise, the default filter (status - open) will reappear on reload [ci skip]	8 years ago
Oliver Günther	5d6555d79f	Fix group label in PDF export (#5581 ) [ci skip]	8 years ago
ulferts	86c2f3d59d	Fix/increase query api robustness (#5574 ) * removes unavailable filters on valid_subset! * remove invalid columns on valid_subset! * cleanup query form and collection * code prettification * add status to spec in order to have valid queries [ci skip]	8 years ago
Oliver Günther	f324aaff63	[25369] Avoid console errors when quickly moving between queries (#5566 ) [ci skip]	8 years ago
Oliver Günther	1259904d82	Fix ArgumentError in QueryRepresenter (#5564 ) quick fixes ``` ArgumentError: Column needs to be set from /usr/src/app/lib/api/v3/queries/sort_bys/sort_by_decorator.rb:41:in `initialize' from /usr/src/app/lib/api/v3/queries/query_serialization.rb:194:in `new' from /usr/src/app/lib/api/v3/queries/query_serialization.rb:194:in `block in map_with_sort_by_as_decorated' from /usr/src/app/lib/api/v3/queries/query_serialization.rb:193:in `map' ``` [ci skip]	8 years ago
Oliver Günther	8fcfc834a3	[25269] Add typed_custom_value_for to retrieve CF value names To provide a common interface to get _ALL_ values for the given custom field id (either multi or single value), this PR adds `typed_custom_value_for` which maps all custom_values (if any) to their `typed_value`s. This is a requirement to output all values in `QueryCustomFieldColumn`.	8 years ago
ulferts	2a71172837	prepare the query before reading results (#5547 ) * prepare the query before reading results * use string for list cf filter value because all other list filter also use a string * handle invalid group, columns, sort on query read [ci skip]	8 years ago
ulferts	8b823a6861	bump rails to 5.0.3 (#5544 ) * bump rails to 5.0.3 * adapt specs * fix specs * avoid naming conflict in association method Because of https://github.com/rails/rails/pull/28246, association methods can currently collide [ci skip]	8 years ago
Oliver Günther	d9456e5a60	[25091] Don't take over the timestamp values from old project [ci skip]	8 years ago

... 4 5 6 7 8 ...

3424 Commits (4ae46c322c4121ae2d405f30a587cb84fcba5b1e)