openproject

Commit Graph

Author	SHA1	Message	Date
Henriette Darge	318a0e56fd	Add LinkAttributeFilter to be able to add "target" attribute. Thus the "privacy policy"-link opens automatically in a new tab	3 years ago
Benjamin Bädorf	76c2eb35fa	Add page title, add correct table cell titles	3 years ago
Oliver Günther	9a68bc6c06	Fix custom fields reordering	3 years ago
ulferts	1cca351d31	add separate menu for reminder mails	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
Oliver Günther	a1177700b6	Fix and test auth-source-sso case insensitivity	3 years ago
Oliver Günther	0b71e27de8	Don't set flash to nil, delete instead Otherwise, this shows an empty message	3 years ago
Oliver Günther	b8bb7546b0	[38706] Make login lookups in auth source sso case-insensitive https://community.openproject.org/work_packages/38706	3 years ago
Henriette Darge	2282f0ef2b	Show a custom sidebar on the notifications page. (Currently this is just the WP query sidebar as a placeholder. This will be replaced later.)	3 years ago
Oliver Günther	d504855091	Fix custom fields reordering	3 years ago
Henriette Darge	303dd6bf9f	Introduce mixin for global breadcrumb styles. Thus we can avoid the use of component styles in a global style sheet. Further the number of *breadcrumb.sass files was reduced from three to two (global and component)	3 years ago
Oliver Günther	f7c2644f53	Fix auth source login when user changes	3 years ago
Oliver Günther	b75fbcfc4e	Render error pages using our own templates (#9455 )	3 years ago
Oliver Günther	b7696a6c5c	[37553] Make user run through authentication stages after header SSO (#9458 ) https://community.openproject.org/wp/37553	3 years ago
Oliver Günther	e9d7c374cc	[37868] Whitelist for attachment mime types and extensions on upload (#9431 ) * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract	3 years ago
Oliver Günther	980447ab51	Prevent backtracking regexp in MessagesController (#9447 )	3 years ago
Oliver Günther	8365f575cb	Prevent backtracking regexp in MessagesController (#9447 )	3 years ago
Markus Kahl	31588fa25a	addressed review (including code climate) remarks	3 years ago
Markus Kahl	1a078ea667	/api/docs finished - made into separate, lazy loaded js/css bundle in angular - added setting allowing to disable API docs - added spec lint workflow - fixed styling (line-height) - renamed/restructured	3 years ago
ulferts	46152c7526	use service to have notification settings created The `Users::CreateService` correctly creates the notification settings. It is now used in the users controller	3 years ago
Markus Kahl	2ac1497c61	OpenAPI 3.0 spec, swagger UI right now the spec is generated from the existing api blueprint docs	3 years ago
Oliver Günther	9636a08988	[26688] In-app notifications (#9399 ) * Add bell icon to icon font * Add in app notification in top menu * Add fullscreen modal * Add notification modal and items * Style items * Toggle details of item * Mark all read * Add no results box * wip specification for event api * Add events table, query and index * Send out events from WP notification mailer job There we have the recipients present * Add cleanup job for older events with a setting * Hide bell notification when not logged * Add specs for events API index/show * Fix setting yml key * remove pry in event creation * Fix before hook in events API to after_validation * Fix polymorphic association raising exception for aggregated journals * Fix typo in read_ian * Fix yml entry for mentioned * Add read/unread post actions to event API and add specs * Wire up API to frontend * Fix order on events * Switch to unread in notification * Add event query * rename WPEventService * route wp mail sending over events * rename spec methods * author becomes watcher * correct message call signature * rename events to notifications * renname parameter to reflect notification nature * create author watcher for existing work packages * Merge unreadCount from store * Take a stab at polymorphic representers * Fix link generation in polymorphic resources For journals, no title is being generated however * Fix frontend model for context * Use timer for polling * add notification_setting data layer * Fix show resource spec * Fix duplicate class in notification bell item * Add minimal feature spec for notification * API for notification settings * Persist notifications * adapt work package notification creation to notification settings * extract notified_on_all * consolidate wp#recipients * concentrate wp notification in journal service * simplify methods * Remove unused patch endpoint * Add specs for rendering and parsing notification settings * Contract spec * Update service spec * adapt specs * Angular notifications frontend commit `e29dced646` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 17:34:50 2021 +0200 Create Akita store and query for notification settings commit `1a45c26c1a` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 11:09:25 2021 +0200 Remove tabs from notificaition settings page commit `0ea21e90c1` Author: Oliver Günther <mail@oliverguenther.de> Date: Sun Jun 20 21:55:48 2021 +0200 WIP in app settings * migrate notification data * add project visible filter to project query * Add inline-create and table display grouped by project * Add notifications under admin/users * Remove notifications partial * Rename notififcations store to user preferences store * Add setting for self_notified and hook that up to the backend * Add aria-label to table checkboxes * Restyle table and toolbar * replace remains of mail_notifications attribute * initialize notification settings for new user * adapt my_preferences references * reenable no self notified for documents * adapt specs * Avoid has_many :notifcation_settings Rails magically autosaves the user's preferences when the user gets saved, which somehow also tries to save the notfifications even when unchanged. This breaks some specs such as the avatar upload spec. As we can't update the assocation through rails anyway, just delegate to the user for reading instead. * Restore update method of notification settings * Restore update spec * fix spec syntax * lint scss * linting * Fix content_tag for bell icon * Add feature specs for notification settings * Disable ContentTag cop * use visible filter to get projects for notification The visible filter will reduce the project list down to the set of projects visible to the user provided as a parameter. This includes public projects. * test for actual mail sending * adapt me resource path this.apiV3Service.users.me changed its type in `0d6c0b6bc7` * Implement changed migration * Linting * Add actor to notification representer * Fix factory creating a duplicate WP journal * Add work packages loading and journal details to notification entry component * IAN basic facets, keep and expanded states. * Fix notification bell spec * Render body separately and add auto updating relative time * Add fixedTime title * Add actor to notification entry * Fix clicking links on work package and project * Tiny styling changes on entry row * Disable count in notification if larger than 99 (wont fit) * Introduce virtual scrolling to entry table * allow delaying & prevent mail sending if ain read Introduces a setting to delay mail sending after a journal aggregation time has expired. That way, users can confirm a notification in app. If they do before the delay expires, no mail is sent out additionally for that user. * consolidate notifications (in&out) into shared admin menu Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
ulferts	2a015eeac3	Feature/journal aggregation on write (#9396 ) * aggregate journals on write - simple implementation * remove references to aggregated journals on read * rewrite existing journals to be aggregated * remove aggregated journal reference * only delete predecessor if it can be aggregated * fix aggregation condition * adapt specs * remove aggregated journal functionality from production code The code is still necessary in a migration for the time being * adapt specs * use polymorphic belongs_to for journal data The association can then be employed for eager loading * eager load for activity rendering	3 years ago
Oliver Günther	fc090ac024	[37136] Disable delete button and check for deletion (#9338 ) https://community.openproject.org/wp/37136	3 years ago
Markus Kahl	2bf74725b2	fixed password confirmation during token reset (#9314 )	3 years ago
ulferts	6cda6ad4fd	enforces dependent project modules being active (#9311 ) Project modules, e.g. calendar can define dependencies, e.g. work packages. An error message is now displayed if a user enables a project module without the dependency being active in the project as well. Also fixes a serious bug in the Shared::ServiceContext module. Whenever a failing service result is returned, every change to the database is to be rolled back. This was not true when a model was provided since the changes where carried out within an inner transaction	3 years ago
Oliver Günther	9630b74524	Use format_time to format backup time (#9309 ) https://community.openproject.org/wp/37298	3 years ago
Oliver Günther	2cf8cd0d84	[37290] Use login service for logging in user (#9290 ) This correctly sets the last login date among other things https://community.openproject.org/wp/37290	4 years ago
Oliver Günther	32cbff3a78	[37197] Use setting names in error messages (#9286 ) This avoids wrongly translated content https://community.openproject.org/work_packages/37197	4 years ago
ulferts	d90d47e6b6	Feature/user invite from members for non admins (#9244 ) * users having manage_user can add users from member administration * linting and typo correction	4 years ago
Oliver Günther	375554277a	Add storage tab shown at the project settings (#9224 ) * Add storage tab shown at the project settings * Remove unused project settings fields	4 years ago
Markus Kahl	6156d4b837	fixed attachments deletion in backup_job, and more (#9221 )	4 years ago
Oliver Günther	2adce94853	Implement copy form in formly (#9218 ) * Implement copy form in formly * Add meta property handling to dynamic form * Remove copy projects controller, merge into projects * Fix copying of container attachments * Fix project copy path * Fix remainder of copy spec	4 years ago
Oliver Günther	71b330ea80	[37026] Add new project form with template selection (#9193 ) * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * Provide DynamicFieldsService in root so it can be used independently * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * _isResourceSchema based on parent?.location * Scope DynamicFieldsService to DynamicFormComponent * Added backend validation method to FormsService * Remove form from DynamicForm when not isStandaloneForm * Allow multiple form keys to validate * Remove form from non standalone forms * Remove duplicated button * Fix: dynamic form with ng-template not showing validations * DynamicForm programatic validation * Add new project component that posts to the copy form * Hide the submit button input * Unify ckeditor spacings with other dynamic-form elements * Basic fixes to invalid dynamic form fields * Load the templated projects with newly added action * Fix invalid styles for dynamic inputs * Updates to form styles, add op-form and op-fieldset * Soften inputs to 2px * Update input styles globally * Redirect to job status modal when response is job status * fix: load projects routes * Collapsible groups working * Fix: setTimeout datepicker to wait DOM ready * resourceId added to project settings form * fieldsLayoutConfig * formUrl & formHttpMethod @Inputs * Avoid replacing non ending '/form' strings * formUrl @Input * @Input model * identifier hidden * Populate the model * Add new project component * Tests removed * Show create message when creating new resource * Change location to rails * Add field_name helper for testing * Add form field helper classes and fix tests * Remove templated from copy for now * Fix more tests * Reset toolbar from dev * Skip identifier test * Set overflow to visible when expanded * Fix more tests * Rename data-field-name to data-qa-field-name * Review feedback * Uncollapse group fields when they contains errors * Fix text spec * Remove instantiate template service * Remove unnecessary ProjectController#create Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	4 years ago
Aleix Suau	f5d2a7467b	Feature/36382 multi selection for project custom fields base (#9164 ) * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * Provide DynamicFieldsService in root so it can be used independently * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * _isResourceSchema based on parent?.location * Scope DynamicFieldsService to DynamicFormComponent * Added backend validation method to FormsService * Remove form from DynamicForm when not isStandaloneForm * Allow multiple form keys to validate * Remove form from non standalone forms * Remove duplicated button * Fix: dynamic form with ng-template not showing validations * DynamicForm programatic validation * Hide the submit button input * Unify ckeditor spacings with other dynamic-form elements * Basic fixes to invalid dynamic form fields * Fix invalid styles for dynamic inputs * Updates to form styles, add op-form and op-fieldset * Soften inputs to 2px * Update input styles globally * Fix selectors in copy spec * Undo new project route Will be handled in separate PR * Add separate module for field controls Otherwise it will not be found in the FormattableEditField component * Fix paths now having a trailing slash due to ui-router * Remove new project lazy route * Add data attribute to locate fields * Fix spec by locating field with data * Accept that ng-select can be cut off No idea why that changed in this PR though? * Fix success message to match tests * Redirect settings to generic to match angular path * Fix other project spec * Remove fdescribe * Fix missing cv with magic wait time for now * Remove broken angular tests * Fix routing spec * Import field controls module in wp module * Wait after inserting link into ckeditor It looks like the formly field doesn't get the current ckeditor value before saving * Decouple settings fetching from dynamicform mode (Standalone/FormControl) Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	4 years ago
Oliver Günther	2896afe6c4	Assign project identifier in backend (#9196 ) * Introduce localizable slug url Stringex currently works only with english strings for wiki. But that default is actually confusing. Instead, add an explicit localizable helper that receives the locale and sets the stringex backend locale temporarily * Generate a default identifier in the backend * Remove JS based identifier updating * Remove identifier attribute * Add button to change identifier * Adapt tests to changed identifier * Linting * Fix invalid selector	4 years ago
Markus Kahl	8c8b8bbfa7	create backups via UI (#9136 ) * create backups via UI * Fix import of modal service * introduced backup token and addressed remaining comments * allow disabling permissions * improvements - only make user wait to use backup token in if really necessary - notify admins of new backup token - disable 'include attachments' option in UI if unavailable - documentation - misc * spec fixes * fixed feature spec * allow setting capybara host in every case * removed unused style file * addressed review feedback, added further feature specs * polish (code climate) * Avoid empty attachments * Don't raise filesize validation for internal exports Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	6dc662b1e4	[36243][30226] Different avatars for placeholders and groups (#9169 ) * Fix members autocompleter to allow hrefs * Add rendering of different avatar types * Remove unused code in backend avatar rendering * Add very basic test that the avatar gets customized per type * Allow avatar rendering in the CreateAutocompleter * Restructure avatars into BEM css * Remove avatar-classes in favor of passing size from backend * Remove to avoid confusion We use tracking with both href and , and was introduced to avoid a property called href to be overridden, but that was never a problem before. So from now we can safely use .href * Fix broken principal avatar in user activity * Ensure filters get updated even if the form is not reloaded There was a bug in conditionallyLoadForm that checked the property of link (always undefined) and would thus always reload a form. What we actually need is a form that gets reloaded only when the query link changes, but still update services from the updated query, such as filters * Adapt specs to changes classes * Rename op-principal-avatar to op-avatar	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958 ) * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Benjamin Bädorf	64143001fc	Set moment locale globally (#9040 ) * Set moment locale globally This sets the moment locale to the application locale globally, ensuring that moment uses the right translation strings wherever applicable. However, since we only work with languages (en), and not real locales (en-US), the first day of year calculation has to default to some option. This commit defaults to ISO 8601 for every language and locale. * Add setting to mark dayOfYear * Fix NaN check * Add spec for switching settings * Output uniq github specs Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	f50297227b	[34444] Projects copy APIv3 (#9149 ) * Create copy project endpoint * Add representers * Add _meta representer for copy module information * Add Meta payload representer * Extract parsing of copy attributes into service * Extract enqueue job for projects copy * Keep request object available in the bodied endpoint this allows us to access grape (e.g., for redirecting) * Add DelayedModify endpoint that redirects to job status * Use DelayedModify endpoint for copying projects * Add api paths for form/copy * Disable cache on ProjectCopyPayload * Add spec * Add resource spec * Extend schema for meta * Extend docs * Don't pass service result, but state as meta to forms * Use copy dependencies for naming copy options in API * Add description property for counting * Remove unused action attribute * Skip writable checks on meta property for payloads * Use prepend to allow create(...) usage with meta * Extend copy spec with custom fields usage * Add spec for copy flags * Add todos * Pass errors correctly to copy settings * Remove invalid parameters to copy that are now caught through project service * Remove duplicated validation * Linting * Make count a human readable, formattable description string * Make source count string readable * Provide the source project for generating the counts * Extract copying of attachments into sepearate dependent services This will allow the API to dynamically generate a copy association schema from each dependent service * Add spec for copy schema representer * Add payload representer spec * Also validate the model to pass the validations when copying * Make description optional and add note to schemas.apib * Add send_notifications to representer * Allow to configure sendNotifications * Allow bodied to receive a state process callback That allows us to manage the meta state on the API level, not on the service level * Make other services compatible with BaseCallable * Fix params passing from BaseCallable Wrapping a single hash into kwargs obviously loses their key indifference and we can't expect all services to use a single params object. Older services use kwargs * Copy wiki page with parent_id This will save some memory instead of memoizing the entire wiki page * Fix typo * Default to true for all copy associations That means if only a true value is passed, all other options will still be true * Do not try to copy attachments if the base dependency wasnt copied * Ensure null identifier gets rendered * Fix paths to the form and commit * Change redirect to an URL * Extend documentation on meta properties as table * Ensure we pass a default params if incoming params are nil Now that SetAttributes needs to splat params, they do no longer correctly get the no-param-default behavior of Ruby, so we need to explictly assign a default params hash * Fix expect for trailing path	4 years ago
Oliver Günther	2d22930bdb	[36746] Unset plain password accessor after saving (#9157 ) * [36746] Unset plain password accessor after saving Otherwise, this password remains and is validated again due to "user.register!" which then fails with an exception https://community.openproject.org/wp/36746 * Don't try to use user.password after saving it now gets cleared * Remove user.password usage in specs The user password attribute is an accessor that now gets deleted after saving so tests can no longer depend on it being present after created from a Factory * Also retain user password in mail handler	4 years ago
Oliver Günther	8f0dfb21d7	[36688] Set default locale before checking authorization (#9114 ) We do set the user's desired (from HTTP headers) or saved language preference, but that is called after `check_if_login_required` so in some cases we return before setting localization https://community.openproject.org/work_packages/36688	4 years ago
Oliver Günther	a023ccf372	[36517] Fix placeholder filter returning query object, not AR collection (#9071 ) We depend on the query for correct sorting by name. https://community.openproject.com/work_packages/36517	4 years ago
Oliver Günther	935cd02d33	[36294] Show authentication header only when any partial matches (#9044 ) * [36294] Show authentication header only when any partial matches * use collection_select for collection Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	0fa8b4a77b	Forward CSP extensions to login controller (#9047 ) * Forward CSP extensions to login controller * Extend spec for double auth code * stabilize spec On my machine, since I have an s3 bucket configured, the spec failed Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	b8ca382d34	Group API (#9034 ) * include group members into resource * GET /api/v3/groups endpoint * POST /api/v3/groups * PATCH /api/v3/groups/:id * DELETE /api/v3/groups/:id	4 years ago
ulferts	55acf25277	fix saving work package general settings	4 years ago
Oliver Günther	34f8e9dff8	Validate admin guard for all settings writers (#9012 ) * Validate admin guard for all settings writers * Add spec to test access to all links under admin * Fix broken specs * Keep only UpdateContract and add spec * Move admin settings under their own namespace for clarity Move all admin related settings under ::Admin::SettingsController * Fix more paths and views for settings Adds another spec to ensure all links in admin can be viewed by admin * Fix wrongly changed settings path for repositories page * Use plugin name for plugin settings	4 years ago
Oliver Günther	9acd19de46	Revert removal of groups XML responses (#9024 )	4 years ago

1 2 3 4 5 ...

3856 Commits (4ba1a0f340f33e43ff07a2dda245a62e59109a16)