openproject

Commit Graph

Author	SHA1	Message	Date
Wieland Lindenthal	e72d940b5b	Feature/37108 improve design of GitHub tab (#9329 ) * Rename Git button to 'Git snippets' * Change font for Github tab header * Improve design of pr status badges * Reorganize the design of PR headers * Improve design of PR checks * Improve design of git snippets menu * Remove WP description from commit message and command * Fix frontend specs for github integration * Adding dots to the end of phrases. * Github Integration: reduce dom depth. remove last border under PR * Add target blank to PR details link & other fixes * Fix work_package_github_tab_spec.rb * Remove fdescribe * Improve layout of Github pull requests tab header * Add title to Github check icon * Refactor classnames for github pull requests This introduces `op-pull-request` and `op-pr-check` as BEM blocks, both in their own sass files, but the files still scoped to the pull request component. * Fix frontend spec. Added karma Chrome debug config. * Fix frontend specs after refactoring styles Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	4 years ago
Oliver Günther	5956ede030	[37107] render tabs in component (#9236 ) * Render work package tabs in one component * Move standard tabs into tab service * Move tab-count styles mostly into its own component style * Fix frontend specs * Remove unused texts * Fix routing to split view from button * Fix context menu not opening the tabbed view * Fix watcher tab counter not receiving an rxjs subscription * Fix selector * Fix clicking on relation link to fullscreen * Make WP tabs an instance of scrollable-tabs * Convert the tabs from .tabrow to its own BEM block * Refactor other usages of tabrow into op-tab-row * Fix frontend specs * Make wp modal tabs use scrollable-tabs * Fix disabled tab selectors * Restore scrollability of tabs * Fix import and change detection of graph modal * Fix selector in wp relations spec * Rename tab-count to match component style * Remove narrow style * Fix bem modifier style * Fix styles of scrollable tabs * Fix tab for time entry autocompleter	4 years ago
Philipp Tessenow	a46de71009	[#36204 ] Add new GitHub plugin tab enabling users to copy git actions (#9027 ) * Let GitHub integration show changes in a separate tab * added new github integration icons to icon font * add tab content: working tab-header and copy-menu * modernise github_integrations ruby code * refactored some code to be more modern ruby (if wrote most of it 7 years ago and couldn't look at some parts without squinting too much) * make some intended-to-be-private module methods actually private * fixed all rubocop errors in the /modules/github_integration * re-organized tests a little * gave our rubocop.yml some RSpec-related defaults -- happy to discuss these, but I think we can live with these as a good starting point 👆 all without actually (intentionally) changing the behaviour * removed dead angular template code * codeclimate found more things than rubocop :) * removed create-pr-button since we decided against implementing that feature * added missing translations * properly cache the github related part of the wp api * lower case pull requests in translations * fix specs	4 years ago

Author

SHA1

Message

Date

Wieland Lindenthal

e72d940b5b

Feature/37108 improve design of GitHub tab (#9329 )

* Rename Git button to 'Git snippets'

* Change font for Github tab header

* Improve design of pr status badges

* Reorganize the design of PR headers

* Improve design of PR checks

* Improve design of git snippets menu

* Remove WP description from commit message and command

* Fix frontend specs for github integration

* Adding dots to the end of phrases.

* Github Integration: reduce dom depth. remove last border under PR

* Add target blank to PR details link & other fixes

* Fix work_package_github_tab_spec.rb

* Remove fdescribe

* Improve layout of Github pull requests tab header

* Add title to Github check icon

* Refactor classnames for github pull requests

This introduces `op-pull-request` and `op-pr-check` as BEM blocks, both in their own sass files, but the files still scoped to the pull request component.

* Fix frontend spec. Added karma Chrome debug config.

* Fix frontend specs after refactoring styles

Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>

4 years ago

Oliver Günther

5956ede030

[37107] render tabs in component (#9236 )

* Render work package tabs in one component

* Move standard tabs into tab service

* Move tab-count styles mostly into its own component style

* Fix frontend specs

* Remove unused texts

* Fix routing to split view from button

* Fix context menu not opening the tabbed view

* Fix watcher tab counter not receiving an rxjs subscription

* Fix selector

* Fix clicking on relation link to fullscreen

* Make WP tabs an instance of scrollable-tabs

* Convert the tabs from .tabrow to its own BEM block

* Refactor other usages of tabrow into op-tab-row

* Fix frontend specs

* Make wp modal tabs use scrollable-tabs

* Fix disabled tab selectors

* Restore scrollability of tabs

* Fix import and change detection of graph modal

* Fix selector in wp relations spec

* Rename tab-count to match component style

* Remove narrow style

* Fix bem modifier style

* Fix styles of scrollable tabs

* Fix tab for time entry autocompleter

4 years ago

Philipp Tessenow

a46de71009

[#36204 ] Add new GitHub plugin tab enabling users to copy git actions (#9027 )

* Let GitHub integration show changes in a separate tab

* added new github integration icons to icon font
* add tab content:  working tab-header and copy-menu

* modernise github_integrations ruby code

* refactored some code to be more modern ruby (if wrote most of it 7
  years ago and couldn't look at some parts without squinting too much)
* make some intended-to-be-private module methods actually private
* fixed all rubocop errors in the /modules/github_integration
* re-organized tests a little
* gave our rubocop.yml some RSpec-related defaults -- happy to discuss
  these, but I think we can live with these as a good starting point

👆 all without actually (intentionally) changing the behaviour

* removed dead angular template code

* codeclimate found more things than rubocop :)

* removed create-pr-button since we decided against implementing that feature

* added missing translations

* properly cache the github related part of the wp api

* lower case pull requests in translations

* fix specs

4 years ago

3 Commits (4be8c1cbd7f315d631414586c407992178515fd4)