openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
Oliver Günther	e9d7c374cc	[37868] Whitelist for attachment mime types and extensions on upload (#9431 ) * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract	3 years ago
Oliver Günther	2d22930bdb	[36746] Unset plain password accessor after saving (#9157 ) * [36746] Unset plain password accessor after saving Otherwise, this password remains and is validated again due to "user.register!" which then fails with an exception https://community.openproject.org/wp/36746 * Don't try to use user.password after saving it now gets cleared * Remove user.password usage in specs The user password attribute is an accessor that now gets deleted after saving so tests can no longer depend on it being present after created from a Factory * Also retain user password in mail handler	4 years ago
Benjamin Bädorf	2667cd1581	Refactor/app header (#9110 ) * [35527] Add quick add button menu in top menu * Add quick menu item to top menu * Refactor top_menu.sass to follow BEM * Only render project-based path if persisted * Render project types when in project context * Add headline and determine if any types are visible * Hide quick add menu for unauthorized users * Fix login menu dropdown by adding class * Add schematic for correctly generating components * Add augment service for triggering invite user modal * Fix allowed_to? check in menu * Add spec * Highlight types and show all * Fix help menu overridden * Extend spec * Add parent_id to project in dropdown and expand advanced settings * Reload the page if the modal returned any data * Fix invalid url allowed check if there is no URL to check * Basic BEM changes * Remove old classes * Update more classes * Update togling logic * Fixed menu opening and some styles * Added op-menu * Fix some help menu styles * Add op-menu to help menug * Add avatar border * Fix auth_provider_spec * Fix zen mode * Fix static link help menu * Fixed top menu specs * Fix self registration specs * Fix logout spec * Fix bim revit navigation spec * Fixed menu permissions spec * Fix homescreen onboarding tour spec * Fix top menu item spec * Remove unused file * Fix a lot of mobile styles * Fix more mobile styles * Fixed build * Move quick add menu to right hand side * Improve quick-add-button styles, fix main-menu-toggle close icon * Remove add new project spec * Fix spec * Update project dropdown styles * Fix click handler for chrome mobile, update some styles Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	0d71772c37	User SqlBypass sessions to avoid ActiveRecord for session storage (#9142 ) * Use SqlBypass sessions to avoid ActiveRecord for session storage * Set default host if Capybara.app_host does not exist	4 years ago
Oliver Günther	34f8e9dff8	Validate admin guard for all settings writers (#9012 ) * Validate admin guard for all settings writers * Add spec to test access to all links under admin * Fix broken specs * Keep only UpdateContract and add spec * Move admin settings under their own namespace for clarity Move all admin related settings under ::Admin::SettingsController * Fix more paths and views for settings Adds another spec to ensure all links in admin can be viewed by admin * Fix wrongly changed settings path for repositories page * Use plugin name for plugin settings	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943 )	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code Found via `codespell v2.1.dev0`	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Benjamin Bädorf	5f45ee07ab	Move development docker-compose file to the main directory (#8798 ) * Move development docker-compose file to the main directory This requires us to move some other files around, like the pullpreview and example docker-compose file for production setups. This commit also does some housekeeping, like removing some old files and deduping configuration. * Updated to selenium grid * Fix in-Docker Selenium tests The Selenium tests now run inside a Docker Chrome Container. Backwards compatability with non-docker setups is not guaranteed, though it should not be hard to implement with a couple of small fixes. * Updated docker development documentation * Improved test timings, changed the documentation * Updated docker testing again * Run npm in the frontend directory * Really run npm in the frontend directory * Also run npm in frontend when setting up travis cache * Change directory for one command only * Change default test driver name * CI test change fixes * Fixed syntax error * Added dev check * Trying to fix firefox resizing * Trying to get tests running * Stop resizing firefox * Fixed apple icon spec * fix host in url helpers for omniauth spec * Fix omniauth specs * Fix docs * Small fixes to docker tests * Added package.json back in * Change env variables Co-authored-by: Markus Kahl <machisuji@gmail.com>	4 years ago
Oliver Günther	6881f3d347	[33696] Retain autologin cookied request in session https://community.openproject.com/wp/33696	4 years ago
Oliver Günther	2e2f520130	Avoid updating the just created user to retain id information We need to track whether the user was just created to show a different message. For this, avoid any calls that save the user _after_ RegisterUserService.	4 years ago
Oliver Günther	841e1149c2	Don't show an error when the user just registered In case the user still needs to activate e.g., via mail, it should not be shown an error message, but instead the success message from the registration service	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Oliver Günther	93577fb31d	[32748] Remove whitespace from login and mail https://community.openproject.com/wp/32748	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Markus Kahl	cddd45c8f5	I'm sick of looking up magic numbers	5 years ago
Oliver Günther	7a09d8fcdd	delay all jobs	5 years ago
ulferts	1c81ff519c	adapt feature spec to altered accept language precedence	5 years ago
Oliver Günther	f5db1e39bd	[30591] Use username for login form https://community.openproject.com/wp/30591	5 years ago
Henriette Dinger	32a8592284	Fix spec paths && render sub menu nodes only when not added to list of hidden menu nodes	5 years ago
Henriette Dinger	95c34a3fdb	Add missing required classes, correct rendering of „save as“ form on reporting and fix broken test	6 years ago
Oliver Günther	451331a910	Invalidate session,s extract passwords flow into services	6 years ago
Henriette Dinger	0035fa67e7	Add text highlights, make skip button less prominent, disable scroll behavior && fix some tests	6 years ago
Jens Ulferts	5bf74d3fcc	replace user expired password cuke	6 years ago
Jens Ulferts	3e6c025862	replace autologin cuke	6 years ago
Jens Ulferts	a9ca95077e	replace logout cuke	6 years ago
Jens Ulferts	b1455a0cb9	replace login back_url cukes	6 years ago
Jens Ulferts	d85b1dfa88	replace lock user cuke	6 years ago
Jens Ulferts	c358dffdc0	replace password lost cuke	6 years ago
Jens Ulferts	92fbd0bebe	linting	6 years ago
Jens Ulferts	319f33e924	remove textile	6 years ago
Jens Ulferts	79f7d4caec	replace FactoryGirl by FactoryBot added by merging	7 years ago
Oliver Günther	3a99372c9b	Fix other localizations [ci skip]	7 years ago
Oliver Günther	44b93ddf04	Show consent in account/register form	7 years ago
Oliver Günther	aea0e41001	Add check box to update consent time to current time	7 years ago
Oliver Günther	50a1bada27	Add warning when user declines consent	7 years ago
Oliver Günther	438b5f81ad	Add spec	7 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	26dff6132e	Remove default route (#6137 ) * Remove default route * Fix and clean legacy specs * Fix specs * Fix missing ID in request parameters in view specs https://stackoverflow.com/a/21789313 * Fix more invalid routes in specs * Pass parameter to omniauth spec * Add required ID parameter to types controller * Fix invalid omniauth URL * Fix project_id params in repository controller spec * Fix missing project id in projects controller spec * Fix missing params and failure url for omniauth * Fix invalid route name * Temporarily skip broken specs on dev [ci skip]	7 years ago
Markus Kahl	662ba4a4e3	removed obsolete comment	7 years ago
Markus Kahl	622d51487f	save back_url in session	7 years ago
Markus Kahl	5667548b3e	consider back_url	7 years ago
Markus Kahl	4e4ed9bbe8	verify authenticity of stage complete calls (#6014 ) * verify authenticity of stage complete calls * fixed path helper name [ci skip]	7 years ago
Markus Kahl	90558ca8f2	Authentication stages mechanism (#5998 ) * authentication stages mechanism * integration test for authentication stages * code climate * fixed omni auth and after activation * clean up session after registration finished * allow passing blocks to return stage paths * don't instance exec in controller * fixed registration without stages	7 years ago
Oliver Günther	4c210d786a	Fix different notices on lost password page (#5995 ) [ci skip]	7 years ago
Henriette Dinger	c5f545bfd0	Add account/register page again && fix tests	8 years ago
Henriette Dinger	c0837bc7c6	Fix broken specs [WIP]	8 years ago

1 2

68 Commits (4ef23efb9056ddfdadfa5c8042001f03d7caa039)