1382 Commits (4feb8f475411cee5f77e1aa78340a40e8af8df62)

Author	SHA1	Message	Date
Solotchi Veaceslav	7d8aaa9c31	Fixes related to code review	9 years ago
Oliver Günther	0284d11f21	Corrections from review ... - destroy_info: remove superfluous JS confirm dialog. - destroy_info: change notification type into severe warning - destroy_info: Remove delete button highlight and back button for consistency with styleguide. TODO: think of other ways to guide the user back (also applies to project destroy_info) - remove typo in 'repositories.errors.unauthorized' - empty repository: Render warning view (repositories/empty) instead of 500 exception notification. - revert reformat on code changed in rails4 branch. - create repository: Show managed flash part only when the repository is managed - delete repository: Show error when configuration no longer allows manageable (other ways tbd.) - repository controller: JS redirect wrapped inside format.js - repository settings: Select hidden when instance exists Specs: - Add routing spec for `get #destroy_info`	9 years ago
Oliver Günther	fb654d0afa	Correct for review ... - Switch to styled_form and remove highlight from button - Fix permanently typo	9 years ago
Oliver Günther	9d88ed6027	Remove remark regarding subversion.	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter ... This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring ... - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	1618c80924	Use severe notification for project destroy dialog ... The current project `destroy_info` style is inconsistent with the styleguide, as it uses a `notification` (used for one-line notifications only) instead of a warning notification box. This commit switches this dialog to the notification-box with warning parameter and suggests to additionaly use the new `-severe` switch for warnings due the potential ramifications this action has. Using `-severe` also makes it compatible with the upcoming repository destroy_info dialog, which also uses this dialog when local data is to be deleted outside OpenProject.	9 years ago
Oliver Günther	933c553ba9	Improve settings for mail, sys web services to improve comprehension. ... This commit provides: - Improved labels for mail_handler and sys api to spell out `WS`. - Added instruction below the both checkboxes with a brief introduction on what this setting actually does.	9 years ago
Jonas Heinrich	d5299c3ec4	Fixes two incorrect english strings	9 years ago
Jonas Heinrich	ede6172b6d	Removes unused string	9 years ago
Jonas Heinrich	2779d7a2a0	Removes unused string	9 years ago
Jonas Heinrich	2dc75bc12f	Adds a dot at the end of the error message	9 years ago
Jonas Heinrich	e0b8364a22	Fixes an english error message	9 years ago
Solotchi Veaceslav	7fd856808e	Create custom tooltip that support html	9 years ago
Jonas Heinrich	969336b0c2	Fixes two locales	9 years ago
Jonas Heinrich	3be866f846	Fixes locale about parent	9 years ago
Azure7111	af85e8d603	Fix settings label	9 years ago
Jens Ulferts	008040fbd4	changing I18n for error on deleting wp status	9 years ago
Alexander Bach	a084fb06af	Explain mail notification delay	9 years ago
Jan Sandbrink	17940bf02c	change validation of WP children ... - do not add error on a symbol called :#123 (123 is the childrens ID) - this is against the semantics of ActiveRecord::Errors - creating symbols in a loop used to be a bad idea (might be better today) - it breaks error messages in the APIv3 (which is due to APIv3 working beyond the borders of AR errors, not the best of ideas...) - use :base instead, the place for unlocatable errors - include the fact that #123 refers to a child element in the error message Basically I feel that this makes the children validation cleaner and better. But somehow I fear, that there is some code out there that depends on the fact that error keys like :#123 existed...	9 years ago
Jan Sandbrink	bd484a9fbe	include punctuation in error locales	9 years ago
Jens Ulferts	301ea48d63	add missing i18n key ... It used to work because Rails falls back to "timelines" by itself. But this prvented I18n.	9 years ago
Alexander Bach	18ebdc9a9e	Some settings cleanup	9 years ago
Alexander Bach	984f3dcc4a	Add setting for journal aggregation time	9 years ago
Markus Kahl	d1992740d9	improved logout warning with login link	9 years ago
Markus Kahl	8d6dd69f38	new logout warning which is easy to see in the background	9 years ago
Jens Ulferts	9b92187bae	use interpolation in I18n ... Relying on the position of some variable by appending in the code is bad practice	9 years ago
Jonas Heinrich	9db7d41311	Makes the notification to an error	9 years ago
Jonas Heinrich	8f7907b6f7	Catches error while sending notifications	9 years ago
Oliver Günther	2f88f777d4	Consistent costs case ... This changes english locale to be consistent with sentence case. Moreover, this fixes the "Cost Types" admin entry. Relevent work package: https://community.openproject.org/work_packages/20621	10 years ago
Oliver Günther	20d54c7010	Consistent reporting case ... This changes english locale to be consistent with sentence case. Especially, this fixes the "Cost Reports" menu entries. Relevent work package: https://community.openproject.org/work_packages/20621	10 years ago
Jan Sandbrink	430c7f7f46	remove redundant localization ... [ci skip]	10 years ago
Jan Sandbrink	36468cf8c4	add item to reach time entries to project menu	10 years ago
Oliver Günther	5ada719136	Consolidate Module menu in header navigation This effectively changes the following menus: ... **Top Menu** - Removed Administration item - Added Item 'Work Packages' -> /work_packages - Added Item 'News' -> /news - Added Item 'Time Sheet' -> /time_entries (if user has a project with view time log permission) **My Menu** - Added Administration item as first position With work packages, time entries, news now residing in the top menu, these buttons are superfluous in the projects overview and are also removed. Relevant work package: https://community.openproject.org/work_packages/20512	10 years ago
Alex Coles	0a0f6c7b6c	Interpolate attribute in confirmation error string ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	7d443154b3	parse attachment metadata using a representer ... - adding general error handling for parse errors - changing the default error message for parse errors, which was very form specific before	10 years ago
Jan Sandbrink	45eae8cf5c	sorting some localization properties	10 years ago
Jan Sandbrink	50f6ecdecd	accept new request format for add watcher ... also adapt the angular frontend to speak the new format	10 years ago
Jan Sandbrink	9a9d6aca2c	ensure correct file size errors are displayed	10 years ago
Jan Sandbrink	9cd03b0586	correct (but ugly) upload error handling	10 years ago
Markus Kahl	70fe41cb53	use separate error code when unauthenticated ... also distinct error messages for missing or wrong credentials	10 years ago
Florian Kraft	dbda631795	add missing translations ... not everyone uses the my_project_page plugin Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Florian Kraft	9f34cf0ede	use toolbar styling for the taskboard overview ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Jan Sandbrink	dea02be5b8	return proper error when adding invalid relations ... Error could probably be improved, but so can the whole relations endpoint... I'd consider this a strong case of broken window syndrome and will fix it as soon as we fix the whole relations endpoint...	10 years ago
Jan Sandbrink	a250ede762	return proper error when adding invalid relations ... Error could probably be improved, but so can the whole relations endpoint... I'd consider this a strong case of broken window syndrome and will fix it as soon as we fix the whole relations endpoint...	10 years ago
Jan Sandbrink	b0ba1764f3	improve context-related error messages	10 years ago
Jonas Heinrich	57b4319397	Makes the notification to an error	10 years ago
Jan Sandbrink	e7651fcdad	improve error message for :inclusion ... currently used for: - custom value range checks - type range checks - version range checks It never sounds understandable before: "Version is not included in the list" 1. which list? 2. why is the version field not included there? I hope the new message makes more sense: "Version is not set to one of the allowed values" 1. aha! the allowed values it is 2. aha! it is fine to set the version, but its value is wrong	10 years ago