openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	f50297227b	[34444] Projects copy APIv3 (#9149 ) * Create copy project endpoint * Add representers * Add _meta representer for copy module information * Add Meta payload representer * Extract parsing of copy attributes into service * Extract enqueue job for projects copy * Keep request object available in the bodied endpoint this allows us to access grape (e.g., for redirecting) * Add DelayedModify endpoint that redirects to job status * Use DelayedModify endpoint for copying projects * Add api paths for form/copy * Disable cache on ProjectCopyPayload * Add spec * Add resource spec * Extend schema for meta * Extend docs * Don't pass service result, but state as meta to forms * Use copy dependencies for naming copy options in API * Add description property for counting * Remove unused action attribute * Skip writable checks on meta property for payloads * Use prepend to allow create(...) usage with meta * Extend copy spec with custom fields usage * Add spec for copy flags * Add todos * Pass errors correctly to copy settings * Remove invalid parameters to copy that are now caught through project service * Remove duplicated validation * Linting * Make count a human readable, formattable description string * Make source count string readable * Provide the source project for generating the counts * Extract copying of attachments into sepearate dependent services This will allow the API to dynamically generate a copy association schema from each dependent service * Add spec for copy schema representer * Add payload representer spec * Also validate the model to pass the validations when copying * Make description optional and add note to schemas.apib * Add send_notifications to representer * Allow to configure sendNotifications * Allow bodied to receive a state process callback That allows us to manage the meta state on the API level, not on the service level * Make other services compatible with BaseCallable * Fix params passing from BaseCallable Wrapping a single hash into kwargs obviously loses their key indifference and we can't expect all services to use a single params object. Older services use kwargs * Copy wiki page with parent_id This will save some memory instead of memoizing the entire wiki page * Fix typo * Default to true for all copy associations That means if only a true value is passed, all other options will still be true * Do not try to copy attachments if the base dependency wasnt copied * Ensure null identifier gets rendered * Fix paths to the form and commit * Change redirect to an URL * Extend documentation on meta properties as table * Ensure we pass a default params if incoming params are nil Now that SetAttributes needs to splat params, they do no longer correctly get the no-param-default behavior of Ruby, so we need to explictly assign a default params hash * Fix expect for trailing path	4 years ago
ulferts	7ecf08e005	rework changed_by_system (#9043 ) Before, it was implemented by passing the changed attribut keys over to the contract to whitelist them. This lead to: * The contract interface becoming bloated * Having to rely on the knowledge of the developer not to falsely whitelist an attribute. The developer would also have to make sure to not perform a mass assignment after the attribute has been whitelisted The new approach it to integrate the behaviour into the model which is first altered in the service before it is scrutinized in the contract. The information about the changed attributes is now stored inside the model which removes the necessity to flag the whitelisted attribute separately. Additionally, the exact change is tracked. So if an attribute is set to one value inside a whitelisted block there is no risk in later on performing a mass assignment. This comes at the cost of extending the models which is weird also it is build into the default SetAttributesService so child classes do not have to worry. One might include the module into every AR model but currently we only need it for a very specific use case.	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	a112999dcc	fix ruby 2.7 deprecations (#8867 )	4 years ago
Oliver Günther	6526ca2814	Map filters from api and queries in one filter mapper object This allows mapping the parent filter and other foreign key references that should be updated during copy.	4 years ago
Oliver Günther	b7f93b96cf	Better error handling if project copy dependencies fails The project copying can succeed but with errors of some dependencies, this commit modifies the modal to show these errors instead of automatically redirecting.	4 years ago
Oliver Günther	2523040abf	Improve lookup of versions and work package user assignments	4 years ago
Oliver Günther	70cf07cc20	Disable notifications for user in the bsae copy service	4 years ago
Oliver Günther	2271b79fc6	Correctly base all services on base_contracted with a model BaseContracted service uses a `model` reference that it doesn't define itself, neither does some of the dependent services. To avoid this, make sure the BaseContracted gets an optional model attribute that can be set.	4 years ago
Oliver Günther	530e9174b0	Add test for base callable service	4 years ago
Oliver Günther	01954c26bc	Refactor copy services to use shared state	4 years ago
Oliver Günther	605f6b8355	Refactor copy project into service	4 years ago
Oliver Günther	af8b76b544	Pass contract_options to SetAttributesService This is needed for the contract to pick up an extra attribute passed through its options	4 years ago
Oliver Günther	d1d09aebfc	Don't remove work package unless contract validated Introduce new `after_validate` callback to ensure we can do changes after the contract was validated.	5 years ago
ulferts	a895767619	have a delete service for attachments	5 years ago
ulferts	0cda1869a8	employ advisory lock for all update services	5 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	473f6c77ba	Use create service	5 years ago
Henriette Dinger	69debf8c0c	Add Bcf Topic DeleteService and DeleteEndpoint	5 years ago
ulferts	bbd058d536	extend interface on all base services	5 years ago
ulferts	4eab6effe1	merge changed_by_system into contract options	5 years ago
ulferts	3dabb46dd9	allow copying projects without parent project reference	5 years ago
ulferts	05ac3af1ee	add projects delete end point to api	5 years ago
ulferts	57f7da4f39	reuse project services in controller	5 years ago
ulferts	5b758c1419	differentiate between user and system set attributes	6 years ago
ulferts	a06120db10	introduce role services and contracts and move parts of global_roles into core	6 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308 ) * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago

31 Commits (510a83d66f7b2bf0e023431a31bfd97086492f98)