openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	511ab615fc	Fix/decimal separator in overwritten costs (#8874 ) * fix decimal separator parsing in overwritten costs on new budget items. They are now applied same as for updating existing budget items. * reduce code duplication	4 years ago
ulferts	e58df37e29	Fix/copy budgets (#8856 ) * Fix broken call to #super in Budget#copy_from The #copy_from method in Budget appears to assume that superclasses will have the same method available to them as called on the new Budget object to which the copy is going. This is not the case. Resolve the issue by assigning duplicated attributes from the source object directly to self.attributes prior to copying the actual budget items. Tested in Chef/Vagrant test environment. Deployed to SemperVictus pre-production OP instance successfully. * Resolve budget child item copy confusion The #copy_from method does not account for child models duplicated from another Budget holding a unique constraint validation on the :budget_id attribute. The Budget itself also appears to inherit the source Budget's ID, creating additional problems. Address by unfolding the sub-object copy procedure and clean up the relevant attributes on #dup ensuring the appropriate relations are created when the object is assigned (after the #dup block). Tested in Chef/Vagrant workflow. * Rewrite for readability DRY the code, leaving it as an instance method for the time being. TODO for upstream: Convert to class method and update controller in the MVC (per GH comment). Write tests/spec and verify results of the original fix and final revision for release branches. * use whitelist approach for copying budgets * extract method Co-authored-by: RageLtMan <rageltman [at] sempervictus>	4 years ago
ulferts	9b8a690cf5	Fix/non integer material budget items (#8646 ) * fix label for budget heading * remove outdated todo * fix fractional number below 1 for material units * extract method to avoid duplicate code * fix some i18n key structure for costs	4 years ago
Oliver Günther	47a07210d5	[33383] Treat number fields as text fields to allow localized input The budget parsing use localized numbers to compute the budget costs for the given units. For comma-delimited locales like German, this will break the computation for any decimal value, as the frontend number always sends dot-delimited values in Chrome due to Bug OP#32232 This PR treats the number fields like text fields with a hint on how to enter the correct value. This matches the "rate" field that does this already and should be the expected behavior, so users can use their language for numbers. https://community.openproject.com/wp/33383	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557 ) * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
ulferts	379f0ed72c	remove currency separator duplicity I18n already defines keys for number delimitors and separators. They are also to be used for currencies.	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	8e32895ce3	Remove legacy frontend	5 years ago
Oliver Günther	f86abae9eb	Enforce Arel.sql for string order, pluck	6 years ago
Oliver Günther	5b49b33b21	Prepare for core integration	6 years ago
Markus Kahl	8161bb9628	fixed remaining i18n issues	9 years ago
Markus Kahl	852371e3f2	don't use Redmine::I18n's l for translations	9 years ago
Alex Coles	0d5a0cdaad	Migrate association conditions to use lambda/block Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	126b0ce0f4	Prefer #map over #collect Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ccb4268793	Normalise syntax with Rubocop Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	16fb352d8d	Use 1.9+ Hash syntax Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	5f09485357	Remove all usages of unloadable Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Sebastian Schuster	e395a01c4c	Adapted to renaming of core method	11 years ago
Sebastian Schuster	268567297c	Added copyright notices	11 years ago
Christian Rijke	586afeee5a	Set activity/event options for acts_as_journalized.	11 years ago
Sebastian Schuster	9c05691f75	Defined default order for labor and material budget items being ordered by id ensuring the order of existing items always stays the same also under postgresql which seems to order by updated_on if nothing is specified	12 years ago
Sebastian Schuster	6fbb2dfd2f	Implemented new way of saving without validation	12 years ago
Sebastian Schuster	5017c29f88	Simplified copy_from	12 years ago
Sebastian Schuster	2a83bf4434	Adapted the copying of values from other cost objects to not work around the mass assignment protection for all assignments but just for copying	12 years ago
Jens Ulferts	84e89f0b90	completely removes custom allowance evaluation (granular_for, inheritance) This should make the code easier to understand and more performant. As part of this commit a lot of falsely presented information is no longer shown to users who have limited rights. E.g. a user having only the view_own_hourly rates sees only the planned and actual labor costs for himself when viewing a budget.	12 years ago
Jens Ulferts	72b7922e72	adding missing validations to labor budget items, specs for the model	13 years ago
Martin Linkhorst	928720f6b6	more protection against mass assignment	13 years ago
jwollert	7bed02534a	fixes updating labor and material item updates so we cannot break out of our projects' bounds	13 years ago
Jens Ulferts	5027a42a8d	acts_as_journalized for variable_cost_object * removed from cost_object as acts_as_journalized does not play well with subclasses * create migration for recreating initial journals	13 years ago
Jens Ulferts	23a53e0adb	bugfix: explicitly casting to_d to avoid conflicts when using + on string and bigdecimal	14 years ago
Philipp Tessenow	943c1efdda	moved redmine_costs back to root folder	14 years ago
Philipp Tessenow	cbdda0bcb0	moved redmine_costs into a subfolder	14 years ago
Philipp Tessenow	886418492f	removed the newly introduced plugin-folder	14 years ago
Jens Ulferts	5305ed536d	addresses #3720 : implicit BigDecimal.to_s conversion removed	14 years ago
Philipp Tessenow	9504318729	move plugin into a subfolder. this enables us to have multiple plugins wihtin a repo and makes deployment easier	14 years ago
rkh	2bf8de9052	updating part 2, there we go git-svn-id: https://dev.finn.de/svn/cockpit/branches/reporting_merge@1024 7926756e-e54e-46e6-9721-ed318f58905e	15 years ago
rkh	5fe8faae2f	updating part 1, stay tuned git-svn-id: https://dev.finn.de/svn/cockpit/branches/reporting_merge@1023 7926756e-e54e-46e6-9721-ed318f58905e	15 years ago
hjust	76d2b35dd4	Fixed: 500 during deletion of s labor_budget_item git-svn-id: https://dev.finn.de/svn/cockpit/trunk@1020 7926756e-e54e-46e6-9721-ed318f58905e	15 years ago
rkh	35b8c93e48	remove variable_cost_object.rb git-svn-id: https://dev.finn.de/svn/cockpit/trunk@958 7926756e-e54e-46e6-9721-ed318f58905e	15 years ago
rkh	824742112f	copy to trunk git-svn-id: https://dev.finn.de/svn/cockpit/trunk@936 7926756e-e54e-46e6-9721-ed318f58905e	15 years ago
hjust	a01fd84520	Replace floating point arithmetic with BigDecimals. git-svn-id: https://dev.finn.de/svn/cockpit/trunk@705 7926756e-e54e-46e6-9721-ed318f58905e	15 years ago
hjust	07c5b43a48	Normalized all permissions to the new permission model. git-svn-id: https://dev.finn.de/svn/cockpit/trunk@440 7926756e-e54e-46e6-9721-ed318f58905e	15 years ago
hjust	79640099f2	fixed display of cost objects if labor_costs or material costs are 0. git-svn-id: https://dev.finn.de/svn/cockpit/trunk@439 7926756e-e54e-46e6-9721-ed318f58905e	15 years ago
hjust	83d19e0c0e	Now check for the correct permission. git-svn-id: https://dev.finn.de/svn/cockpit/trunk@430 7926756e-e54e-46e6-9721-ed318f58905e	15 years ago
hjust	f560044401	Fixed calculation of costs after removal of denormalized values git-svn-id: https://dev.finn.de/svn/cockpit/trunk@391 7926756e-e54e-46e6-9721-ed318f58905e	15 years ago
hjust	ea33da9a5e	Refactored many names: Deliverable --> CostObject CostBasedDeliverable --> VariableCostObject FixedDeliverable --> FixedCostObject DeliverableCost --> MaterialBudgetItem DeliverableHour --> LaborBudgetItem This closes #10501 git-svn-id: https://dev.finn.de/svn/cockpit/trunk@135 7926756e-e54e-46e6-9721-ed318f58905e	15 years ago

5 Commits (51a40c97eb0315fd2a5dd86dfd7333f9d8d15d92)