openproject

Commit Graph

Author	SHA1	Message	Date
Benjamin Bädorf	e848d44dea	Fix/update wysiwyg styles (#8844 ) This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances. * Initial class definitions * Added more classes * Added Table of Contents basics * CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote * CKEditorInspector removed * op css class for headings * op css class for paragraphs * op css class for code/code block * adapt specs to altered markdown/html generation * adapt grid/budget representers to altered signature * op css class for lists * op css class for toc * op css class for links * Start working on typography css * op css class for tables * Fixing more typography, trying out larger headers * Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros * adapt specs to altered link classes * op css class for images * apply user content container class throughout application * CSS alignment custom classes applied to table * op css class for task list checkbox * Added task checkbox class * amend list checkbox class in backend * op css class for table thead element * adapt specs on image html generation * Updated table and typography styles * Update typography and figure styles * Figure overflow handling * Table alignment styles + ckEditor styles removed * rename wiki-anchor to op-uc-link_permalink * wrap table in div as well as figure * Updated code-block * Update permalinks * Fixed a lot about tables * Removed Description header from work-packages page * Fix frontend styles * Add placeholder styling, fix toc * Fixed figure print * working with table aligns * Custom class add to task lists * Custom classes applied to theads * op-uc-container custom class added to container * Codeblocks inside pre elements * Fix: single <code> and <a> tags * explicitly require overwritten gem class Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode * adapt spec expectation to altered toc rendering * CkInspector removed * Latest ckeditor changes * remove highlight css class from wiki content * allow html pipleline to handle macros with additional classes * Fixed a lot of print css for tables * Add general print css back in * Update Table of Contents styling * Custom classes on ul, ol, li and task-lists * Revert "Custom classes on ul, ol, li and task-lists" This reverts commit `0d27d28137`. * Custom classes on ul, ol, li and task-lists * Custom classes on column's th * remove placeholder class when rendering * WOrking on task lists * Changing task-list classes, changed tests * Updated list styles * Remove unused todo list styles * remove checked in binstubs * Fix table of contents * adapt todo list handing in backend pipeline * adapt specs to altered css classes * Add numbers to table of contents * Better comments in table of contents * Fix: wrap single <table> with a <figure> * Fixes to todo list design * Updated todo list scss to fix nested lists * adapt selectors in table spec * Update table styles * Improve table borders more * Custom classes specs * Fix: no need to remove regular list classes when its type changes * Add modifier for inline headings * Update table editing styles * Remove break-word tests * wrap images just like tables * Update figure content styles * Fix: All tests passing (ul.op-uc-list_task-list) * div.op-uc-figure--content wrapping tables * Specs for figures wrappers div.op-uc-figure--content * Fix: add custom classes to links and codes again * Table wrapper div reverted + specs * Fix inline palceholders * Custom macro type classes * Add basic macro placeholder changes * Move heading permalink after text * Fix word-break spec * Sending figure styles to the backend (width) * extend test to take ckeditor placeholder into account * avoid adding bem classes multiple times * attempt to fix flickering spec * Removing image spinner when uploading finishes * adapt spec expectations Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Aleix Suau	5ea357c750	Bump CKEditor5 to v21 (#8570 ) * Bump to v21 * Upgraded to v21, really * Todolist spec fixed * Update fixes for child pages macro * Fix code block conversion Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	a92575e3ec	Use distinct(*) on aggregated journal to avoid duplicate raw journals https://community.openproject.com/wp/33744	4 years ago
Oliver Günther	c6b9c8ff02	Use distinct(*) on aggregated journal to avoid duplicate raw journals https://community.openproject.com/wp/33744	4 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	1c6ed3671a	[30920] Fix links in task lists They were broken due to the way todo list labels and inputs are nested differently when links are present: CKEditor converts todo lists differently when they contain a link <ul class="todo-list"> <li> <label class="todo-list__label"> <input type="checkbox" disabled="disabled" checked="checked"> <span class="todo-list__label__description">4 teaspoons baking powder </span> </label> </li> <li> <a href="https://example.com"> <label class="todo-list__label"><input type="checkbox" disabled="disabled"> <span class="todo-list__label__description">1/4 teaspoon salt </span> </label> </a> </li> </ul> which is why we need to override the list item rule for turndown to address this and replace the todo list on our own. https://github.com/opf/commonmark-ckeditor-build/pull/45 https://community.openproject.com/wp/30920	5 years ago
Henriette Dinger	2a14443840	Adapt test to new placeholder	5 years ago
Henriette Dinger	6f92035ccc	Rename EditField classes used for tests and remove WorkPackage reference	5 years ago
Henriette Dinger	f47a75d153	[31023] Preparation for project edit fields: Generalize edit and display fields currently work package specific (#7726 ) * Check edit fields for Work package dependencies * Make EditForm, NotificationService, EditContext indepenedent of Work Packages * Make EventsService independent of WorkPackages * Start renaming WpNotificationService (WiP) * Fix more references * Fix typescript errors * Add basic halEditingService * Rename to global halResourceEditingService (WiP) * Move typing from class to methods (WiP) * Fix typescript errors * Remove space in type * Add test project widget && generalize the editFieldGroup * Rename editing portal service [ci skip] * Rename WpEditFieldComponent * Rename WpDisplayFields * Rename display-XX-field to XX-display-field [ci skip] * Add WP specific ID field to distinguish between resources * Re-add state in work package resource * Generalize display field renderer * Rename spent-time to wp-spent-time and fix highlight specifics [ci skip] * Actually load the project schema and make field editable * Make edit-field-group.component an edit-form.component and subclass EditForm * Remove edit context in favor of specialized EditForm * Add special cases for work package editing * Fix edit actions bar * Fix codeclimate issues * Use WorkPackageNotificationService if necessary * Override NotificationService for WPs to allow WP specififc notifications (WiP) * Correctly provide wpNotification service Because the ui-router doesn't seem to correctly use the parent element's injector, we need to provide the wpNotification service not in the wp-base, but rather the wp-list component as well as in the isolated query space. * Allow to filter halEvents for specific resourceTypes (e.g. WorkPackage) * Remove superfluous cell class constant * Start renaming selectors for wp-edit-field into generics * Remove wp-table--cell-span in favor of display field selector * Consolidate other display and edit field styles * Provide specialized service for transitions in active edit forms * Remove superfluous overflowSelector * Accept that date field contains some work package specifics * Ignore unreadable files * Provide the changeset for work packages as a hook Since hal resource editing service is provided per query space, we cannot register them once (would only work globally) * Fix dangerfile * Remove another todo in halResourceNotification service * Fix npm TestBed for changed dependencies * Show inplace edit field in project details widget * Fix highlighting in single view * Provide HalResourceEditingService outside of project context * Used typedState for single-view * Also provide wpNotification service in split view * Correct check for resource type in eventsService * Fix getSchemaName in display field renderer * Fix passing ids into `halEditing.stopEditing` * Do not globally inject the halResourceEditingService There's a bug(?) in ui-router that gives you the global service before the parent injected service for a ui-view * Fix wpCreate service on copying and parallel creation * Remove test project widget * Revert changes for project details widget	5 years ago
ulferts	4e5b9afef5	rename project attributes	5 years ago
Oliver Günther	3ae39f8bb4	[30928] Fix clicking on WP links since hover card visible The click with an open hover card prevents the default action of the link, preventing the click to result in page changing.	5 years ago
ulferts	e97883cdd8	attempt to fix flickering activty spec by less ambivalent input	5 years ago
Oliver Günther	85398d71df	Change selector to not fail on first attempt Since we insert the tasklist, angular seems to have a temporary pass that is brekaing these specs. However, the failing screenshots always show the correct comment so I suspect it's a timing issue. This PR changes the expectation to run in a retry_block without retrying the entire spec	5 years ago
Oliver Günther	872fba5892	Fix styling of task lists	5 years ago
Oliver Günther	f72a4f074f	Provide tasklists with ckeditor-list and tasklist filter	5 years ago
Oliver Günther	058d353603	Mentions	6 years ago
Oliver Günther	e71c0fb222	Mark ckeditor file as binary	6 years ago
Oliver Günther	d2f086fd88	Create service helper to construct CKEditor instance with context Context will be defined by: - macros can be enabled either globally or per-plugin - Image upload plugin will be enabled when resource exists + has addAttachment	6 years ago
Jens Ulferts	319f33e924	remove textile	6 years ago
Jens Ulferts	529e899316	reenable user mentioning and wp referencing	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Oliver Günther	e7384aedf3	Fix markdown specifics for Chrome	7 years ago
Oliver Günther	579f8bc233	Create new beta build	7 years ago
Oliver Günther	6762b85d0b	Add vendored ckeditor builds for easy building an linking	7 years ago
Oliver Günther	1da55e4095	Convert user directive to edit in markdown mode	7 years ago

27 Commits (51a40c97eb0315fd2a5dd86dfd7333f9d8d15d92)