openproject

Commit Graph

Author	SHA1	Message	Date
Wieland Lindenthal	83b43a5f6d	White list params before merging them	7 years ago
Oliver Günther	376fa46d4b	[26691] Avoid find(ids) in eager loader The `WorkPackageCollectionEagerLoading` uses eager loading for eager loading CF values that MAY not exist anymore. This results in a faulty query when hitting one of these entries. ``` E, [2017-11-29T17:25:21.847832 #14241] ERROR -- : Grape rescuing from error: API::Errors::NotFound Original error: #<ActiveRecord::RecordNotFound: Couldn't find Version with 'id'=35> Stacktrace: /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/finder_methods.rb:353:in `raise_record_not_found_exception!' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/finder_methods.rb:479:in `find_one' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/finder_methods.rb:458:in `find_with_ids' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/finder_methods.rb:66:in `find' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/querying.rb:3:in `find' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/core.rb:151:in `find' /opt/openproject/lib/api/v3/work_packages/work_package_collection_representer.rb:228:in `eager_load_custom_values' /opt/openproject/lib/api/v3/work_packages/work_package_collection_representer.rb:216:in `eager_load_version_custom_values' /opt/openproject/lib/api/v3/work_packages/work_package_collection_representer.rb:197:in `full_work_packages' /opt/openproject/lib/api/v3/work_packages/work_package_collection_representer.rb:72:in `initialize' /opt/openproject/app/services/api/v3/work_package_collection_from_query_service.rb:125:in `new' /opt/openproject/app/services/api/v3/work_package_collection_from_query_service.rb:125:in `collection_representer' /opt/openproject/app/services/api/v3/work_package_collection_from_query_service.rb:57:in `results_to_representer' /opt/openproject/app/services/api/v3/work_package_collection_from_query_service.rb:46:in `call' /opt/openproject/lib/api/v3/queries/helpers/query_representer_response.rb:37:in `query_representer_response' /opt/openproject/lib/api/v3/queries/queries_api.rb:91:in `block (3 levels) in <class:QueriesAPI>' ``` https://community.openproject.com/wp/26691	7 years ago
Jens Ulferts	690e0ffc60	wp create/update/destroy via services	7 years ago
Oliver Günther	60f146e76d	[26313] Output checked value for check_box tag form builder (#6020 ) [ci skip]	7 years ago
Oliver Günther	0c44f7b501	Fix i18n spec	7 years ago
Oliver Günther	76425aa34c	Load i18n plugin crowdin entries from plugins	7 years ago
Oliver Günther	94cc615211	Fix lookup of languages in i18n and webpack	7 years ago
Oliver Günther	845797d9ed	Add translations for core plugin branch	7 years ago
Oliver Günther	b828bbfaab	Bump VERSION to 7.3.3	7 years ago
Markus Kahl	4e4ed9bbe8	verify authenticity of stage complete calls (#6014 ) * verify authenticity of stage complete calls * fixed path helper name [ci skip]	7 years ago
Henriette Dinger	89e8c316a5	[25512] More prominent work package status selector (2) (#5999 ) * Add new WP status selector button [WIP] * Change styling and add little permission handling * Store changed status * Adapt new styling * Show status depending on the changeset * Remove status button from create form && reduce height of info row * Adjust test cases, add success message, support for help texts and transfer css variables [ci skip]	7 years ago
Markus Kahl	90558ca8f2	Authentication stages mechanism (#5998 ) * authentication stages mechanism * integration test for authentication stages * code climate * fixed omni auth and after activation * clean up session after registration finished * allow passing blocks to return stage paths * don't instance exec in controller * fixed registration without stages	7 years ago
Oliver Günther	6acd4a8622	Bump VERSION to 7.3.2	7 years ago
Jens Ulferts	047e972653	speedup relation candidates api	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
Oliver Günther	ac389b869d	Fix other request specs by adding json header	7 years ago
Oliver Günther	4d0bad7efc	Allow endpoints to override content types (attachments!)	7 years ago
Oliver Günther	8282c465cb	[26318] Enforce APIv3 content-type https://community.openproject.com/wp/26318	7 years ago
Oliver Günther	fc8a993836	Bump VERSION to 7.4.0	7 years ago
Jens Ulferts	3c537675bc	Bump VERSION to 7.3.1	7 years ago
Oliver Günther	359c95d09b	[26354] Fix overridden global regex (#5948 ) rails_autolink has its own `AUTO_LINK_RE` that, depending on the load order may be defined before the textile formatter. https://community.openproject.com/wp/26354 [ci skip]	7 years ago
Oliver Günther	39eb01ad42	Reload cached types in attribute groups spec [ci skip]	7 years ago
Oliver Günther	f1dd84bb59	[26374] Set context for queries in new project (#5943 ) [ci skip]	7 years ago
Wieland Lindenthal	4e22681e78	User mentions feature (#5897 ) * Extend syntax for linking users via their ID * Allow login names for linking user profiles. * User require_relative for legacy tests * Add specs for login name based user links; Fixes other specs, too. * Notify mentioned users * Notify linked users; - require quotes for login names in user links as login names can contain spaces, dots that are typical word boundaries - Adding specs * For the decision who gets notified due to mentions only the visibility permissions of the recipient are relevant. * Rubucop satisfaction * Add autocomplete for user names to work pack package descriptions and activity - Uses API V3 Principals endpoint. - Extends API endpoint with name filter and name order. - Make it activate when user types an "@" or a "user#" - Still for work packages only. * Directly show a list of users after typing '@' and allow navigating list with cursor keys * Add an '@' before the rendered user link * Adopting spec as WP autocompleter now expects whitespace before hash sign * Adding spec for using user autocompleter * Introduce magic pageSize of 0 for maximum length * Add id filter for principals * Allow pagination for principals and protect from falling back to a too low default value * Fixing specs * fixing typo in spec * Add magic number 0 for user custom fields * Add a toParams method for ApiV3FilterBuilder * User ApiV3FilterBuilder in path helper service * Add test for mentions principals to path helper * WIP * Convert auto complete helper to TS [ci skip]	7 years ago
Oliver Günther	92060508a9	Remove unused test helper	7 years ago
Oliver Günther	988d96c241	Restrict session API authentication to X-Requested-With	7 years ago
Oliver Günther	fdfb41b327	[26069] Allow passing of me-value link for principal filters again The 'me' value is currently automatically normalized to the current user, making it impossible to store queries that reference the current user whenever accessing the query as before.	7 years ago
Oliver Günther	89ac5789c7	Replace scopes with already defined names The activerecord scope helpers output a warning when a scope's name already exists in the module's method chain. E.g., `Kernel#open` is overridden by some of the scopes, but that always results in a warning. A better way is to explicitly override the method in the model using a class method.	7 years ago
Oliver Günther	cf55f61e73	Don't register textile formatters in initializer (#5903 ) When the autoloader reloads WikiFormatting, the values registered in the initializer are lost [ci skip]	7 years ago
Oliver Günther	fc50bb72a1	[26237] Add configuration option for default comment order (#5896 ) https://community.openproject.com/wp/26237 https://community.openproject.com/wp/25932 [ci skip]	7 years ago
Oliver Günther	342a30f7eb	Make configuration hash indifferent (#5893 ) [ci skip]	7 years ago
Markus Kahl	4b316ec470	LDAP Single Sign-on (#5888 ) * ldap sso * localise sso failure error * code climate * code climate 2 * code climate 3 * added missing login param * make spec work with SSO module prepended to ApplicationController * polish [ci skip]	7 years ago
Oliver Günther	26332c446b	[25739] Allow copying of attachments in wiki and work package (#5889 ) * [25739] Allow copying of attachments in wiki and work package https://community.openproject.com/wp/25739 * [25769] Fix duplicate wiki menu item On creation, a wiki always gets its default wiki menu item. we don't need that upon copying however, since the wiki menu items will be copied. [ci skip]	7 years ago
Oliver Günther	381b1a74a0	Bump VERSION to 7.2.4	7 years ago
Oliver Günther	75d2f010ba	[25108][26176] Assigned_to filter returns group values Since 7.0.0, the `assigned_to is <user>` filter also returns work packages assigned to a group that `<user>` belongs to. Since this is misleading and judged a bug by several customers, instead add a new filter that provides exactly this behavior, while using `assigned_to` only for the exact value specified there. https://community.openproject.com/wp/26176 https://community.openproject.com/wp/25108	7 years ago
Oliver Günther	ddcf35f3f7	Fix invalid value_objects being passed to representer There are queries that seem to pass values not available in APIv3 path helper to the instance representer. ``` Original error: #<NoMethodError: undefined method `anonymous_user' for API::V3::Utilities::PathHelper::ApiV3Path:Class Did you mean? anonymous?> Stacktrace: /opt/openproject/lib/api/v3/queries/filters/query_filter_instance_representer.rb:82:in `block (2 levels) in <class:QueryFilterInstanceRepresenter>' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:38:in `map' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:38:in `map' /opt/openproject/lib/api/v3/queries/filters/query_filter_instance_representer.rb:80:in `block in <class:QueryFilterInstanceRepresenter>' ```	7 years ago
Oliver Günther	429f1d0046	Bump VERSION to 7.2.3	7 years ago
Oliver Günther	ed1a0c87de	[25999] Make timeline labels configurable https://community.openproject.com/wp/25999	7 years ago
Markus Kahl	37ac1b8d22	added after_login redirect URL configurations	7 years ago
Oliver Günther	e02a65e372	[26141] Use valid subset of query to save it (#5859 ) https://community.openproject.com/wp/26141 [ci skip]	7 years ago
Oliver Günther	f07ee8c2b5	Don't use return in block	7 years ago
Oliver Günther	47c5475e44	Require hashie [ci skip]	7 years ago
Oliver Günther	9f869a5a69	Bump VERSION to 7.2.2	7 years ago
Oliver Günther	ece6fa5d23	[26128] Fix local jump error (#5856 ) [ci skip]	7 years ago
Oliver Günther	f08cb6cd4f	[26121] Make expanded relation background transparent [ci skip]	7 years ago
Oliver Günther	c5b8add0e7	Restrict local cloning feature to http(s) and file urls (#5850 ) [ci skip]	7 years ago
Wieland Lindenthal	d589da7f6a	Improve utm params for help menu links	7 years ago
Markus Kahl	aad898439c	added after_login redirect URL configurations	7 years ago
Wieland Lindenthal	70214d9a85	Linking to newsletter from within home and help menu (#5836 ) https://community.openproject.com/projects/openproject/work_packages/260 54 [ci skip]	7 years ago
Oliver Günther	063140befb	Bump VERSION to 7.2.1	7 years ago

... 2 3 4 5 6 ...

4494 Commits (51e26a9719e48f9992d1fe6b14289ea6b6f6eb02)