67 Commits (52f4f3b5d1d679ddfffe665ec3a9454c3a3aee94)

Author	SHA1	Message	Date
Oliver Günther	9ec1e05891	Fix counting on multiple columns for project	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
Oliver Günther	bb27cf9903	[37257] Bust cache on settings name format change (#9276) ... * [37257] Bust cache on settings name format change https://community.openproject.org/wp/37257 * add specs for user representer cache busting & avoid patch Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961) ... * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937) ... * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Benjamin Bädorf	e848d44dea	Fix/update wysiwyg styles (#8844) ... This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances. * Initial class definitions * Added more classes * Added Table of Contents basics * CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote * CKEditorInspector removed * op css class for headings * op css class for paragraphs * op css class for code/code block * adapt specs to altered markdown/html generation * adapt grid/budget representers to altered signature * op css class for lists * op css class for toc * op css class for links * Start working on typography css * op css class for tables * Fixing more typography, trying out larger headers * Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros * adapt specs to altered link classes * op css class for images * apply user content container class throughout application * CSS alignment custom classes applied to table * op css class for task list checkbox * Added task checkbox class * amend list checkbox class in backend * op css class for table thead element * adapt specs on image html generation * Updated table and typography styles * Update typography and figure styles * Figure overflow handling * Table alignment styles + ckEditor styles removed * rename wiki-anchor to op-uc-link_permalink * wrap table in div as well as figure * Updated code-block * Update permalinks * Fixed a lot about tables * Removed Description header from work-packages page * Fix frontend styles * Add placeholder styling, fix toc * Fixed figure print * working with table aligns * Custom class add to task lists * Custom classes applied to theads * op-uc-container custom class added to container * Codeblocks inside pre elements * Fix: single <code> and <a> tags * explicitly require overwritten gem class Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode * adapt spec expectation to altered toc rendering * CkInspector removed * Latest ckeditor changes * remove highlight css class from wiki content * allow html pipleline to handle macros with additional classes * Fixed a lot of print css for tables * Add general print css back in * Update Table of Contents styling * Custom classes on ul, ol, li and task-lists * Revert "Custom classes on ul, ol, li and task-lists" This reverts commit 0d27d28137. * Custom classes on ul, ol, li and task-lists * Custom classes on column's th * remove placeholder class when rendering * WOrking on task lists * Changing task-list classes, changed tests * Updated list styles * Remove unused todo list styles * remove checked in binstubs * Fix table of contents * adapt todo list handing in backend pipeline * adapt specs to altered css classes * Add numbers to table of contents * Better comments in table of contents * Fix: wrap single <table> with a <figure> * Fixes to todo list design * Updated todo list scss to fix nested lists * adapt selectors in table spec * Update table styles * Improve table borders more * Custom classes specs * Fix: no need to remove regular list classes when its type changes * Add modifier for inline headings * Update table editing styles * Remove break-word tests * wrap images just like tables * Update figure content styles * Fix: All tests passing (ul.op-uc-list_task-list) * div.op-uc-figure--content wrapping tables * Specs for figures wrappers div.op-uc-figure--content * Fix: add custom classes to links and codes again * Table wrapper div reverted + specs * Fix inline palceholders * Custom macro type classes * Add basic macro placeholder changes * Move heading permalink after text * Fix word-break spec * Sending figure styles to the backend (width) * extend test to take ckeditor placeholder into account * avoid adding bem classes multiple times * attempt to fix flickering spec * Removing image spinner when uploading finishes * adapt spec expectations Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765) ... * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
ulferts	8175dc4acd	add language to user api (#8812) ... It is documented and as such, it should be part of the api	4 years ago
ulferts	633a82dff8	display user name as link for non admins ... The showUser link of the user representer is now used to signal when the link can be followed. That link can only be followed when the user is not logged. The frontend now only checks the availability of the link to determine whether the user name in the work package activity is to be displayed as a link or not	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	53a3647736	hide email if so desired ... * Admin and self can still retrieve it * The attribute is now hidden altogether if the preferences state to not show the mail. This is in line with the rest of the representer`s behaviour	5 years ago
ulferts	3a4b05b927	hide user status in api	5 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308) ... * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
ulferts	1850622f20	Feature/versions api update (#7299) ... Feature/versions api update [ci skip]	6 years ago
Jens Ulferts	e93e3731b2	place user delete service inside users namespace	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot ... Removes the deprecation	7 years ago
Jens Ulferts	ac59ad6a89	introduce group resource stub	7 years ago
Jens Ulferts	ce21ee20f7	cached representers	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	b9cd75e07e	Remove gravatar functionality from core ... [ci skip]	7 years ago
Oliver Günther	1d0b09fa5f	Merge release/7.1 into dev (#5667) ... * [25580] Remove Settings callbacks from avatar_helper `register_callbacks` will not work if its used to update a class-level variable. We might want to think about removing this entirely, however impermanent-memberships is still using it to update the database after a change. https://community.openproject.com/projects/openproject/work_packages/details/25580 * change toolbar button height (#5664) https://community.openproject.com/projects/openproject/work_packages/255 11/activity [ci skip] * Fix/relations drawing (#5663) * improved drawing of timeline relation lines * Improved relations data flow * Timeline relations: Load relations once the timeline becomes visible * - Fixed SwitchState failing test - Version bump ReactiveStates - cleanup [ci skip] * Set indention of breadcrumb for correct alignment * remove wiki icon for wiki submenu in main menu (#5665) [ci skip] * Add missing class * Fix table hierarchies previous values [ci skip]	8 years ago
Oliver Günther	0ae7d320e6	[25580] Remove Settings callbacks from avatar_helper ... `register_callbacks` will not work if its used to update a class-level variable. We might want to think about removing this entirely, however impermanent-memberships is still using it to update the database after a change. https://community.openproject.com/projects/openproject/work_packages/details/25580	8 years ago
Jens Ulferts	afb3d2eec5	increase spec reliability by configuring gravatar	8 years ago
Oliver Günther	e587a3c91d	Fix the user_representer being used with the wrong protocol	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	7b21088959	Adapter UserRepresenter and spec according to visibility	8 years ago
Jens Ulferts	e53916aec6	support perPage and offset on users index	8 years ago
Oliver Günther	6cbfc7ffed	[24063] Add Users PATCH endpoint	8 years ago
Oliver Günther	4658e83dd5	Add spec for invalid status	8 years ago
Oliver Günther	8a4074fd3f	Stub users in specs since IDs are now required	9 years ago
Oliver Günther	1ff1c170f9	Implement showUser path	9 years ago
Oliver Günther	638340e7b6	Fix rubocop issues	9 years ago
Oliver Günther	e9cd24f2bf	Add support for parent-scoped with_settings data	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers ... Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	4c232e786b	split specs for unpaginated and paginated collections	9 years ago
Jan Sandbrink	b332ef06aa	make collection representer explicitly unpaginated	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	6406b640b7	remove redundant spec ... one could argue that I learned from @0xF013 to delete inconvenient specs ;-) But in this case the spec is really made redundant by the two specs below [ci skip]	10 years ago
Jan Sandbrink	db5d633850	update factories to new default preference ... also use boolean type instead of DB values	10 years ago
Jan Sandbrink	a3ff9d57ed	fix user representer for representing groups [sic]	10 years ago
Jan Sandbrink	957b060851	hide a users mail address if he wishes to	10 years ago
Jan Sandbrink	9feb0700ac	rename mail to email, update docs, style code	10 years ago
Alex Coles	ebbc9e3d7d	Prefer #not_to over #to_not in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	944b89d83e	Convert specs to RSpec 3.2.0 syntax with Transpec ... This conversion is done by Transpec 3.0.7 with the following command: transpec -f * 34 conversions from: it { should ... } to: it { is_expected.to ... } * 14 conversions from: obj.stub_chain(:message1, :message2) to: allow(obj).to receive_message_chain(:message1, :message2) * 7 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: be_true to: be_truthy * 3 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: failure_message_for_should { } to: failure_message { } * 2 conversions from: failure_message_for_should_not { } to: failure_message_when_negated { } * 1 conversion from: Klass.any_instance.stub(:message => value) to: allow_any_instance_of(Klass).to receive_messages(:message => value) * 1 conversion from: be_false to: be_falsey * 1 conversion from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: stub('something') to: double('something') * 1 addition of: RSpec.configure { |c| c.infer_spec_type_from_file_location! } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Jan Sandbrink	03bfa42394	use shared examples in more tests	10 years ago
Jan Sandbrink	14ded43bda	fix tests, use mocking	10 years ago
Jens Ulferts	da588b812c	harmonize api decorators	10 years ago
Jan Sandbrink	c28a581ec4	test for missing delete link	10 years ago