59 Commits (5365c53f31237a41b799da3490d0b444194950bc)

Author	SHA1	Message	Date
Oliver Günther	b461feb1ba	Fix resolving the timezone	3 years ago
Oliver Günther	4fa5e38c3d	[34901] Set timezone when switching to user ... The meeting mailer uses `format_time` helper which only works for User.current, but then also uses `Time.zone` which is set only when using `with_locale_for`. We need to rework both, but as a workaround, we can set the locale for the user when switching to it. https://community.openproject.org/work_packages/34901	3 years ago
Benjamin Bädorf	87cd178270	Fixed more linting errors (#9452) ... * Fixed more linting errors * Update the selector of the focus directive to opFocus * Update the selector and BEM class of the focus-within directive * More linting fixes * Remove unused directives, merge focus and autofocus directive, remove now empty a11y module * Some small fixes * Fix ReorderDeltaBuilder * Fix failing specs, linting * Fix a couple of linting errors * Reenable linting rules for unsafe any * Reset broken code, update some html coding style	3 years ago
Oliver Günther	e9d7c374cc	[37868] Whitelist for attachment mime types and extensions on upload (#9431) ... * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract	3 years ago
Oliver Günther	f4dfd6c6c6	[36238] Extract and fix user references in other objects (#9007) ... * Move replacing invalid references into separate job for principals * Write migration to remove existing invalid custom values and responsible * Fix other specs * Fix other specs * rewrite replacing user in records * consolidate principal deletion * include placeholder users in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	12b507171c	work around stale object error not being thrown	4 years ago
Benjamin Bädorf	e848d44dea	Fix/update wysiwyg styles (#8844) ... This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances. * Initial class definitions * Added more classes * Added Table of Contents basics * CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote * CKEditorInspector removed * op css class for headings * op css class for paragraphs * op css class for code/code block * adapt specs to altered markdown/html generation * adapt grid/budget representers to altered signature * op css class for lists * op css class for toc * op css class for links * Start working on typography css * op css class for tables * Fixing more typography, trying out larger headers * Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros * adapt specs to altered link classes * op css class for images * apply user content container class throughout application * CSS alignment custom classes applied to table * op css class for task list checkbox * Added task checkbox class * amend list checkbox class in backend * op css class for table thead element * adapt specs on image html generation * Updated table and typography styles * Update typography and figure styles * Figure overflow handling * Table alignment styles + ckEditor styles removed * rename wiki-anchor to op-uc-link_permalink * wrap table in div as well as figure * Updated code-block * Update permalinks * Fixed a lot about tables * Removed Description header from work-packages page * Fix frontend styles * Add placeholder styling, fix toc * Fixed figure print * working with table aligns * Custom class add to task lists * Custom classes applied to theads * op-uc-container custom class added to container * Codeblocks inside pre elements * Fix: single <code> and <a> tags * explicitly require overwritten gem class Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode * adapt spec expectation to altered toc rendering * CkInspector removed * Latest ckeditor changes * remove highlight css class from wiki content * allow html pipleline to handle macros with additional classes * Fixed a lot of print css for tables * Add general print css back in * Update Table of Contents styling * Custom classes on ul, ol, li and task-lists * Revert "Custom classes on ul, ol, li and task-lists" This reverts commit 0d27d28137. * Custom classes on ul, ol, li and task-lists * Custom classes on column's th * remove placeholder class when rendering * WOrking on task lists * Changing task-list classes, changed tests * Updated list styles * Remove unused todo list styles * remove checked in binstubs * Fix table of contents * adapt todo list handing in backend pipeline * adapt specs to altered css classes * Add numbers to table of contents * Better comments in table of contents * Fix: wrap single <table> with a <figure> * Fixes to todo list design * Updated todo list scss to fix nested lists * adapt selectors in table spec * Update table styles * Improve table borders more * Custom classes specs * Fix: no need to remove regular list classes when its type changes * Add modifier for inline headings * Update table editing styles * Remove break-word tests * wrap images just like tables * Update figure content styles * Fix: All tests passing (ul.op-uc-list_task-list) * div.op-uc-figure--content wrapping tables * Specs for figures wrappers div.op-uc-figure--content * Fix: add custom classes to links and codes again * Table wrapper div reverted + specs * Fix inline palceholders * Custom macro type classes * Add basic macro placeholder changes * Move heading permalink after text * Fix word-break spec * Sending figure styles to the backend (width) * extend test to take ckeditor placeholder into account * avoid adding bem classes multiple times * attempt to fix flickering spec * Removing image spinner when uploading finishes * adapt spec expectations Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765) ... * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
ulferts	e111794528	fix viewing version of meeting agenda/meetings	4 years ago
ulferts	5968c0b18a	Fix/replace custom i18n function (#8681) ... * replace custom i18n function calls * remove custom i18n method	4 years ago
ulferts	27b41a313c	replace custom i18n function in views	4 years ago
Oliver Günther	10e21154f7	Move asset pipeline javascripts to frontend (#8482) ... * ove reporting and reporting_engine js to frontend page * Replace webhook assets javascript * Add path augment service to dynamically load scripts * Remove JS-Files that are not used/not needed any more * Include AugmentingModule correctly * Remove special handling for checkbox selection which is outdated and two jquery libs that are not used any more * Load scripts dynamically that are not needed globally * Move plugin JS to frontend * Move toggable fieldsets to global listeners * Move top-menu to global listeners and convert to TS * Move action_menu to frontend and port to TS * Move settings listener to frontend * Remove global js assets that were not used anyway * Move date range to timelog dynamic script where it's still used until removed * Move colors to global-listeners and port to TS * Replace tooltip with simple form instructions on the one place used Tooltips were only used at the one place in our application, when changing a users password. We can simply remove it there and use a modern solution the next time we need a tooltip * Move danger zone validation to frontend and port to TS * Move colorcontrast to backlogs vendor where it's used now * Remove contents of application.js.erb * Move project and user scripts to dynamically loaded * Move onboarding tour to dynamically loaded * Use correct syntax for jQuery so that $ is known keyword within this function * Fix onboarding tour * Fix onboarding tour for scrum tour * Fix specs after moving JS * Remove application.js.erb * Move locales and ckeditor to the frontend to dynamically load * Remove bundles caches These are no longer being used since angular cli * Ensure locales are exported before angular Co-authored-by: Henriette Darge <h.darge@openproject.com>	4 years ago
Oliver Günther	623f8c772e	Move module assets to frontend	4 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
Oliver Günther	184d255ab8	Fix link to wrong journal version	5 years ago
ulferts	64d0f57d85	Feature/aggregated activities (#8221) ... * use cte for aggregated journal * Revert "use cte for aggregated journal" This reverts commit 5fedefefdd. * add another subselect that could later on be provided from the outside * allow passing a nukleous sql to aggregated journals * wip - using aggregated journal for activity * new sql for aggregated journals * start implementing new aggregated query * additional documentation * consolidate activity functionality * simplify by turing into instance methods * move activity fetcher out of redmine * remove verb verification made obsolete Without catchall routes, the dispatching handles it * remove duplicate authorize check * refactor activities controller * refactory activity fetcher * cache avatar file * sort choosable events * remove legacy spec covered by contemporary * speed up aggregated journals via CTE * instance var might never have been set * ensure the event_types are always transmitted * correctly reset the avatar cache * fix avatar fetcher expectation regarding wiki pages * adapt spec [ci skip]	5 years ago
bsatarnejad	64e406bc7d	make cancel buttons consistent	5 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230) ... Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Henriette Dinger	a999805801	Correctly show warning when reopen meeting agenda	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
Henriette Dinger	ecaea1cf95	Correct string for button "History" ... [ci skip]	5 years ago
ulferts	2bc34e5006	deprecate attach_files	5 years ago
ulferts	cd049721d5	rename/move according to zeitwerk	5 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
Henriette Dinger	57529d73c4	Adapt tests to new tab row structure	5 years ago
Inga Mai	b85e42dcf6	Path added to tabs	5 years ago
Inga Mai	cf55ffbbf9	Add labels to js-en.yml	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Henriette Dinger	2e51467913	Hide some buttons on mobile and correct HTML structure	5 years ago
Henriette Dinger	24d019a84e	Correct DOM structur for some toolbars && let the editable toolbars span the complete width on focus via JS and not CSS only	5 years ago
Oliver Günther	6b0bc944ca	[31643] Don't try to render attachments on meeting content journal ... https://community.openproject.com/wp/31643	5 years ago
Oliver Günther	3001a93ee6	[31127] Correct timezone in user and meeting mailer ... https://community.openproject.com/wp/31127	5 years ago
Oliver Günther	5eb6fbf676	[31082] Remove max-height from ckeditor ... As we now have a proper `position: sticky` solution, the max-height is no longer required. It can by itself scroll when the next outer scroll container is being scrolled, which works on both content-wrapper scrolled pages, and work package pages. However that requires that we avoid `overflow: hidden` on the `form--fields` so this introduces a modifier for globally scrolled pages to do just that. https://community.openproject.com/wp/31082	5 years ago
ulferts	8863364b8d	replace meeting#new cukes with specs	5 years ago
ulferts	d4f1cf3a17	replace meeting delete cuke by spec	5 years ago
ulferts	ce0a787852	initialize virtual meeting attributes on copy	5 years ago
ulferts	53aea10b6e	use virtual_attribute on meeting	5 years ago
Henriette Dinger	0aa5d6a49b	Avoid data loss warning when submitting a form	5 years ago
Markus Kahl	d5abe0a47f	fixed close_agenda	5 years ago
Henriette Dinger	0877d49d18	Hide files section when the editor is open to avoid doubling	5 years ago
Markus Kahl	c2f5fb5896	handle missing agenda	5 years ago
Markus Kahl	bc5adfcba7	attachments for meeting contents (MeetingAgenda, MeetingMinutes)	6 years ago
Henriette Dinger	db6a9a2b7e	Remove event remove because otherwise the benforunload works only for the first edit	6 years ago
Oliver Günther	98d9f7aeb9	[29752] Cross-browser conformant beforeunload in meeting ... https://community.openproject.com/wp/29752	6 years ago
Henriette Dinger	41df8deef7	Throw warning when leaving initially opened edit fields in meetings, too	6 years ago
Henriette Dinger	41bc3c7fbd	Show warning before leaving meeting agenda with unsafed content	6 years ago
Inga Mai	8d198202c4	Adding all missing -required classes	6 years ago
Inga Mai	7b43a78836	Required fields implementation corrected, tests adapted	6 years ago