106 Commits (54d2f477f1fbf84d29a81fb73624c6cf5f3ede6b)

Author	SHA1	Message	Date
ulferts	8969afe617	close time entry modal on enter (#8653) ... * close time entry modal on enter As the time entry is saved anyway once the user saves the form, e.g. by pressing enter in the hours field, we can close the whole modal along with it. The "Save" and "Cancel" buttons do not make sense then anymore * attempt to stabilize flickering spec * fix ruby 2.7.1 hash parameter deprecations	4 years ago
ulferts	50daff5062	Fix/archived projects via api (#8625) ... * minor code cleanup * allow access to archived projects via api for admins The visibility check will not work in this case as no permission is active on archived projects. We therefore need to return all projects for admins at least	4 years ago
ulferts	87471d9624	remove string_objects and replace deprecated URI.unescape	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling ... Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
ulferts	acdd0bc821	disable oj for viewpoint body parsing ... oj in rails mode sometimes parses numbers to BigDecimal. Those then are serialized to strings when assigned to a JSONB column of an AR model, e.g. viewpoint's json_viewpoint attribute. The classic json gem does not behave in the same way so we use it for viewpoint parsing.	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Henriette Dinger	69debf8c0c	Add Bcf Topic DeleteService and DeleteEndpoint	5 years ago
ulferts	78722e8dbe	present error if title is missing	5 years ago
ulferts	0bab7839b1	linting	5 years ago
ulferts	e09a6db656	employ endpoint for projects#index	5 years ago
ulferts	0a9a7f02d1	fix content type in error handling	5 years ago
ulferts	dc9c8faf3c	extend default endpoints to bcf api	5 years ago
ulferts	3a89fceb0d	error handling in bcf v2.1	5 years ago
ulferts	c6b17e8a7a	extract root api into separate superclass	5 years ago
Oliver Günther	7fb86810db	Fix status and status attribute parsing in representer oncemore	5 years ago
Oliver Günther	82e36f9e14	Ensure writable call is not removed in payload representer	5 years ago
Oliver Günther	8a8193fa15	Add info on thread and connection pool for timeouts errors ... - Added to Rails controller request handling - Added to API root to catch all api requests as well Tested on sentry with both as https://sentry.openproject.com/sentry/localhost/issues/909/?query=is:unresolved	5 years ago
ulferts	c3c197bc24	attachments for custom_text widgets on dashboard	5 years ago
ulferts	cc41884048	add schema to project api and complete project resource	5 years ago
ulferts	a5defb73c5	add dedicated permission to regulate assigning a version	6 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308) ... * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
Oliver Günther	e94d64f9d2	Ensure all errors accept an optional message from exception ... And let the code be defined on the class	6 years ago
Oliver Günther	1b5fc32366	Avoid before blocks and raw params access for IDs ... Grape's validation runs after a `before` block so we should avoid using raw params there and instead using `declared(params)` which returns only the validated whitelisted params, much like a permitted params hash.	6 years ago
ulferts	1850622f20	Feature/versions api update (#7299) ... Feature/versions api update [ci skip]	6 years ago
Markus Kahl	a6429b67d2	log caught exception directly ... Wrapping the message with "Grape rescuing from error" adds no useful information and makes the exceptions harder to track in sentry and in general	6 years ago
Oliver Günther	0791c55870	Remove the internal setting with 500 max entries ... Instead, use the maximum allowed page size for the maximum number. This will match what the users have selected and be reasonable without adding another user-visible setting. https://community.openproject.com/wp/30103	6 years ago
Oliver Günther	f487fcacca	[30092] Use delegated logger (sentry) for logged API errors	6 years ago
Oliver Günther	8408f86fef	Improve usage of I18n in model specs ... This will avoid loading I18n translations in single-use cases where it would not be loaded anyway	6 years ago
Jens Ulferts	bd7690b4c6	introduce Grid data layer	6 years ago
Jens Ulferts	994c2d469c	avoid adding non writeable filters multiple times ... When the create_class method is called on WorkPackagePayloadRepresenter, a subclass of the class is created that includes the relevant custom fields. That class gets the PayloadRepresenter module included. The payload representer adds a render_filter to the attributes to avoid rendering unwriteable attributes. But when adding the filter, it is not added to an instance of the attribute in the subclass (WorkPackagePayloadRepresenter + CustomFields)but rather to the one in the superclass (WorkPackagePayloadRepresenter). The filter list instance is shared by all subclasses. That sideeffect is not dangerous per se as we want all WorkPackagePayloadRepresenters to have the filter. But as we have one instance of an array, adding to that array will lead to having the filter multiple times which will then all have to be evaluated on every rendering pass. By checking if the filter is already included before adding it, we can avoid this behaviour. The better fix would be to rework the way custom fields are handled in the representers. This could be done by having one representer for the static attributes and one for the dynamic custom fields. Those two representers could be rendered/parsed independently and the results could then be merged. This approach however takes considerably more time.	6 years ago
Jens Ulferts	c1853a5cdd	fix expected namespace for groups on assignee and responsible property	6 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Wieland Lindenthal	4e22681e78	User mentions feature (#5897) ... * Extend syntax for linking users via their ID * Allow login names for linking user profiles. * User require_relative for legacy tests * Add specs for login name based user links; Fixes other specs, too. * Notify mentioned users * Notify linked users; - require quotes for login names in user links as login names can contain spaces, dots that are typical word boundaries - Adding specs * For the decision who gets notified due to mentions only the visibility permissions of the recipient are relevant. * Rubucop satisfaction * Add autocomplete for user names to work pack package descriptions and activity - Uses API V3 Principals endpoint. - Extends API endpoint with name filter and name order. - Make it activate when user types an "@" or a "user#" - Still for work packages only. * Directly show a list of users after typing '@' and allow navigating list with cursor keys * Add an '@' before the rendered user link * Adopting spec as WP autocompleter now expects whitespace before hash sign * Adding spec for using user autocompleter * Introduce magic pageSize of 0 for maximum length * Add id filter for principals * Allow pagination for principals and protect from falling back to a too low default value * Fixing specs * fixing typo in spec * Add magic number 0 for user custom fields * Add a toParams method for ApiV3FilterBuilder * User ApiV3FilterBuilder in path helper service * Add test for mentions principals to path helper * WIP * Convert auto complete helper to TS [ci skip]	7 years ago
Oliver Günther	fdfb41b327	[26069] Allow passing of me-value link for principal filters again ... The 'me' value is currently automatically normalized to the current user, making it impossible to store queries that reference the current user whenever accessing the query as before.	7 years ago
ulferts	9c8f7f3ca1	read operations for time_entries via api v3 (#5776) ... * read operations for time_entries via api v3 Introduces the endpoints: * GET /api/v3/time_entries * GET /api/v3/time_entries/:id * GET /api/v3/time_entries/activities/:id The index action for time entries can be queried by the following filters: * project_id * user_id * work_package_id The implementation is exposing the database structure mostly one to one with the exception of some renaming and the hiding of the activities' complexity, where only the activity used systemwide is referenced regardless of whether a project specific override exists or not. * allow custom values for time entries [ci skip]	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732) ... * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
ulferts	7ad39ec35f	Fix/cache query representers (#5711) ... * cache various query representers json representation * sort by * columns * group by * filter instance schemas * fix custom option path [ci skip]	7 years ago
ulferts	36ab671d27	log stacktrace on api error (#5450) ... [ci skip]	8 years ago
Markus Kahl	9e79d02d8f	queries create and create form api endpoints	8 years ago
Markus Kahl	f5a57e3f42	list custom field normalisation and multi select	8 years ago
Jens Ulferts	c4bef2247d	adding filter instance schemas	8 years ago
Oliver Günther	65e24558a3	Log grape errors when rescuing from them	8 years ago
Jens Ulferts	80c242dd53	embed query results in query representer ... This is only done when the representer is not embedded itself, e.g. when it is part of a collection.	8 years ago
Jens Ulferts	97bff16dcc	fix filtering by subprojectId	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	1bb3631bd6	fix estimated time filters ... Because estimatedTime is turned to estimatated_hours by the PropertyNameConverter, checking whether work package responds to estimated_hours.pluralize only to return estimated_hours_id does not make sense. That behaviour was introduced to cope with the watcher attribute which should have been turned into watcher_ids as watchers is a has_many relations. But when that behaviour was fixed to work correctly with estimated_hours again, so that the name converter returns estimated_hours (no foreign key) and watcher_ids (foreign key) the watcher bug had to be fixed all over again. For turning work package filter parameters from the external to the internal representation, the v3 now makes use of the same method, as employed by the experimental api	8 years ago
Markus Kahl	dad0e5313f	support both e.g. `watcher` and `watcher_id` ... the previous fix only made `watcher` work, not the latter	8 years ago
Markus Kahl	6459d04706	map watcher to watcher_id to fix filter	8 years ago