openproject

Commit Graph

Author	SHA1	Message	Date
Alex Coles	8fd535769a	Fix bad rubocop auto-correct in journal_manager.rb Reported as issue upstream: https://github.com/bbatsov/rubocop/issues/2021 [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	093a6a8a98	Minor indent fix in News model for Rubocop [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	12d891ceb8	Fix missing space around blocks in MailHandler Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	c967e61097	Revert "Work-around Project nested set errors on PG" This issue should be fixed in our Rails 4(.1)-compatible fork of awesome_nested_set. See: `7bd473e845` This reverts commit `0c56b72d2a`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	5a25c32b2f	Revert "Work-around WorkPackage nested set errors on PG" This issue should be fixed in our Rails 4(.1)-compatible fork of awesome_nested_set. See: `7bd473e845` This reverts commit `2ea2c776e3`.	9 years ago
Alexander Bach	c42dad3270	Correct comment	9 years ago
Alexander Bach	2f9c9178df	Fix regex properly	9 years ago
Alexander Bach	248f11fba8	Correct style	9 years ago
Alex Coles	7cb1e43d53	Restore CustomField.for_all include option Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	c02804b0eb	Teach acts_as_searchable a references option * Update usages in models. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	8afb27578f	Add missing explicit join reference in Version Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	fb8dfed1a4	Minor indent fix in Version for Rubocop [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	91ee3dee20	Replace deprec. with_scope in Project.find_visible Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ae59a6985a	Teach User.authorize_within ActiveRecord::Relation Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	787a35c9db	Add explicit join references in models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	624b50d5bb	Remove deprecated Relation#all in models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alexander Bach	1a52cc1292	Suppress the hound	9 years ago
Alex Coles	0a44da8251	Teach Project#allowed_permissions how to pluck Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	b2790b8db1	Migrate deprecated .update_all with conditions Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	6d93fa3d76	Add Query#connection to avoid deprecation warnings Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	355e7e0ff4	Replace deprecated calls to Model#connection	9 years ago
Alex Coles	0c729dae54	Replace deprecated calls to Model.scoped Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	2ea2c776e3	Work-around WorkPackage nested set errors on PG See also `0c56b72d`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alexander Bach	851f8bf3d1	Make validation regex comply with hint	9 years ago
Alex Coles	67c84961a0	Migrate model has_many conditions to lambda Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ecfa05fad9	Rename Project.public scope to public_projects Avoid collision with `public` class method. As of Rails 4.1, `public` is explicitly black-listed as a scope name: https://github.com/rails/rails/pull/14582	9 years ago
Alex Coles	2c741c4b7f	Prune dead scope from Project Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	5557f58e80	Migrate model scopes to use lambda/block Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0f9240037a	Fix TimeEntry cleanup on work package bulk delete Fix `WorkPackage.cleanup_associated_before_destructing_if_required` semantics so that the first argument can either be an individual `WorkPackage` (as the spec originally expected) or a collection (as in actual usages). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	064d66449a	Migrate AR finder/query methods in models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	df51b6ed99	Fix syntax (w/Rubocop) in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	16720d2d7c	Rework DeletedUser.first to avoid stack overflow `.find_or_create_by` will call `.first`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	9f4ebc04a5	fix moving of WPs without specifying a status attributes without a value are actually represented by empty strings. Thus only take the status_id if it is :present? (the inverse of :blank?)	9 years ago
Jan Sandbrink	96d0cf9462	fix moving of WPs without specifying a status attributes without a value are actually represented by empty strings. Thus only take the status_id if it is :present? (the inverse of :blank?)	9 years ago
Alex Coles	8edff9831c	Pull up constants, associations into Principal Constants were previously misplaced in `User` subclass (as noted in TODO). Associations were previously moved into subclass to work- around an apparent STI bug. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	7ae6499d79	Remove unloadable from ReportedProjectStatus Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	c80a792496	Use 1.9+ Hash syntax in Principal Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	507bfc12bc	Prune unnecessary option on CustomField translates `fallbacks_for_empty_translations: false` is default. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	dbb751f96a	Remove commented Type.all override Commented in `53ecf98b`. This was not only broken, but also redundant, given that there is a default scope defined for `Type`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Oliver Günther	cb123c83be	Fix and specs for missing plus in login attribute Fixes the merge issue from `105934a5f9`	10 years ago
Alex Coles	40ae6c6524	[wip] Disable ProjectType has_many validation Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	9a9d6aca2c	ensure correct file size errors are displayed	10 years ago
Jan Sandbrink	4a69d2505a	replace ternaries returning booleans - foo ? true : false was replaced where foo already was bool - foo ? true : false was kept, when the ternary did a bool conversion - foo ? false : true was replaced by either negation or replacing == with != Note: I intentionally left one occurence that is fixed in another running PR and would cause a conflict	10 years ago
Alex Coles	0c56b72d2a	Work-around Project nested set errors on PG Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Toshi MARUYAMA	1b3628b60c	remove unneeded to_a	10 years ago
Alex Coles	55a2207631	Replace GroupUser join model w/ habtm association Active Record 4.x does not generate correct DELETE SQL statements when deleting groups for a given `User` (the `GroupUser` join model does not have a primary key). Callbacks (e.g. `after_remove`) are invoked on `has_and_belongs_to_many` associations. This effectively reverts `6c5239c4e2` Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e7e4914d22	Simplify Array find in Project::Copy Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	abf4a011f0	Fix copying of versions on Project copy Adds a more robust solution for copying closed versions and associating with copied work packages (see original patch `10ec20a8`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Markus Kahl	8f7d8ef573	avoid unnecessary work	10 years ago

... 2 3 4 5 6 ...

2596 Commits (55096ba3de6836f07ae8af1b37a4eea5b58e1783)