openproject

Commit Graph

Author	SHA1	Message	Date
Christophe Bliard	ca6a9f8684	Exclude frontend/node_modules for rubocop [skip ci]	2 years ago
Christophe Bliard	5596871a09	Add cop to enforce usage of ServiceResult factory methods The cop is named `OpenProject/UseServiceResultFactoryMethods`. It will check for ServiceResult.new call and check if it can be replaced by `ServiceResult.success` or `ServiceResult.failure`. These factory methods make the code easier to understand by being shorter and more explicit. This is the first cop I write, so there is probably room for improvement.	2 years ago
Markus Kahl	d5f00b5700	error reply for failed incoming email (#10726 ) * error reply for failed incoming email * deprecated date.to_s(:db) replaced with to_fs(:db) * rubocop concessions * nest away * do not report errors to unknown users by default * use verifying double	2 years ago
Christophe Bliard	1e5c722909	target ruby version 3.1 in rubocop	2 years ago
Christophe Bliard	8da459140e	refactor: expand options argument of allowed_to calls Clean Authorization::UserAllowedService methods to remove global and options parameters when they are not used use allowed_to_globally? where possible	2 years ago
Dombi Attila	02d4133195	Make work packages table sorting case insensitive	3 years ago
Dombi Attila	a1dd6a3779	Migrate team planner permissions	3 years ago
Dombi Attila	567c9984bd	Increase rubocop RSpec/MultipleMemoizedHelpers cop to allow 20 helpers, fix other cops	3 years ago
Christophe Bliard	42915fa0d4	Ensures source files have no utf-8 encoding comments	3 years ago
Christophe Bliard	e9e2887e06	add rubocop rule Rails/RequireDependency	3 years ago
Christophe Bliard	8ffc8723b9	rubocop: add 'as' as appropriate prefix for RSpec/ContextWording	3 years ago
Oliver Günther	642a5860fb	Enforce SyntaxMethods cops for FactoryBot	3 years ago
Oliver Günther	e8b26e6638	Disable FactoryBot SyntaxMethods	3 years ago
Oliver Günther	349a15b3af	Revert "Revert "bump ruby to 3.0"" This reverts commit `4f83d28651`.	3 years ago
ulferts	4f83d28651	Revert "bump ruby to 3.0" This reverts commit `632e2c9f41`.	3 years ago
ulferts	632e2c9f41	bump ruby to 3.0	3 years ago
Oliver Günther	0942947234	Linting	3 years ago
Eric Schubert	d6b87a2210	[#38833 ] BCF API Comments Service - https://community.openproject.org/work_packages/38833 - added requests tests - added check for expected body length - added representer and api for bcf_comments - added create and set attributes service for bcf_comments - added migration for comment hierarchy - added create and update service for journals	3 years ago
ulferts	57cfa51d19	accept HH:MM as valid times for the reminders	3 years ago
ulferts	f3478b1f2b	avoid UserPreference responding to every call Otherwise, e.g. FactoryBot will attempt to write created_at and updated_at to the settings	3 years ago
ulferts	63ad2e8dd1	Generate IAN near real time (#9570 ) * destroy notifications upon journal destruction * breakup spec by journable * have a dedicated job for scheduling journal completed events * generate notifications in delayed job * route wiki journal events through notifications * combine mail sending for notifications into single job * robustness if a journal is deleted * linting * differentiate BaseJournal and AssociatedJournal BaseJournal holds the data of a journal that reflects the columns in the journaled model while AssociatedJournal reflects the columns of a model associated to the journaled model via a has_many/one association * route news journal events through notifications This does not yet include notifications for comments on news * include news comment in notification workflow * have the whole workflow in a single state machine job * include forum message in notification workflow * include document in notification workflow * less dependencies from acts as watchable * fix, test and document workflow job	3 years ago
Benjamin Bädorf	02d5fac648	Exclude feature specs from RSpec/DescribeClass rule in rubocop	3 years ago
Oliver Günther	a0841ac6cf	[38323] Remove linebreak for shorter journal diffs https://community.openproject.org/work_packages/38323	3 years ago
Oliver Günther	ee95ed34ed	Add macro helper to format settings and base url	3 years ago
Oliver Günther	8a74e50b6d	Remove two subject cops we don't use	3 years ago
Oliver Günther	d75826beda	Disable AbcSize metric for specs, and allow let! setup	3 years ago
Oliver Günther	a87031982b	[38077] Skip rendering initial journal details in notifications https://community.openproject.org/wp/38077	3 years ago
ulferts	b424404e9b	increase Rspec/NestedGroup limit to 4	3 years ago
Oliver Günther	1e86331cfd	Enable new rubocop cops by default	3 years ago
ulferts	df5f899b2f	Fix/bump gems (#9435 ) * bump aws-partitions * bump dry-inflector & faraday & faraday-httpclient & faraday-patron & mime-types-data * bump newrelic_rpm * bump oj * bump rake * bump rdoc * bump rubocop * bump rubocop-rails * bump rubyzip * use rubocop-1-18-2 on codeclimate * remove rewrelic * bump oj * bump addressable * sentry-delayed_job & sentry-rails & sentry-ruby & sentry-ruby-core * bump danger * bump aws-partitions * bump git * use rubocop-1-18-3 on codeclimate * bump aws-sdk-sns * fix rubocop rule for Rails/ContentTag * bump aws-partitions * bump aws-sdk-core & aws-sigv4 * bump dry-core & excon * bump faraday & faraday-net_http_persistent * bump git * bump oj * bump parser * bump rake * bump recaptcha * bump rubocop-rails * bump sentry-delayed_job * bump sentry-rails * bump sentry-ruby & sentry-ruby-core * use rubocop-1-12-1 on codeclimate	3 years ago
Oliver Günther	9636a08988	[26688] In-app notifications (#9399 ) * Add bell icon to icon font * Add in app notification in top menu * Add fullscreen modal * Add notification modal and items * Style items * Toggle details of item * Mark all read * Add no results box * wip specification for event api * Add events table, query and index * Send out events from WP notification mailer job There we have the recipients present * Add cleanup job for older events with a setting * Hide bell notification when not logged * Add specs for events API index/show * Fix setting yml key * remove pry in event creation * Fix before hook in events API to after_validation * Fix polymorphic association raising exception for aggregated journals * Fix typo in read_ian * Fix yml entry for mentioned * Add read/unread post actions to event API and add specs * Wire up API to frontend * Fix order on events * Switch to unread in notification * Add event query * rename WPEventService * route wp mail sending over events * rename spec methods * author becomes watcher * correct message call signature * rename events to notifications * renname parameter to reflect notification nature * create author watcher for existing work packages * Merge unreadCount from store * Take a stab at polymorphic representers * Fix link generation in polymorphic resources For journals, no title is being generated however * Fix frontend model for context * Use timer for polling * add notification_setting data layer * Fix show resource spec * Fix duplicate class in notification bell item * Add minimal feature spec for notification * API for notification settings * Persist notifications * adapt work package notification creation to notification settings * extract notified_on_all * consolidate wp#recipients * concentrate wp notification in journal service * simplify methods * Remove unused patch endpoint * Add specs for rendering and parsing notification settings * Contract spec * Update service spec * adapt specs * Angular notifications frontend commit `e29dced646` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 17:34:50 2021 +0200 Create Akita store and query for notification settings commit `1a45c26c1a` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 11:09:25 2021 +0200 Remove tabs from notificaition settings page commit `0ea21e90c1` Author: Oliver Günther <mail@oliverguenther.de> Date: Sun Jun 20 21:55:48 2021 +0200 WIP in app settings * migrate notification data * add project visible filter to project query * Add inline-create and table display grouped by project * Add notifications under admin/users * Remove notifications partial * Rename notififcations store to user preferences store * Add setting for self_notified and hook that up to the backend * Add aria-label to table checkboxes * Restyle table and toolbar * replace remains of mail_notifications attribute * initialize notification settings for new user * adapt my_preferences references * reenable no self notified for documents * adapt specs * Avoid has_many :notifcation_settings Rails magically autosaves the user's preferences when the user gets saved, which somehow also tries to save the notfifications even when unchanged. This breaks some specs such as the avatar upload spec. As we can't update the assocation through rails anyway, just delegate to the user for reading instead. * Restore update method of notification settings * Restore update spec * fix spec syntax * lint scss * linting * Fix content_tag for bell icon * Add feature specs for notification settings * Disable ContentTag cop * use visible filter to get projects for notification The visible filter will reduce the project list down to the set of projects visible to the user provided as a parameter. This includes public projects. * test for actual mail sending * adapt me resource path this.apiV3Service.users.me changed its type in `0d6c0b6bc7` * Implement changed migration * Linting * Add actor to notification representer * Fix factory creating a duplicate WP journal * Add work packages loading and journal details to notification entry component * IAN basic facets, keep and expanded states. * Fix notification bell spec * Render body separately and add auto updating relative time * Add fixedTime title * Add actor to notification entry * Fix clicking links on work package and project * Tiny styling changes on entry row * Disable count in notification if larger than 99 (wont fit) * Introduce virtual scrolling to entry table * allow delaying & prevent mail sending if ain read Introduces a setting to delay mail sending after a journal aggregation time has expired. That way, users can confirm a notification in app. If they do before the delay expires, no mail is sent out additionally for that user. * consolidate notifications (in&out) into shared admin menu Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
ulferts	cf124c9819	Fix/bump gems (#9210 ) * bump aws-partitions * bump daemons & mini_portile2 * bump excon * bump fog-core * bump parser * bump prawn-markup * bump rack-mini-profiler * bump rdoc * bump rubocop-ast * bump rubocop-rspec * bump test-prof * fix rubocop.yml * merge duplicate rubocop rule flags	4 years ago
ulferts	ce5e06dde2	Fix/non matching pagination (#9202 ) * fix duplicates returned for wp list on multiple matching attachments/comments LEFT JOIN leads to potentially having multiple records returned if a search string is present in more than one attachment/comment. This is not a problem if we fetch work packages directly out of the query results but becomes problematic if only the id is fetched and then used to get the work packages by a subquery. * attachment filters no longer differentiate on tsv_where concatenation As EXISTS and NOT EXISTS is now used, the full string is always to be searched for so `and` concatenation is now always employed. * adapt spec Work packages that have no attachment at all are now also considered to match the filter if a "doesn`t contain" operator is used * less strict rspec rubocops for feature specs * cleanup code	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958 ) * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Philipp Tessenow	bd906716e5	[#36153 ] link manually created pull request to a work package using the GitHub integration plug-in (#9070 ) * Receiving and Parsing GitHub webhooks * added services for upserting PullRequests, GitHub users, and, checks. * added the datamodels for storing these entities * added logic to parse GitHub webhooks and save the entities above * fix some specs, added model specs * let UpsertPartialPullRequest return the upserted PR * added the last missing specs * avoid double-posts when editing pull requestsx * attempt to reduce flakiness * added pull requests API endpoint * handle edge case of converting partial PRs to full PRs * name raw input of an upsert service 'payload' to differentiate it from the prepared params * handle edge case: partial upsert after full PR creation * github_user does not reference users anymore * fixed a doc comment * use enums instead of custom validations * WIP * pairing with jens and some cleanup and test writing * better migration, clear up old PRs with a cron job * handle case of non-edit events which do not introduce new linked work packages, but still require a comment	4 years ago
Philipp Tessenow	a46de71009	[#36204 ] Add new GitHub plugin tab enabling users to copy git actions (#9027 ) * Let GitHub integration show changes in a separate tab * added new github integration icons to icon font * add tab content: working tab-header and copy-menu * modernise github_integrations ruby code * refactored some code to be more modern ruby (if wrote most of it 7 years ago and couldn't look at some parts without squinting too much) * make some intended-to-be-private module methods actually private * fixed all rubocop errors in the /modules/github_integration * re-organized tests a little * gave our rubocop.yml some RSpec-related defaults -- happy to discuss these, but I think we can live with these as a good starting point 👆 all without actually (intentionally) changing the behaviour * removed dead angular template code * codeclimate found more things than rubocop :) * removed create-pr-button since we decided against implementing that feature * added missing translations * properly cache the github related part of the wp api * lower case pull requests in translations * fix specs	4 years ago
ulferts	51102b23f6	increase limit on rspec memoized helpers	4 years ago
ulferts	8ab0732bc4	add rupocop-rails and rubocop-rspec (#8998 )	4 years ago
ulferts	272176ddda	bump rubocop	4 years ago
Oliver Günther	e6aaeb2ec2	Disable positive? check in rubocop [ci skip]	4 years ago
ulferts	76854638f5	use rubocop from channel for codeclimate	5 years ago
ulferts	a8a203bc31	bind rubocop to 2.5 again as codeclimate has rubocop 0.52	5 years ago
ulferts	daf160addd	no rubocop_todo	5 years ago
ulferts	d125242deb	update rubocop.yml	5 years ago
ulferts	3faaa7028e	remove duplicate rubocop rule	5 years ago
Oliver Günther	151c38626a	Add migration to clean invalid custom_values	5 years ago
Oliver Günther	9a7ff60976	Replace jquery-autocomplete in wp-relations-autocomplete	6 years ago
Oliver Günther	7fc6e7f914	Prepare for core integration	6 years ago
Oliver Günther	7dbecdcf79	Prepare for core integration	6 years ago
Oliver Günther	ad43a7ea95	Prepare for core integration	6 years ago

1 2

66 Commits (564393560beb65ff877b15fa382b18cbc6286ec7)