openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	0761a98b4c	exclude deleted work packages from digest rendering	3 years ago
Oliver Günther	123fc5758c	[38092] Add fallback reason in mailer https://community.openproject.org/work_packages/38092	3 years ago
luzpaz	2ae53bd252	Fix typos in user facing and non-user facing code (#9497 ) * Fix typos in user facing and non-user facing code Found via `codespell -q 3 -S ./config/locales -L ba,nd,parms,sur,varius` * Fix strings in specs	3 years ago
Oliver Günther	bcdc67cd52	[38078] Fix bulk controller not setting send_notifications With the bulk controller not setting notifications, the default is send_notification = true. All subsequent calls to disable notification sending is ignored, so the call in the WorkPackages::UpdateService is ignored. This PR also renames the "Send emails" option to the more appropriate term now. https://community.openproject.org/work_packages/38078	3 years ago
Oliver Günther	c683af254c	[38066] Use the services to update the user https://community.openproject.org/wp/38066	3 years ago
Oliver Günther	7382822e12	[38085] Also send ATTACHMENT_CREATED on direct upload completed https://community.openproject.org/wp/38085	3 years ago
ulferts	2b43c550b3	avoid creating a journal for a to be destroyed work package Work packages with attachments where saved once for every attachment upon destruction. This led to custom fields being rewritten and a journal being created. Those created records where removed right away, since the work package was destroyed so the problem was only perceivable as poor performance. On the other hand, we had reports of users not being able to destroy work packages. While it is pure speculation that this change fixes the problem it at least makes deadlocks less likely since journaling is performed with a mutex and that no longer takes place now. The `after_remove` callback is no longer necessary as journaling is triggered in the services now.	3 years ago
ulferts	938c6e5619	exclude full text columns from attachment model Currently, the fulltext columns `fulltext`, `fulltext_tsv` and `file_tsv` are never displayed in the application. As such they are currently purely used internally when the are involved in the fulltext search. Having them included in the AR model Attachment will lead to a lot of data being loaded. Such a column can contain megabytes of data. This is costly twice: when fetching the data from the database and when instantiating the model in ruby. As the data is never displayed, they can be ignored for now using `ignored_columns`. This changes the SQL for fetching from `SELECT "attachments"."*" ...` to `SELECT "attachments"."id", "attachments"."file" ...` (without the excluded columns) The alternative would have been to create a new table for the fulltext information and this might still be an option once the requirements on the columns increase. For now, this change is simpler.	3 years ago
Benjamin Bädorf	87cd178270	Fixed more linting errors (#9452 ) * Fixed more linting errors * Update the selector of the focus directive to opFocus * Update the selector and BEM class of the focus-within directive * More linting fixes * Remove unused directives, merge focus and autofocus directive, remove now empty a11y module * Some small fixes * Fix ReorderDeltaBuilder * Fix failing specs, linting * Fix a couple of linting errors * Reenable linting rules for unsafe any * Reset broken code, update some html coding style	3 years ago
Henriette Darge	76a6cf3208	Allow editing list CustomFields even if they do not allow MultiValues (#9474 )	3 years ago
Oliver Günther	f7c2644f53	Fix auth source login when user changes	3 years ago
Oliver Günther	b75fbcfc4e	Render error pages using our own templates (#9455 )	3 years ago
Oliver Günther	b7696a6c5c	[37553] Make user run through authentication stages after header SSO (#9458 ) https://community.openproject.org/wp/37553	3 years ago
Oliver Günther	16d1f57857	Deprecation warning for < postgres13 in admin/info (#9473 ) https://community.openproject.org/work_packages/38047	3 years ago
Behrokh Satarnejad	133c0136c1	Using BEM methodology to change the styles (#9401 ) * change some of stylesheets * change the style naming * resolve the error * improving the previous commit with Ben's comments * improve the styles of breadcrumb * change the stylesheet related to status button * refactoring css stylesheets of wp single card * fixing the errors of PR, correct selector * change some of stylesheets * change the style naming * resolve the error * improving the previous commit with Ben's comments * improve the styles of breadcrumb * change the stylesheet related to status button * refactoring css stylesheets of wp single card * fixing the errors of PR, correct selector * resolve the error on PR related to boards onboarding * wp relation and list view style changes * resolve the errors of previous commit * fix error in selecting wp relation * fix the errors of wp relations ruby tests * change the stylesheets of autocompleter and wp calendar * change the style of grid page * Some improvements to the BEM styling * Prefix draggable-autocomplete BEM block with op- * Fix spec selector * Fix spec selector Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	3 years ago
Oliver Günther	843779c483	[38017] Don't remove group users if no replacement provided https://community.openproject.org/wp/38017	3 years ago
ulferts	75bb809ad6	Feature/1899 send daily email summaries (#9430 ) * email digests * use time for notification digest setting * safeguard against empty digest	3 years ago
Henriette Darge	2ee3a06c63	* Remove dead links (#9453 ) * Use .org website address consistently * Remove community address as homepage as it does not really offer any value	3 years ago
Oliver Günther	e9d7c374cc	[37868] Whitelist for attachment mime types and extensions on upload (#9431 ) * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract	3 years ago
ulferts	0666c89828	Feature/35708 wp typeahead filter (#9426 ) * breakup wp resource specs into separate files * introduce and employ typeahead filter on work packages Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
Oliver Günther	980447ab51	Prevent backtracking regexp in MessagesController (#9447 )	3 years ago
Oliver Günther	8365f575cb	Prevent backtracking regexp in MessagesController (#9447 )	3 years ago
Oliver Günther	c35c81d60b	[32867] Generalize me associated action for custom fields (#9443 ) https://community.openproject.org/work_packages/32867	3 years ago
Henriette Darge	d34b4517d9	[37939] Pagination style is lost (#9433 ) * Apply BEM styling rules for paginations && fix styling for ruby-created paginations * Add class for actual clickable element in the pagination * Introduce modifiers for positioning items at the start or end	3 years ago
bsatarnejad	8bf215678b	change styles of members widget	3 years ago
ulferts	8be49d1c62	only store notification resons for in app (#9419 ) We currently only diplay it for in app. This might change once digests are introduced	3 years ago
Oliver Günther	a8652d7483	Remove length restriction on CustomField#name	3 years ago
Benjamin Bädorf	0981c65582	Merge/release 11.3 (#9427 ) * Feature/37472 dynamic forms v2 flat resources links model (#9332) * Flat resources/_links model * Refactor: moving model formatting to FormsService * unit tests fixes * ValidateForm$ with schema * Adapt PrincipalComponent to flat form model * Default schema ti empty object * Avoid circular dependency * Update headlines for Board types [ci skip] * update locales from crowdin [ci skip] * update locales from crowdin [ci skip] * Fix how we gather and derive sampling traces for sentry (#9395) We previously defined a fixed tracing rate AND a sampling tracer in the backend, which result in everything to be traced regardless of the actual rate. We now define a base rate for certain requests, so that we can exclude health checks and other things. The configuration is now a factor (0 = off, default) (1 = use suggested rates), any other value x (x multiplied by suggested rates) * update locales from crowdin [ci skip] * update locales from crowdin [ci skip] * update locales from crowdin [ci skip] * update locales from crowdin [ci skip] * update locales from crowdin [ci skip] * correct expected links to docs Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: Birthe <b.lindenthal@openproject.com> Co-authored-by: OpenProject Actions CI <operations+ci@openproject.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	3 years ago
Markus Kahl	31588fa25a	addressed review (including code climate) remarks	3 years ago
Markus Kahl	1a078ea667	/api/docs finished - made into separate, lazy loaded js/css bundle in angular - added setting allowing to disable API docs - added spec lint workflow - fixed styling (line-height) - renamed/restructured	3 years ago
Oliver Günther	d2ce834e23	[37866] Add attachment_created event and webhook (#9418 ) * [37866] Add attachment_created event and webhook * Remove other usages of direct attachment creation * Add attachment webhook spec * Fix other webhook specs * Fix attachment adding in mail_handler * Don't set content_type outside attachment#file= * Fix unrelated spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	3 years ago
ulferts	f8b28b300c	treat nil value as non false The default BooleanEquals filter treats null same as false. Because of that, notifications that are not meant for ian were displayed. The BooleanEqualsStrict filter only filters for false as expected so that the notifications are not displayed.	3 years ago
ulferts	46152c7526	use service to have notification settings created The `Users::CreateService` correctly creates the notification settings. It is now used in the users controller	3 years ago
Markus Kahl	2ac1497c61	OpenAPI 3.0 spec, swagger UI right now the spec is generated from the existing api blueprint docs	3 years ago
ulferts	261b0fa5c3	add bulk read/unread enpoint for notifications	3 years ago
Oliver Günther	9636a08988	[26688] In-app notifications (#9399 ) * Add bell icon to icon font * Add in app notification in top menu * Add fullscreen modal * Add notification modal and items * Style items * Toggle details of item * Mark all read * Add no results box * wip specification for event api * Add events table, query and index * Send out events from WP notification mailer job There we have the recipients present * Add cleanup job for older events with a setting * Hide bell notification when not logged * Add specs for events API index/show * Fix setting yml key * remove pry in event creation * Fix before hook in events API to after_validation * Fix polymorphic association raising exception for aggregated journals * Fix typo in read_ian * Fix yml entry for mentioned * Add read/unread post actions to event API and add specs * Wire up API to frontend * Fix order on events * Switch to unread in notification * Add event query * rename WPEventService * route wp mail sending over events * rename spec methods * author becomes watcher * correct message call signature * rename events to notifications * renname parameter to reflect notification nature * create author watcher for existing work packages * Merge unreadCount from store * Take a stab at polymorphic representers * Fix link generation in polymorphic resources For journals, no title is being generated however * Fix frontend model for context * Use timer for polling * add notification_setting data layer * Fix show resource spec * Fix duplicate class in notification bell item * Add minimal feature spec for notification * API for notification settings * Persist notifications * adapt work package notification creation to notification settings * extract notified_on_all * consolidate wp#recipients * concentrate wp notification in journal service * simplify methods * Remove unused patch endpoint * Add specs for rendering and parsing notification settings * Contract spec * Update service spec * adapt specs * Angular notifications frontend commit `e29dced646` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 17:34:50 2021 +0200 Create Akita store and query for notification settings commit `1a45c26c1a` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 11:09:25 2021 +0200 Remove tabs from notificaition settings page commit `0ea21e90c1` Author: Oliver Günther <mail@oliverguenther.de> Date: Sun Jun 20 21:55:48 2021 +0200 WIP in app settings * migrate notification data * add project visible filter to project query * Add inline-create and table display grouped by project * Add notifications under admin/users * Remove notifications partial * Rename notififcations store to user preferences store * Add setting for self_notified and hook that up to the backend * Add aria-label to table checkboxes * Restyle table and toolbar * replace remains of mail_notifications attribute * initialize notification settings for new user * adapt my_preferences references * reenable no self notified for documents * adapt specs * Avoid has_many :notifcation_settings Rails magically autosaves the user's preferences when the user gets saved, which somehow also tries to save the notfifications even when unchanged. This breaks some specs such as the avatar upload spec. As we can't update the assocation through rails anyway, just delegate to the user for reading instead. * Restore update method of notification settings * Restore update spec * fix spec syntax * lint scss * linting * Fix content_tag for bell icon * Add feature specs for notification settings * Disable ContentTag cop * use visible filter to get projects for notification The visible filter will reduce the project list down to the set of projects visible to the user provided as a parameter. This includes public projects. * test for actual mail sending * adapt me resource path this.apiV3Service.users.me changed its type in `0d6c0b6bc7` * Implement changed migration * Linting * Add actor to notification representer * Fix factory creating a duplicate WP journal * Add work packages loading and journal details to notification entry component * IAN basic facets, keep and expanded states. * Fix notification bell spec * Render body separately and add auto updating relative time * Add fixedTime title * Add actor to notification entry * Fix clicking links on work package and project * Tiny styling changes on entry row * Disable count in notification if larger than 99 (wont fit) * Introduce virtual scrolling to entry table * allow delaying & prevent mail sending if ain read Introduces a setting to delay mail sending after a journal aggregation time has expired. That way, users can confirm a notification in app. If they do before the delay expires, no mail is sent out additionally for that user. * consolidate notifications (in&out) into shared admin menu Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
ulferts	2a015eeac3	Feature/journal aggregation on write (#9396 ) * aggregate journals on write - simple implementation * remove references to aggregated journals on read * rewrite existing journals to be aggregated * remove aggregated journal reference * only delete predecessor if it can be aggregated * fix aggregation condition * adapt specs * remove aggregated journal functionality from production code The code is still necessary in a migration for the time being * adapt specs * use polymorphic belongs_to for journal data The association can then be employed for eager loading * eager load for activity rendering	3 years ago
Oliver Günther	99a8b3f140	Fix how we gather and derive sampling traces for sentry (#9395 ) We previously defined a fixed tracing rate AND a sampling tracer in the backend, which result in everything to be traced regardless of the actual rate. We now define a base rate for certain requests, so that we can exclude health checks and other things. The configuration is now a factor (0 = off, default) (1 = use suggested rates), any other value x (x multiplied by suggested rates)	3 years ago
Oliver Günther	a28e1b916e	Fix link to disable-password-login to docs	3 years ago
ulferts	9e66604dec	allow project identifier to begin with numbers (#9377 )	3 years ago
Aleix Suau	7e2e05c88f	Feature/36390 code structure (#9319 ) * core/shared/features in progress * shared/components in progress * Fix rebase errors * core: added admin + apiv3 * shared: attachments + attirbute-help-text * core: OpenprojectAugmentingModule * shared: OpenprojectAutocompleterModule * shared: Autocompleter * feature: backlog * feature: bim * feature: boards * shared: calendar * core: userModule * feature: dashboards * shared: editor * shared: fields * shared: focus * core: globalsearch * shared: grid * shared: grid fix * core: hal * shared: icon * feature: invite user modal * feature: job status * shared: members autocomplete * shared: modal * feature: my page * feature: overview * shared: principal * feature: projects * feature: repoting * core: routing * shared: time entries * shared: OpenprojectWorkPackageGraphsModule * feature: workpackages * core: active window * shared: autofocus * features: wp: back-button * core: browser * shared: collapseible section * core: config * shared: copy-to-clipboard * shared: date-time * shared: helpers: drag-and-drop * shared: draggable autocompleter * shared: dynamic bootstrapper * shared: dynamic forms * features: wp: edit actions bar * shared: EditableToolbarTitleComponent * core: BannersService * shared: OpFormFieldComponent * shared: hide section * shared: highlight col * core: I18 + Sanitizer * shared: isClickedWithModifier * core: LoadingIndicator * core: Modal Heading * core: Model auth * shared: no results * shared: notifications * shared: datepicker * shared: option-list * core: path helper * shared: persistent toggle * shared: remote field * shared: set click position * shared: slide toggle * shared: tabs * shared: drag-scroll * shared: keyCodes * shared: OPSharedModule * global styles: common * core: * import fixes * shared: Enterprise banner * features: wps: filters * features: home screen * import fixes * core: html * import fixes * core: main-menu * features: home screen * shared: modals * shared: op-context-menu * core + shared: current project * core: schema-cache * shared: table-pagination * features: wps: time-entries * shared: user-link * features: wps * features: wps * features: wps: all wp-* components * core: states * Rename: angular4-modules to app.module * core: expression service * Modules just with plugins * Test fixes * added missing content-tabs.component.sass * Replaced with .op-ckeditor--wrapper * Replaced by .op-ckeditor-source-element * Replaced by the entire wysiwyg_editor.rb with dev version * Replacements by ckeditor-augmented-textarea * Fixes ./spec/support/components/work_packages/table_configuration_modal.rb:106 * Fixes ./modules/reporting/spec/features/update_entries_spec.rb:69 * work_packages renamed to work-packages * TimeEntryChangeset moved to helpers * 'filters' moved to wps/components * 'admin' moved to features * HAL moved to shared * plugins moved to features * plugins moved to features * Test fixes * Unit test fixes * plugin generator into /features/plugins * fix sass rule indentation * Revert "plugins moved to features" This reverts commit `f65ccbfd4b`. * Import fixes * Avoid commiting in linked plugins Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
ulferts	a8c075e258	[#37583 ] Error "Identifier is invalid" (#9373 ) * [#37583] Error "Identifier is invalid" Happens when creating a project that starts with a digit or a hypen. The functionality is added by extending acts_as_url to support a custom_rule lambda. https://community.openproject.org/work_packages/37583 * handle empty base_url in acts_as_url custom_rule	3 years ago
Markus Kahl	038b6f5da2	extracted pg_dump command into method so it can be patched if necessary	4 years ago
Oliver Günther	fc090ac024	[37136] Disable delete button and check for deletion (#9338 ) https://community.openproject.org/wp/37136	4 years ago
ulferts	20a9f91a22	ensure project status is saved (#9325 ) aweseome_nested_set, used for maintaining the project hierarchy, reloads the project after saving. Any change to an associated model, e.g. the status, is lost upon reloading. Thus, saving of the status needs to take place before saving the project. This is safe to do since it is carried out in a transaction and all the validations are run for the status as well. https://community.openproject.org/work_packages/37464	4 years ago
Wieland Lindenthal	44d57d36c6	Fix #37136 : Restrict deletion of placeholder users (#9294 )	4 years ago
Markus Kahl	2bf74725b2	fixed password confirmation during token reset (#9314 )	4 years ago
ulferts	6cda6ad4fd	enforces dependent project modules being active (#9311 ) Project modules, e.g. calendar can define dependencies, e.g. work packages. An error message is now displayed if a user enables a project module without the dependency being active in the project as well. Also fixes a serious bug in the Shared::ServiceContext module. Whenever a failing service result is returned, every change to the database is to be rolled back. This was not true when a model was provided since the changes where carried out within an inner transaction	4 years ago
Oliver Günther	c9a80b8653	[#37299 ] Remove validation for project identifier presence (#9296 ) [OP#37299](https://community.openproject.org/wp/37299)	4 years ago
Oliver Günther	9630b74524	Use format_time to format backup time (#9309 ) https://community.openproject.org/wp/37298	4 years ago

... 3 4 5 6 7 ...

18827 Commits (56e53620cb58f22c823a6ccb4f29a739c095abc2)