300 Commits (57356059af2c41ab9877fbdaa9ece4d7a37a3d8c)

Author	SHA1	Message	Date
ulferts	d1ddd2d5d2	Feature/toggle between hierarchy and group by (#5720) ... * allow toggling between hierarchy and groupBy * fix icon alignment in query settings dropdown * buffer query updates to prevent duplicate backend requests * simplify focus-within delay [ci skip]	7 years ago
ulferts	0c2b544635	Fix/update wp to be in details pane (#5701) ... * observe changes to wp table to update detail view candidate * select row of wp shown in details view [ci skip]	7 years ago
Oliver Günther	50dbf354f7	[25495] Cancel clicks to hrefs with nothing but a hash (#5685) ... Clicking on an unhandled link with `href="#"`, you end up on the homepage. This was observed in 25495 while using the datepicker due to the following problems: 1. The datepicker library we use adds links with a hash href @href="#"@ to each date field in the datepicker 2. The datepicker adds an event that cancels the default handling of these fields 3. When quickly updating the page, the datepicker instance events are unregistered before its actually fully closed 4. The href="#" event bubbles up, and angular handles it. Due to the way our base url works, it routes the URL to @<root>/#@ which results in your going to the homepage. [ci skip]	8 years ago
Oliver Günther	1d0b09fa5f	Merge release/7.1 into dev (#5667) ... * [25580] Remove Settings callbacks from avatar_helper `register_callbacks` will not work if its used to update a class-level variable. We might want to think about removing this entirely, however impermanent-memberships is still using it to update the database after a change. https://community.openproject.com/projects/openproject/work_packages/details/25580 * change toolbar button height (#5664) https://community.openproject.com/projects/openproject/work_packages/255 11/activity [ci skip] * Fix/relations drawing (#5663) * improved drawing of timeline relation lines * Improved relations data flow * Timeline relations: Load relations once the timeline becomes visible * - Fixed SwitchState failing test - Version bump ReactiveStates - cleanup [ci skip] * Set indention of breadcrumb for correct alignment * remove wiki icon for wiki submenu in main menu (#5665) [ci skip] * Add missing class * Fix table hierarchies previous values [ci skip]	8 years ago
Oliver Günther	7758812768	[25387] Refactor query availabe states into separate input states (#5659) ... * Refactor query availabe states into separate input states * Fix tests [ci skip]	8 years ago
Wieland Lindenthal	2ea324e5b5	change toolbar button height (#5664) ... https://community.openproject.com/projects/openproject/work_packages/255 11/activity [ci skip]	8 years ago
Oliver Günther	f82f1ab915	Remove the loadingIndicator only after rendered was pushed	8 years ago
Oliver Günther	831436191a	Only set scope to initialize table/timeline on initial loading	8 years ago
Oliver Günther	9bf3f4d22d	Simplify initialization of query state	8 years ago
ulferts	f4b36edccb	Feature/save zoom in query 7 1 (#5637) ... * Implement timeline zoom level as query enum * Implement query zoom handling in frontend Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query. * Extend feature spec for zoom saving * Refactor URLParamsHelper into TS service * Fix comparison in table query services * Remove reference to allowedValues [ci skip]	8 years ago
Oliver Günther	7d62d846a2	Implement relation columns as secondary render pass	8 years ago
Oliver Günther	b7f8a74937	Introduce derived state for when table query states are ready	8 years ago
ulferts	08e49612e6	Fix/forums pagination (#5623) ... * restructure table pagination to use a controller * split up pagination directive There now is the table-pagination directive which is generic, taking input to communicate with its caller. This is used by the forum. The wp-table-directive is specific for the wp table and relies observers. [ci skip]	8 years ago
Wieland Lindenthal	94a95bfd0c	Align and style back button like other toolbar buttons	8 years ago
Wieland Lindenthal	6f9991e35c	Remove boilerplate of back button and aligning it.	8 years ago
ulferts	3e6fdc8639	Fix/loading indicator on query change (#5617) ... * show loading indicator on query switch * prevent duplicate loading on query change We might want to look into moving the query checksum mgmt to the service layer to avoid scattering around calls to the checksum service but I refrain from doing that in a patch release * code prettification [ci skip]	8 years ago
Oliver Günther	d6b8b92037	Implement query zoom handling in frontend ... Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query.	8 years ago
Oliver Günther	5b5326db4c	[25438] Fix only saving changed column positions (#5608) ... When changing only the positions of the default query columns, the query incorrectly checked only for the permutation of the default columns, not the actual order. Thus the columns were not actually saved in the query. Additionally, the `observeUntilChanged` incorrectly reflects previous values which causes the movement of a column twice to only result in a move by one position. As this was already suggested to remove in https://github.com/opf/openproject/pull/5597, let's resolve this together in this PR. [ci skip]	8 years ago
ulferts	483934e91b	refresh wp list after saving in full screen (#5600) ... [ci skip]	8 years ago
Henriette Dinger	cb9ad7ba17	[25356] Icons in toolbar not aligned correctly (#5568) ... * Icon alignment in toolbar * Styling: newline after comma in CCS selector. No functional change. Just my personal preference. * Extra class for toolbar buttons that are icons only to make them a square. * Improve documentation for generating icon font [ci skip]	8 years ago
Oliver Günther	160d8876c7	Add switch state in query state handling to clarify access to states (#5571) ... [ci skip]	8 years ago
Oliver Günther	42179cee4c	Find element that contains the ui-route attribute ... [ci skip]	8 years ago
Oliver Günther	e46d816e35	Run state change in new digest ... [ci skip]	8 years ago
Oliver Günther	31840cd524	[25345] Pass ui-router state in [data-ui-route] (#5553) ... The query menu items are rendered by rails but should be processed by angular, so the solution was to find clicks on special links marked with a [data-ui-route] attribute and pass the link to $location. 1. This fails on installations with relative URL, since a base tag is set and everything passed to $location will be ASSUMED relative to that base. Passing `/myrelative/work_packages` will result in `/myrelative/myrelative/work_packages` if the base is `/myrelative`. 2. The process of parsing the URL is buggy and may not lead to the correct state. Instead, I suggest to be explicit in what state this element should route to. https://community.openproject.com/projects/openproject/work_packages/25345 [ci skip]	8 years ago
Oliver Günther	61a4481372	[25333] Workaround for height flexbug in Safari 9 (#5550) ... Safari doesn't properly set the height of a flex container, so we need to enforce the height in its child through position absolute. That however requires us to set an explicit width to the non-growing details-view split pane, so there is some selector duplication. [ci skip]	8 years ago
Oliver Günther	075001b813	[25271] Add correct label for fullscreen switch ... [ci skip]	8 years ago
Henriette Dinger	47243764a3	Fix highlighting && Move full screen icon to the right	8 years ago
Jens Ulferts	5284322eef	differentiate work_package/work_packages permission ... The links existing on work_packages are different from those on a work_package. We thus have to treat them differently to avoid one overriding the other	8 years ago
Oliver Günther	32963faab4	Remove throttling and fix double requesting the table results ... Potential fix for #25187	8 years ago
Oliver Günther	d464a01453	Fix fullscreen icon in wp.list.new	8 years ago
Oliver Günther	39a54e2d04	Add new icon for to-/from- fullscreen	8 years ago
Oliver Günther	85209f0759	Move timeline zoom controls to toolbar	8 years ago
Oliver Günther	172992dc12	Restore basic full screen icon	8 years ago
Oliver Günther	f0fdeba279	Remove details to full button	8 years ago
Oliver Günther	01ad38517a	Restore footer content ... [ci skip]	8 years ago
Oliver Günther	bc5b667792	Restore footer layout on left side ... [ci skip]	8 years ago
Oliver Günther	97cc268d01	Fix missing div in toolbar	8 years ago
Oliver Günther	9af98cc27a	Extract timeline into separate components ... [ci skip]	8 years ago
Oliver Günther	a8ef1eedc5	Move inner split view into wp-table	8 years ago
Oliver Günther	442c0a2575	Fix show view ... [ci skip]	8 years ago
Oliver Günther	ec17d9e9e6	Initial timeline layout with dummy timeline	8 years ago
Oliver Günther	347c6e4816	Replace frontend icon-wrapper with op-icon	8 years ago
Wieland Lindenthal	cf41a81104	add drop down menu for wp create screen.	8 years ago
Jens Ulferts	9db817eb78	refactor more menu into dedicated factory	8 years ago
Jens Ulferts	d86d172dee	ui-router for handled link, $window.location for rest ... This e.g. fixes exporting to pdf as the ui router does not handle this link	8 years ago
Oliver Günther	5423b97b97	[25073][25092] More robust refreshing of table upon changes ... Currently, altering the hierarchy of a work package does not properly update the table. For example, removing a parent of w1 that isnt visible in the table causes w1 to refresh in the table (due to cache service), but the entire table isn't refreshed. We cannot refresh the entire table for cache service changes, since that happens quite often in the timeline mode and would cause a peformance impact. On the other hand, we don't have the information on _what_ changed in w1 when we subscribe to the cache service. This PR rather improves on the task of reloading the table after changes to work packages by making two things explicit: 1. A separate state controlling requests to table refreshing instead of a rootScope event 2. A service that orchestrates the state to allow moving to/from full screen to reload the table whenever moving back and requests were made in the full screen.	8 years ago
Oliver Günther	ac643bf02d	Rewrite conditions in subscribe into filters	8 years ago
Oliver Günther	90c6fdfed6	Move comparer and extractor functions into state value classes ... This clears up what the controller has to do and allows us to double check 1. The previous value of the state has changed 2. IF (1) is true, whether the query value for that attribute is changed We need to check the second part additionally since the states may be updated as a result of the query being updated in `wpListService.updateStatesFromQuery` The 'correct' solution here would be to create two input states, and a dependent state that executes resulting actions.	8 years ago
Oliver Günther	4aece22d52	Fix filters not being properly written to their $source	8 years ago
Oliver Günther	4fd0cfc052	Use distinctUntilChanged to check for changes in the query states	8 years ago