77 Commits (585836e0a1e880659c01c6669353b6b453c81e94)

Author	SHA1	Message	Date
ulferts	e2961fba14	replaces reform & custom error handling ... Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models ... Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	0b182f5915	Don't make error v3 specific through their identifier	5 years ago
Oliver Günther	423efa50fe	Avoid naming error warnings on codeclimate due to V2_1	5 years ago
ulferts	e003ad0af7	turn scope and label unwritable	5 years ago
Oliver Günther	27fadc1b60	Provide NotImplemented error message for bitmaps	5 years ago
Oliver Günther	c775dc8031	[29942] Better error messages for permission failures ... [ci skip] https://community.openproject.com/wp/29942	6 years ago
Oliver Günther	e94d64f9d2	Ensure all errors accept an optional message from exception ... And let the code be defined on the class	6 years ago
Oliver Günther	1b5fc32366	Avoid before blocks and raw params access for IDs ... Grape's validation runs after a `before` block so we should avoid using raw params there and instead using `declared(params)` which returns only the validated whitelisted params, much like a permitted params hash.	6 years ago
ulferts	1850622f20	Feature/versions api update (#7299) ... Feature/versions api update [ci skip]	6 years ago
Jens Ulferts	c1853a5cdd	fix expected namespace for groups on assignee and responsible property	6 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	e7de9169f1	Add internal error with message to Fog uploading failures ... [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	bbc7025ea9	state errorenous attribute in API format error	9 years ago
Oliver Günther	2454624fde	Retain partial message for custom field to customizable	9 years ago
Oliver Günther	f03728c156	Retain partial message for custom field to customizable	9 years ago
Jan Sandbrink	f9cb083481	in production handle internal API errors gracefully ... - still allow for useful errors during development - let all own exceptions inherit from StandardError, the thing you should use for own errors...	9 years ago
Jan Sandbrink	1009b0f373	improve error handling for JSON parsing parameters	9 years ago
Jan Sandbrink	bc30b28558	extract attribute name conversion into extra class ... - consider special renaming rules for well known attribute names -> currently covering wp attributes and createdAt, updatedAt	9 years ago
Jan Sandbrink	b374ebdd7f	store messages alongside error symbols ... - allows to skip translation part in ErrorBase - allows to have correct translations containing placeholder values	9 years ago
Jan Sandbrink	a9d28d3fb6	fix some errors uncovered by specs ... - bad default values - missing attribute sanitation - style	9 years ago
Jan Sandbrink	662f99808a	apply basic attribute name transformations ... those are the ones that were present earlier already. They do not cover the hard cases, where the backend has completely different names form the API	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation ... - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Jan Sandbrink	c7207f0330	resort errors in WP contracts ... - use attributes as keys and error messages as value - AM errors immediately turn message symbols into translated strings, this makes them hardly processable -> patch some helper methods onto AM::Errors and everything is fine forever	9 years ago
Jan Sandbrink	025f3f589e	remove side effect from Validation.create ... I just don't know what the original author thought...	9 years ago
Jan Sandbrink	0d31367a94	specify identifier for parse error	10 years ago
Markus Kahl	173fc83ec0	refactored huge switch; fixed null id. in dev mode	10 years ago
Jan Sandbrink	7d443154b3	parse attachment metadata using a representer ... - adding general error handling for parse errors - changing the default error message for parse errors, which was very form specific before	10 years ago
Jan Sandbrink	1e136a15e0	return ResourceTypeMismatch for wrong resources ... - this is according to new specification changes - I have no clue why the initial author did this "wrap into a validation error" business	10 years ago
Markus Kahl	70fe41cb53	use separate error code when unauthenticated ... also distinct error messages for missing or wrong credentials	10 years ago
Alexander Bach	e4c6fc4d19	Generalized localized string access	10 years ago
Alexander Bach	0805e94b37	Hack around dubious error usage	10 years ago
Alexander Bach	8de33f0d1d	Adjusted error handling	10 years ago
Jan Sandbrink	4f9e93526e	avoid variable shadowing ... though unproblematic in this case	10 years ago
Jan Sandbrink	36bb955f7c	add custom value errors to customizable ... - allows to relate error messages to their custom field - allows to use errors.full_message correctly for custom values - might break specs... we will see that soon	10 years ago
Jan Sandbrink	28e0ec21c0	use variable names	10 years ago
Jan Sandbrink	e1948206fa	extract method into ResourceLinkParser ... - similar code was already used in two different places - now the error message makes sense for both occurences	10 years ago
Jan Sandbrink	53b9f7738f	enable patching of linked properties	10 years ago
Alexander Bach	c60952a0c2	Use localized string if applicable	10 years ago
Jan Sandbrink	3b45954314	HTTP 415 is even more apropriate than HTTP 400	10 years ago
Alexander Bach	409073f7e3	Generalized 404 error message	10 years ago
Jan Sandbrink	ac9cd95aab	styling	10 years ago
Jan Sandbrink	8ccbf8c247	allow PATCHing start and due date ... - adding new errors - adding more tests - extending the specification for error conditions	10 years ago
Oliver Günther	a112291396	apiv3: User (Un-)Locking functionality ... This commit implements the proposed user locking/unlocking functionality in https://github.com/opf/openproject/pull/2401. The APIv3 is extended with a resource ``/user/:id/lock`` with the following properties: * ``POST /lock``: Set the lock of user(:id), if its account status is 'active'. * ``DELETE /lock``: Remove an active lock of user(:id), if its account status is 'locked'. This commit also implements the following changes to ``UserRepresenter``: * Replaced the integer status field with the textual status name (i.e., 'active') * Added two entries to *_links* for admin users: ``lock``, ``unlock``.	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Hagen Schink	7eb2085d69	Improve code readability	10 years ago
Hagen Schink	1f3423c787	Do not prepend error key for custom error messages	10 years ago
Hagen Schink	1c6a306671	Move error aggregation to validation error class	10 years ago