openproject

Commit Graph

Author	SHA1	Message	Date
Alex Coles	2d9cfd97f4	Remove deprecated Relation#all in controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	b2790b8db1	Migrate deprecated .update_all with conditions Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	424889897a	Migrate AR finder/query methods in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	d3ceffddfc	actually allow the status to be set while moving apparently the status_id param was set to expect an array of values while being moved in this commit: `d7f399ab8d` Probably because the spec started to expect that when it was moved to be an RSpec test. I am not sure if this was ever a valid thing outside the tests...	10 years ago
Jan Sandbrink	d59b54a63c	use more clear scopes for autocompletion lets see if that really makes stuff more understandable... I (personally) found the old definition of "all" to be too narrow. Now there is: scope == "all": I want to search over all WPs scope == "relatable": I want to search over all WPs that are relatable to WPs in the given project (via project_id) no scope: If I specified a project search over the WPs of that one, otherwise search everywhere (like "all")	10 years ago
Jens Ulferts	9b93316283	explicitly expecting a setting	10 years ago
Alex Coles	077e42ba06	Make VersionsController#update use PATCH Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	2640852fe3	Fix MembersController#autocomplete_for_member routing * make routing less convoluted (as in `18835799`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5841ae9e41	Fix MyController spec broken in `0a0f6c7b` Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	18835799dd	Make ProjectsController#types use PATCH * make routing less convoluted: switch to a regular member route. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	516c9a5f3e	move mock method out of production code	10 years ago
Jan Sandbrink	bc3437c3b0	replace create_uploaded_file in specs mock_uploaded_file creates a Rack::Test::UploadedFile, which should behave equally to a real uploaded file, but is also treated correctly by Rack::Test	10 years ago
Alex Coles	e6cf754b53	Fix CopyProjectsController spec broken in `0c56b72d` Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	d060e654a5	Use vanilla Rails validations for CustomField#name Globalize should support regular Rails validations. Additionally `validate_name` was no longer working as expected, possibly due to changes in `CustomField::Translation` lifecycle. * Do not test translation implementation details in CustomFieldController spec. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e49a3c0deb	Update HTML attr order in VersionsController spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	9d641a30f6	Address styling issues	10 years ago
Alexander Bach	a670032b83	Covered #includes_for_columns in tests	10 years ago
Markus Kahl	ee4d977c86	another logout back URL spec for good measure	10 years ago
Alex Coles	2efd6f4e45	Move legacy specs under spec/legacy Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	0d9e465108	Replace deprecated shoulda #set_the_flash in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Markus Kahl	c3fa89e5db	disable password choice config	10 years ago
Jens Ulferts	b37ea687e2	showing error messages on scm updates	10 years ago
Jens Ulferts	fce72938e3	prevent path traversal via filesystem scm Setting up a filesystem scm now requires to specify a whitelist via the configuration	10 years ago
Alex Coles	fda43ac304	Replace VersionsController#create RJS with jQuery Matches `CategoriesController#create` implementation: see `4cc9aaf8`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	07d4ea4edd	Fix version select style on wp form inline create Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ebbc9e3d7d	Prefer #not_to over #to_not in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	fed972eefa	Mark broken QueriesController policy spec pending Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	3785fdc9ed	Use #describe, #context with String arg not symbol The semantics of `describe` have changed in RSpec 3: passing a symbol rather than a string will change the value of the described object. See discussion here: https://github.com/rspec/rspec-core/issues/1114 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	944b89d83e	Convert specs to RSpec 3.2.0 syntax with Transpec This conversion is done by Transpec 3.0.7 with the following command: transpec -f * 34 conversions from: it { should ... } to: it { is_expected.to ... } * 14 conversions from: obj.stub_chain(:message1, :message2) to: allow(obj).to receive_message_chain(:message1, :message2) * 7 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: be_true to: be_truthy * 3 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: failure_message_for_should { } to: failure_message { } * 2 conversions from: failure_message_for_should_not { } to: failure_message_when_negated { } * 1 conversion from: Klass.any_instance.stub(:message => value) to: allow_any_instance_of(Klass).to receive_messages(:message => value) * 1 conversion from: be_false to: be_falsey * 1 conversion from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: stub('something') to: double('something') * 1 addition of: RSpec.configure { \|c\| c.infer_spec_type_from_file_location! } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Markus Kahl	85e91372a1	more comments	10 years ago
Markus Kahl	de309f0eee	polish	10 years ago
Markus Kahl	104b70cc62	work package notification mail specs	10 years ago
Jan Sandbrink	5d63732d9f	fix broken specs for CF controller - did expect the wrong things - did send the wrong things -> tests pass tough they shouldn't	10 years ago
Florian Kraft	d585bafbf6	fix timelog controller spec Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Jens Ulferts	5e2e44ee70	fix previewing work package journal notes	10 years ago
Jens Ulferts	f0933aac12	adapt spec to changed dom	10 years ago
Florian Kraft	00c257541c	move integration test to scenario	10 years ago
Florian Kraft	af2230e20d	fix project associations test	10 years ago
Florian Kraft	1a2ea133f2	fix tests for wiki and permitted params	10 years ago
Jens Ulferts	04554b5fda	fix work package controller spec	10 years ago
Florian Kraft	22853c8b46	Fix the coding style via rubocop	10 years ago
Florian Kraft	cb2f3f30d6	Fix error where anyone could read the diff of a WP With this fix it is no longer possible to view a description diff without the necessary permissions. The error was reported by Jan Sandbrink in https://community.openproject.org/work_packages/16974.	10 years ago
Florian Kraft	9f82ba85eb	fix styling by using rubocop -a	10 years ago
Florian Kraft	59fc511c7d	fix positioning of arguments for hound	10 years ago
Florian Kraft	f17a7c608e	fix a project nil call on querying visibility this fixes an internal error by checking a connected project first before calling visible? on it. This should fix the internal error reported by Nadejda Parpulova in https://community.openproject.org/work_packages/18460	10 years ago
Markus Kahl	4411d172c8	fixed spec	10 years ago
Markus Kahl	0273925a2f	removed obsolete and spec breaking statement...	10 years ago
Markus Kahl	4f46f6ae2e	it's not a good idea to remount the uploader on Attachment	10 years ago

1 2 3 4 5 ...

780 Commits (59b05568e9b16e8a33b41e1b9ae7a9aa6ccf696a)