604 Commits (59eac23347cdf964cda43843a05d062f8fc03a15)

Author	SHA1	Message	Date
Oliver Günther	e88deb8556	Fix errors when editing comments ... This addressed an invalid event handler that causes a TypeError within jQuery and corrects a scoping error that leads to comments being updated with their original/unchanged texts. Relevant work package: https://community.openproject.org/work_packages/21578	9 years ago
Jens Ulferts	4bfc4cc8b2	sort versions case insensitive	9 years ago
Oliver Günther	78abdc0776	Use promise in work-package-new-controller	9 years ago
Oliver Günther	d5a3b21049	Scroll to element only when visible ... Introduces a simple helper plugin to determine whether an element is `visible()`.	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	7f602664fc	Allow focussing an element after work package has been updated ... This commit allows comments or fields to specify a callback after the work package has been updated. This is currently used to scroll to the element (such as the inserted comment), whenever the work package has loaded.	9 years ago
Oliver Günther	9bd4e06d29	Use promises in submitFields methods to defer updating ... As submitting comments and fields in one go requires work packages to be submitted first, we can use promises to ease the processing of each and abort early, e.g., when the WP couldn't be updated, we don't want to submit the comment.	9 years ago
Oliver Günther	d1a1020097	Workaround for focus event on user activity ... It seems that the user activity doesn't correctly handle blur events. I do not know why, but to provide a workaround, I've forced setting the focus for the quote and edit buttons.	9 years ago
Oliver Günther	8da4ac0d63	Restore empty description submit	9 years ago
Oliver Günther	c3589353cb	Scroll to textarea controls when editing and space available	9 years ago
Oliver Günther	7cd7697fab	Replace autogrow with angular-elastic ... angular-elastic provides us with an option to always insert an additional newline to provide smoother animations. This also changes animations to CSS rather than `jQuery.animate`.	9 years ago
Henriette Dinger	27c60cf667	Incorporate review feedback ... * Notification when comment is created * Better binding to editing comments * Quote with inserted text fixed	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Oliver Günther	5732eee3d3	Propagate and distribute field and comment submits in WP Field Service ... This commit allows parallel saving of comments and fields, however this currently results in a conflicting modification due to two saves with thes same lock version.	9 years ago
Oliver Günther	51509e6b34	Editing of comments with in-place button styles and preview ... This commit changes the comment edit and cancel buttons to reflect the in-place editing style. Also allows previewing of edited comments and also shows a notification-box when comments are edited.	9 years ago
Oliver Günther	0883cf9834	Replace exclusive-edit with transcluded comment directive ... This commit removes the somewhat superfluous exlusiveEditController in favor of event-based passing of quoted text to the correct comment field. The comment directive now decides for itself whether it wants to be placed above or below the activities and uses transclusion for that purpose. Editing comments is now no longer exlusive, but that shouldn't be necessary anyway.	9 years ago
Oliver Günther	0aed8bb310	Test for comment input	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications ... This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Henriette Dinger	01d47ea851	Editable comment field ... This provides the basic functionality to deliver a comment field in the in-place editing style. Adds the `autogrow` plugin This still breaks a number of features currently, such as formatted previewing.	9 years ago
Jens Ulferts	c26773e5f8	split method to avoid boolean flag	9 years ago
Jens Ulferts	52b1f75d5c	remove no longer required attachment directives	9 years ago
Jens Ulferts	2d081b97fb	filter directories before uploading ... Uploading directories is not possible. When dragging a directory to the dropzone, the direcory is flattened so that the files in the directory will be accepted, but the directory itself is ignored.	9 years ago
Alexander Bach	4031a1b802	Remove copy pasta 🍝	9 years ago
Alexander Bach	7a79475f8b	Hush the hound	9 years ago
Oliver Günther	528e2f92e2	Load preselected work package when required	9 years ago
Alexander Bach	c0c726cc15	Reset WP id for details pane display	9 years ago
Oliver Günther	14e74596a3	Allow multiple toolbars to exist, extend toolbar functionality ... Previously, toolbars were thought to be unique on a page and thus identified by id. As repository now contains multiple, this was changed to class-based selectors. This commit also adds functionality in toolbars for: * Including select2 fields (proper scaling). To avoid too small selects, toolbar select2 fields are at least 150px wide * Including inline labels in toolbars * Prepended and appended inputs * Icon-only icons (they require font-size changes and a small offset)	9 years ago
Jan Sandbrink	5de0f15898	Correctly link activities ... - they might not be embedded - create an endpoint for activities - document it properly - adapt angular client	9 years ago
Jens Ulferts	27f05acbc7	allow keyboard access to watcher delete	9 years ago
Jens Ulferts	adb27e589e	open ui-select upon watcher adding clicked	9 years ago
Jens Ulferts	ad3dd7f27d	allow keyboard access for attachment deletion	9 years ago
Florian Kraft	bf33466964	use a several parts from inplace edit to change add watcher workflow ... Watchers can now be added like assignees. The component now has its own implementation of the trigger component, based on edit and display pane of the work package form. Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	d9f67f6266	insert translations ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	07058738a1	handle injections to watchers service properly and add tests ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	64daddf767	remove dead code and provide helpers for the array sets ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	64ba83a718	make watchers removable ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	f47418de07	provide a method of adding watchers ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	6025a1b0e5	add a lookup directive ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	3ff36d9247	prepare the directives and load both available and watching users ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	0e3dc2c14c	initial splitoff of watchers into separate service ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	f4b820553a	allows for creating error notifications with only an error message	9 years ago
Jens Ulferts	aadf639e68	remove helper method no longer needed	9 years ago
Florian Kraft	b3553b0121	remove left over console.log	9 years ago
Florian Kraft	728efb6372	check for the existance of files in a work package ... This will check for existing files first. It will also cache the initial call and force reload only on demand Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	631507a6ea	cleanup injections ... The injections referenced are no longer in use.	9 years ago
Jens Ulferts	c996cca696	misc styling fixes	9 years ago
Jens Ulferts	0e9efb5222	replaces ApiHelper.handleError by ApiNotificationsService	9 years ago
Jens Ulferts	bff5374075	separate NotificationsService and ApiHelper	9 years ago
Jens Ulferts	2862fbfa1c	replace flash-message directive by NotificationsService ... The NotificationsService renders the flash-message directive irrelevant and it additionally displays the notification much nicer than the directive. Additionally, an ApiNotificationsService is introduced that is able to cover error formats provided by the experimental api-	9 years ago
Jens Ulferts	58565e11c3	revamp flash directive to transmit to NotificationsHelper ... This is only a temporary reworking as it is now wrong to use a directive	9 years ago