287 Commits (5a7acefaa36df3a7b425b8313edb6d75450fdeff)

Author	SHA1	Message	Date
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	51509e6b34	Editing of comments with in-place button styles and preview ... This commit changes the comment edit and cancel buttons to reflect the in-place editing style. Also allows previewing of edited comments and also shows a notification-box when comments are edited.	9 years ago
Oliver Günther	0883cf9834	Replace exclusive-edit with transcluded comment directive ... This commit removes the somewhat superfluous exlusiveEditController in favor of event-based passing of quoted text to the correct comment field. The comment directive now decides for itself whether it wants to be placed above or below the activities and uses transclusion for that purpose. Editing comments is now no longer exlusive, but that shouldn't be necessary anyway.	9 years ago
Oliver Günther	0aed8bb310	Test for comment input	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications ... This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Jens Ulferts	c26773e5f8	split method to avoid boolean flag	9 years ago
Jens Ulferts	52b1f75d5c	remove no longer required attachment directives	9 years ago
Jens Ulferts	2d081b97fb	filter directories before uploading ... Uploading directories is not possible. When dragging a directory to the dropzone, the direcory is flattened so that the files in the directory will be accepted, but the directory itself is ignored.	9 years ago
Oliver Günther	14e74596a3	Allow multiple toolbars to exist, extend toolbar functionality ... Previously, toolbars were thought to be unique on a page and thus identified by id. As repository now contains multiple, this was changed to class-based selectors. This commit also adds functionality in toolbars for: * Including select2 fields (proper scaling). To avoid too small selects, toolbar select2 fields are at least 150px wide * Including inline labels in toolbars * Prepended and appended inputs * Icon-only icons (they require font-size changes and a small offset)	9 years ago
Jan Sandbrink	b41e96a8af	Adapt frontend-specs to new embedding ... just realized that those are 12k lines of C&P activities. I reduced the amount to a less insane (but still not quite sane) ~1k lines... It might be a better idea to automatically generate those mocks. This would be: - more consistent - more up-to-date with real data - less error-prone (b.c. less copypasta)	9 years ago
Florian Kraft	d8bd557743	remove focus statement ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	cb0c85a795	add some basic tests ... These tests are mostly concerned with the data layer and expected and actual responses from the APIv3. Also, a controller skeleton test is included Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	adb0e1802c	remove old controller tests for watchers tab ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	3e25adfcbb	do not only tests the WatchersService ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	07058738a1	handle injections to watchers service properly and add tests ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Henriette Dinger	ca02263058	updated icon font, fixed broken specs and design bugs	9 years ago
Henriette Dinger	e895b1eb99	replaced the picture with icons in TimeSheets, Workflow/Summary	9 years ago
Alexander Bach	78efda7ee8	Remove project homepage field from all the specs	9 years ago
Jens Ulferts	f4b820553a	allows for creating error notifications with only an error message	9 years ago
Jens Ulferts	aadf639e68	remove helper method no longer needed	9 years ago
Florian Kraft	0d093e45ad	do not use chrome ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	1f1e02f5ab	clean up testing via protractor ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	6658334bb3	specs for api-notifications-service	9 years ago
Jens Ulferts	e691fe0050	adapt karama tests	9 years ago
Oliver Günther	126902447c	Fix protractor exception in timeout'ed expect ... The setTimeout expect causes the spec to fire reproducably in other contexts and raises an exception, blocking the whole test run. Caused failures in jobs: * https://travis-ci.org/opf/openproject/jobs/76531345 * https://travis-ci.org/opf/openproject/jobs/76482755 * https://travis-ci.org/opf/openproject/jobs/76470180 * ...	9 years ago
Jens Ulferts	962f7e7328	remove iit statement	9 years ago
Oliver Günther	ae4679c67b	Remove revision unit test example that requires compile	9 years ago
Oliver Günther	3c489a9cc8	Revision integration tests	9 years ago
Florian Kraft	2fe9e49b47	correct test for new error notification ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	305910ba7a	hoping for test stability	9 years ago
Jens Ulferts	4a7c64a0bb	finally disabling unreliable protractor spec	9 years ago
Jens Ulferts	40a297d08e	adapt protractor spec to avoid flicker	9 years ago
Oliver Günther	9d0e4f0738	Add unit test for revision activity	9 years ago
Jens Ulferts	8d19fec246	disabling test failing on travis	9 years ago
Jens Ulferts	f6dfcda01a	provide the configuration upon compile ... This hopes to fix a test failure only occuring on travis.	9 years ago
Jens Ulferts	af14a4509b	reduce duplication in directive test	9 years ago
Jan Sandbrink	f08eb09627	fix specs	9 years ago
Jens Ulferts	d3b5e3ee8f	unit testing inplace editor dropdown directive	9 years ago
Jan Sandbrink	c42e41702d	add spec for hiding details on first journal	9 years ago
Jens Ulferts	f62661bbc2	prevent protractor flicker	9 years ago
Jens Ulferts	7b38c6eefb	attempt to fix protractor flicker	9 years ago
Jens Ulferts	ebbbf9d867	next attempt to fix protractor flicker	9 years ago
Florian Kraft	9d679cb68f	update tests and fix codestyle problems ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	1ee5e58fb6	attempt to fix protractor flicker	9 years ago
Florian Kraft	7e65456b02	add a test for the work package attachments service ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	a2dda34bc6	add Notification Box directive test ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	54e3702b7f	add basic tests for NotificationsDirective ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	50372dac69	add tests to verify NotificationsService ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	0578ad4b90	correct the conversion service to actually work ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	2c97d64fff	prevent protractor flicker by promises	9 years ago