279 Commits (5b4074077ebc0c9e170b501aa0d7e0715eaaa48b)

Author	SHA1	Message	Date
Henriette Dinger	bce314a970	Fix broken specs	9 years ago
Henriette Dinger	691813c962	Apply new styling to WP destroy	9 years ago
Henriette Dinger	05a037e944	Adapt to the new DOM-structure in repositories and projects and made little style changes on the component	9 years ago
Oliver Günther	dc90d71942	Replace severer warnings with danger zone ... This commit removes the `.-severe` warning notification type in favor of the danger zone.	9 years ago
Oliver Günther	369a25a084	Remove unreached code after checkout in toolbar ... On empty repository pages, the checkout URL was included within the notification box. With the checkout URL residing in the toolbar, this is no longer used, but some of the code was still missing.	9 years ago
Henriette Dinger	e9810757f6	Insert a '-short' class for td and update table in Wiki/History, WP/simpleList, Revision	9 years ago
Oliver Günther	bef80793a0	Small visual corrections for checkout ... This commit provides: * An integrated annotation warning display, when the entry could not be annotated (most often due to it being binary). * Hide current rev_id for subversion when no branch/revision is given.	9 years ago
Henriette Dinger	c74fba4ab3	This moves CSS to toolbar-component, removes the button text and updates the styleguide	9 years ago
Henriette Dinger	95a62ba43d	The header has now the modifier class 'short'	9 years ago
Henriette Dinger	74674ce6a8	The close symbol is now an icon	9 years ago
Oliver Günther	08db1844b4	Accessibility and smaller corrections ... Adds titles to: * repository root breadcrumb * copy to clipboard button Corrections: * Avoid copying to clipboard when clicking the input. * Add hidden-for-sighted label for copy button. * Remove notifications only when not in accessibility mode * Avoid generic `-with-gap` button style * Increase notification timeout	9 years ago
Oliver Günther	71985a94c2	Use new icon-compare in revision	9 years ago
Oliver Günther	4dc68606ca	Enable copy to clipboard through execCommand API ... Uses execCommand API supported in some browsers to allow copy to clipboard. Displays a notification with the result of the operation	9 years ago
Oliver Günther	d81b20fee4	Restyle navigation and instructons on show and empty ... This commit provides: * Adjustments on breadcrumbs according to styling * Restored indent in repository table * Disallow closing checkout instructions on empty page The repository indent for opened folders was removed in the re-styling of tables in 7a844aa9d5	9 years ago
Oliver Günther	14e74596a3	Allow multiple toolbars to exist, extend toolbar functionality ... Previously, toolbars were thought to be unique on a page and thus identified by id. As repository now contains multiple, this was changed to class-based selectors. This commit also adds functionality in toolbars for: * Including select2 fields (proper scaling). To avoid too small selects, toolbar select2 fields are at least 150px wide * Including inline labels in toolbars * Prepended and appended inputs * Icon-only icons (they require font-size changes and a small offset)	9 years ago
Oliver Günther	5d978e0d60	Style checkout instructions and url according to visual ... This commit provides: * The checkout instructions as a notification-box with info icon * A style for affixed inputs in the toolbar * The checkout URL as an affixed input * The checkout URL inside the notifcation-box on empty repository pages * Animations for the checkout instructions toggle * Restyle revision section	9 years ago
Henriette Dinger	bca793ce73	replaced images in Repository, Wiki and fixed occurred bugs	9 years ago
Stefan Botzenhart	fbf5ead351	Add headline to repositories tab	9 years ago
Oliver Günther	7e7386f3b6	Rework instruction display ... - Defaults to localized instruction when none is provided in the settings - Make readonly input visually clickable, not disabled - Renamed `permission?` to `permissions?`	9 years ago
Oliver Günther	dfb8ac4853	Add basic checkout instructions ... This commit adds very basic checkout instructions similar to `openproject-checkout` to repositories. Issues: * Uses table style for checkout component, as exact styling is unclear * Adds compressed table style with less padding * Checkout settings are best organized in a Hash with keys per SCM * vendor. Using default settings, a lot of new setting values would be introduced * Checks for Hash in SettingsController * Currently can't use SettingsHelper, as it requires single setting values	9 years ago
Oliver Günther	a71ce6f1a5	Refactor SCM config to lowercase / symbols ... ENV-based configuration for various configs can only provide case-insensitive values for SCM configuration and thus is unable to properly configure, e.g., managed repositories. This refactoring relies on lowercase configuration and symbols to define SCM vendors, and camelizes them to the old notation (e.g., :git => 'Git') when using `Setting.enabled_scms` to remain compatible with previous installations.	9 years ago
Henriette Dinger	d8c322a61c	fixed style bugs	9 years ago
Alex Coles	a8e92e251f	Rename Changeset changes assoc. to file_changes ... Avoid naming collision with `ActiveRecord::AttributeMethods::Dirty#changes`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Henriette Dinger	7a844aa9d5	removed unnecessary stylings	9 years ago
Henriette Dinger	12993e484c	restyled the tables Boards, My, ProjectAssociation, Repositories, TimeEntries, Wiki/History, WorkPackages/ListSimple	9 years ago
Oliver Günther	5b4ebe8dc0	Add better contextual view hooks to navigation and empty view ... This commit adds distinguishable view hooks for plugins wanting to: * Add a toolbar item to the repository navigation * Show contextual information specifically on the empty repository screen	9 years ago
Oliver Günther	234be83b10	Allow checkout plugin to display information below empty notification ... This calls a hook in the repositories/empty template to allow the checkout plugin to display checkout information there. [ci skip]	9 years ago
Oliver Günther	d46c936adf	Repository form: Toggle not only inputs, but selects ... When toggling the SCM type, form elements must be disabled manually due to a big with fieldset[disabled] on IE10/11. This commit adds the missing select selector to catch the path_encoding select re-introduced in https://github.com/opf/openproject/pull/3296	9 years ago
Oliver Günther	0aa12f0219	Re-introduce path encoding option to Git repositories.	9 years ago
Oliver Günther	86f847043b	Allow configuration to disable arbitrary SCM types ... This commit provides: - Configuration options for disabling any number of available types of that particular SCM vendor. - Changes to the underlying structure to allow determination of which types are available on a class level.	9 years ago
Oliver Günther	aec6593ca0	Provide functionality to override settings and views for checkout ... This commit provides the functionality required by the checkout plugin (and possibly others) to change certain attributes and extend views in the repositories settings scope.	9 years ago
Oliver Günther	6763fe875d	Remove save button for managed repositories ... This commit removes the settings `save` button for managed repositories. Important: When adjustable settings for any vendor should be added, this button must be shown depending on some individual vendor logic.	9 years ago
Oliver Günther	ad0632a278	Fix invalid method used in :update	9 years ago
Oliver Günther	5cb81d6995	Fix typo in attributes-group.	9 years ago
Oliver Günther	edf713fbd5	Rework managed repositories error handling ... This commit: - adds error messages for filesystem errors - Forces services and views to use repository.root_url instead of managed_path, which may not be available when config is missing	9 years ago
Oliver Günther	c5b200d7a0	Review corrections ... - Remove repositories paths using project.id instead of `project_id` - Allow managed repositories to be unlinked in the instance (But doesn't remove repository directory). - Remove leftover settings partial	9 years ago
Oliver Günther	3f347fdc25	Refactor attribute-groups to use -toggleable modifier instead	9 years ago
Oliver Günther	0284d11f21	Corrections from review ... - destroy_info: remove superfluous JS confirm dialog. - destroy_info: change notification type into severe warning - destroy_info: Remove delete button highlight and back button for consistency with styleguide. TODO: think of other ways to guide the user back (also applies to project destroy_info) - remove typo in 'repositories.errors.unauthorized' - empty repository: Render warning view (repositories/empty) instead of 500 exception notification. - revert reformat on code changed in rails4 branch. - create repository: Show managed flash part only when the repository is managed - delete repository: Show error when configuration no longer allows manageable (other ways tbd.) - repository controller: JS redirect wrapped inside format.js - repository settings: Select hidden when instance exists Specs: - Add routing spec for `get #destroy_info`	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter ... This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	c63b9c7a08	Frontend refactoring ... - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user.	9 years ago
Oliver Günther	2ce4646346	Reverted implied annotate bugfix which raised more questions ... Annotation syntax highlighting was broken and I fixed it, this commit reverts the changes, which will be properly re-addressed in the separated PR: https://github.com/opf/openproject/pull/3250	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring ... - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation ... Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the **legacy specs** for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Oliver Günther	0d17061df3	Fix code syntax highlighting output. ... When annotating a file in the repository for whose language CodeRay supports, the output is not properly rendered as HTML, but escaped. As CodeRay escapes any items for HTML before output, we can safely assign syntax lines to HTML when highlighted. If text is output from CodeRay (no language set), we want to escape it instead.	9 years ago
Alex Coles	f93dc3ebfc	Correct toolbar composite buttons markup structure ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Florian Kraft	92f1b396df	escape path in repositories diff ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago