3690 Commits (5c099310c3636834fc259c505ea83ac89bcc8dd0)

Author	SHA1	Message	Date
Jan Sandbrink	24a0c77b86	Fix HTTP 500 in CostlogController ... another case of missing :references statement. In the long term all of the *_condition calls should be replaced by a similar mechanic like Project.allowed_to. But for now it works(tm)	9 years ago
Jan Sandbrink	0bbf8ca508	Replace two occurences of Project.allowed_to_condition ... Project.allowed_to uses the condition internally and is mergable into an AR relation. It will automatically add the neccessary "references" statement.	9 years ago
Jan Sandbrink	a2c5bdf369	Avoid mutator method entirely	9 years ago
Jan Sandbrink	6ecbb25fc2	Fix reversed comments display on WP legacy view	9 years ago
Alex Coles	07551ae585	Switch to new AR API for boolean typecasting ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Stefan Botzenhart	868d764a97	Use activejob deliver_now method (removes deprecation warning)	9 years ago
Oliver Günther	1481afb666	Corrections from review	9 years ago
Jens Ulferts	98fd8828c3	code styling	9 years ago
Jens Ulferts	477bcd8c78	remove code duplication	9 years ago
Jens Ulferts	d3bc58b955	force id value in experimental API ... The id information needs to be returned in the api response so that links still work. The frontend will filter it out anyway	9 years ago
Jan Sandbrink	00d4e72876	fix recipient selection ... - `find_all_by_mails` was removed from core - `recipients` will return users for some time now...	9 years ago
Alex Coles	fac1b77d12	Fix further obsolete finder in DocumentsController ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	62ac37ef28	Skip Controller CSRF checks to fix cuke steps ... Various cuke steps make direct browser AJAX requests - to bypass certain UI actions. This patch ensures these requests are handled correctly. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	88715c2021	Fix obsolete finder w/cond. in CostTypesController ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	8b88eb921f	Fix obsolete finder in MeetingsController ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	8cb645f314	Fix obsolete calls to calculation methods w/cond. ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	c31caa5eba	Migrate obsolete AR finder/query methods ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	980072f7d9	Remove last activity section from admin/projects ... The last activity information is not updated properly in the current state, thus the column should not appear (yet). This will be reversed once it is updated appropriately.	9 years ago
Oliver Günther	6661f2b6d5	Refuse to delete a repository in OpenProject on FS permission errors ... This commit changes the behavior of removing repositories. It is no longer possible to remove a managed repository (model) when the underlying repository directory could not be removed. This error originally occurred when Apache committed changes to the repository through mod_svn, which resulted in the OpenProject user being unable to delete a particular subdirectory.	9 years ago
Jan Sandbrink	f9cb083481	in production handle internal API errors gracefully ... - still allow for useful errors during development - let all own exceptions inherit from StandardError, the thing you should use for own errors...	9 years ago
Stefan Botzenhart	7e74650e02	Fix rubocop concerns	9 years ago
Stefan Botzenhart	394c0d08a3	Authorize custom fields controller method	9 years ago
Stefan Botzenhart	e95fd22218	Move custom field selection for a project to its own tab ... * edit_project permission shall apply * add notice if action fails	9 years ago
Jan Sandbrink	2b7261b2ee	move assembly of reports list into controller	9 years ago
Jan Sandbrink	8e4321959e	improve code style	9 years ago
Jan Sandbrink	ccd65e3e9d	replace some raw SQL by AR magic	9 years ago
Jan Sandbrink	300eb73c0a	replace deprecated find(:first/:last, ...) finders	9 years ago
Jan Sandbrink	1b3fb0b84b	replace deprecated find(:all, ...) finders	9 years ago
Alex Coles	3e5f5a17fd	Migrate further AR finders with conditions ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	f47f61bcbf	Work around outdated group SQL ... The `Group.includes(:users)` call from the GroupsController seems to return an outdated / incomplete result of the members. You can verify that by calling `@group.reload` after the affected line, which will yield the correct result. I assume that this has something to do with the HABTM association `:users` for which a similar issue appears to be still open. Using `eager_loading` directly seems to fix the issue, however we have to remove :memberships here as it requires a condition.	9 years ago
Jens Ulferts	f83713d855	various finder replacement to be rails 4.1 compatible	9 years ago
Jan Sandbrink	f4a00a7a0e	fix silly find_all_by_ replacement	9 years ago
Jan Sandbrink	dfb9a5cd20	remove remaining AR find_by_x finders ... - most of them were removed by @myabc in the rails4 branch - some where reintroduced due to parallel development to that branch - still some occurences left that will hit custom implementations	9 years ago
Jan Sandbrink	ce35d8606d	replace deprecated find(:all, ...) finders	9 years ago
Jan Sandbrink	4b6cbf3a95	replace deprecated find_x_by_ AR finders	9 years ago
Oliver Günther	dfb8ac4853	Add basic checkout instructions ... This commit adds very basic checkout instructions similar to `openproject-checkout` to repositories. Issues: * Uses table style for checkout component, as exact styling is unclear * Adds compressed table style with less padding * Checkout settings are best organized in a Hash with keys per SCM * vendor. Using default settings, a lot of new setting values would be introduced * Checks for Hash in SettingsController * Currently can't use SettingsHelper, as it requires single setting values	9 years ago
Jan Sandbrink	2a65240e52	always include relevant columns ... - caller does not need to do it anymore - caller is still allowed to do it, because it can also add own conditions...	9 years ago
Jan Sandbrink	1c2aabbc45	allow sorting of WP lists	9 years ago
Jan Sandbrink	bc36704611	allow to get queries via APIv3 ... - one of those missing endpoints - adapted resource spec to be closer to other resource specs - specified error behaviour (missing permissions) -> change: not being allowed to see a query results in 404	9 years ago
Alex Coles	53a224bf76	Remove mutation method calls on AR::Relation ... See: * 6eeea9d1 * http://guides.rubyonrails.org/upgrading_ruby_on_rails.html#mutator-methods-called-on-relation Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	988c9f38a7	Cucumber fixes ... * Use correct locale for testing * Global namespace refs	9 years ago
Oliver Günther	21d3af35b1	Set allowed mime types to respond_to ... This sets the allowed response types to be used with `respond_with`. Note that this will again need to be moved with 4.2 http://guides.rubyonrails.org/4_2_release_notes.html#respond-with-class-level-respond-to	9 years ago
Oliver Günther	6eeea9d1da	Avoid mutator sort on relations ... https://github.com/rails/rails/pull/13314 removed mutator methods (e.g., `Array#sort!`) from relations. This commit enforces either an ordering on the query itself where applicable, or uses a non-mutator sort.	9 years ago
Alex Coles	62fd6b1d02	Fix UsersController mass-assignment ArgumentError ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	16bbaba2c1	Fix MyController mass-assignment ArgumentError ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	5129f05678	Fix NameError for Pagination	9 years ago
Henriette Dinger	ba7f5c0891	Add pagination and column sorting to admin projects table ... * Adds a last activity column. * Removes tooltips from projects table in according with PM * Refactors sort_helper to correctly initialize default sort criteria * Add a placeholder 'information section' which matches the visual text size and icon. If this is used more often, this should be turned into its own LSG item * Default sort order is lft, but is unavailable in colums, thus a user should be able to reset the user-selected sorting. Currently we work around this by clearing the session sort entry. Users have to click on the projects menu item to return to the default sort. Relevant work package: https://community.openproject.org/work_packages/18800	9 years ago
Oliver Günther	2769e16819	[21275] Show information on storage paths as admin/info section ... This commit adds a separate section in the admin/info section to show used and available storage for: * Attachment storage * Manageable repository vendors	9 years ago
Oliver Günther	14a394842d	Extract SCM authorization routines into policies per vendor	9 years ago
Philipp Tessenow	373473c563	Add git support to repository authentication script ... Refactors the original PR from #1629 * dispersed authorization methods in SysController * refactored and updated SysController specs	9 years ago