255 Commits (6025a1b0e56051f80b7062f09da34617f3450bc4)

Author	SHA1	Message	Date
Oliver Günther	925bc256cb	Fix failing specs on config with cost plugin ... The cost plugin overrides the default time entries module. However we can still convince the core to use the time entries module, simply by restricting the enabled module set.	9 years ago
Jens Ulferts	b042205c8c	adapt spec, introduce features/page_objects ... The features/page_objects folder should house all the page objects used within specs	9 years ago
Oliver Günther	a71ce6f1a5	Refactor SCM config to lowercase / symbols ... ENV-based configuration for various configs can only provide case-insensitive values for SCM configuration and thus is unable to properly configure, e.g., managed repositories. This refactoring relies on lowercase configuration and symbols to define SCM vendors, and camelizes them to the old notation (e.g., :git => 'Git') when using `Setting.enabled_scms` to remain compatible with previous installations.	9 years ago
Jens Ulferts	751f1f2801	rewrite legacy spec as feature spec ... Another option would have been to write it as unit tests for the controller. However, that would have required to restructure the controller as unit testing would otherwiese require to much mocking. Additionally, the feature specs are required anyway.	9 years ago
Jens Ulferts	571b7b3ba6	hoping for spec stablility	9 years ago
Florian Kraft	8761baed44	remove obsolete error tests ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	31ec2ab0c2	using stable expectation	9 years ago
Oliver Günther	f58856d58e	Fix support css rule	9 years ago
Oliver Günther	d684a2295a	Have tests use new work package table rules	9 years ago
Jens Ulferts	ca2e9e258f	disable required fields when making them invisible	9 years ago
Oliver Günther	0a3dcfac9e	Use find selector after JS redirect ... On occasions, the CI reports the same feature spec to be failing due to a StaleElementReferenceError, however the stacktrace suggests that this error stems from the extraction of node texts after the actual query within one retry of the synchronized selection. The stacktrace begins that error inside `synchronized` and deep within `result.failure_message`. 120daaa856/lib/capybara/node/matchers.rb (L97) Thus this commit suggests to use the simplest `find` selector to locate the element, which does not access its contents.	9 years ago
Henriette Dinger	3e600b47a6	fixed test to expect the filter to be collapsed	9 years ago
Jens Ulferts	06937978f6	relying more on the page object for specing	9 years ago
Oliver Günther	b2068dbed1	Try to select other element first after page redraw. ... By selecting an entirely different element on the settings page (e.g., the flash message), the button and radio elements are being available afterwards and do not return a capybara cache error.	9 years ago
Oliver Günther	a00c116eb8	Allow increased wait time for JS-induced redirect ... The same shared examples of `create_repository_spec` are repeatedly encountering timeouts after a repository is created and the user is redirected to the settings page. This allows these methods to have more wait time at their disposal.	9 years ago
Jens Ulferts	6309d8d6be	explicitly wait for angular for wp specs	9 years ago
Jens Ulferts	4c16b12af7	in spec, open object under test directly	9 years ago
Jens Ulferts	379fde84cd	attempt to fix spec flicker	9 years ago
Oliver Günther	ee3b1ee1ad	Change feature spec broken by openproject-checkout. ... The checkout plugin overrides behavior in the core which leads to the repository settings form submit button to be displayed even though the core feature expects it to be hidden. As the surrounding spec is relevant for the plugin, too, and should not be skipped / disabled, this commit instead reworks the test to check for a different aspect of the page to ensure the request was successful.	9 years ago
Jens Ulferts	7bdef98f0e	set de and fr as default locales	9 years ago
Oliver Günther	6763fe875d	Remove save button for managed repositories ... This commit removes the settings `save` button for managed repositories. Important: When adjustable settings for any vendor should be added, this button must be shown depending on some individual vendor logic.	9 years ago
Jens Ulferts	f831cee33a	attempt to fix spec flicker	9 years ago
Jens Ulferts	5376ac714e	second attempt to fix spec flicker	9 years ago
Jens Ulferts	df4cf61c36	attempt to fix spec flicker	9 years ago
Oliver Günther	ad0632a278	Fix invalid method used in :update	9 years ago
Oliver Günther	5cb81d6995	Fix typo in attributes-group.	9 years ago
Oliver Günther	caf5e4a706	Formatting and clean up	9 years ago
Oliver Günther	c5b200d7a0	Review corrections ... - Remove repositories paths using project.id instead of `project_id` - Allow managed repositories to be unlinked in the instance (But doesn't remove repository directory). - Remove leftover settings partial	9 years ago
Oliver Günther	0284d11f21	Corrections from review ... - destroy_info: remove superfluous JS confirm dialog. - destroy_info: change notification type into severe warning - destroy_info: Remove delete button highlight and back button for consistency with styleguide. TODO: think of other ways to guide the user back (also applies to project destroy_info) - remove typo in 'repositories.errors.unauthorized' - empty repository: Render warning view (repositories/empty) instead of 500 exception notification. - revert reformat on code changed in rails4 branch. - create repository: Show managed flash part only when the repository is managed - delete repository: Show error when configuration no longer allows manageable (other ways tbd.) - repository controller: JS redirect wrapped inside format.js - repository settings: Select hidden when instance exists Specs: - Add routing spec for `get #destroy_info`	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	3377696563	Began frontend feature specs	9 years ago
Jens Ulferts	a21335db36	safeguard spec	9 years ago
Jens Ulferts	c5de9a4fb7	move spec shared context up in the dir hierarchy	9 years ago
Jens Ulferts	751751f6b4	reuse safeguards for wp index loaded in specs	9 years ago
Jens Ulferts	d5f44a0c60	hoping to fix spec with the help of ng_wait	9 years ago
Jens Ulferts	1b9565afc5	reuse safeguards for wp index loaded in specs	9 years ago
Jens Ulferts	f2ae9be55c	increasing spec robustness, hopefully	9 years ago
Oliver Günther	e0af219a36	Fix invalid time sheet link ... This adds specs for top menu items	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jens Ulferts	1fc2661375	another safeguard for the inplace edit spec	9 years ago
Jens Ulferts	06645249a2	next try to get inplace edit specs stable	9 years ago
Jens Ulferts	6a6207e1c1	remove maximize	9 years ago
Jens Ulferts	fbb1fe1a49	in specs insert text into ui-select ... This will ensure that the element is present and selectable if it is at all	9 years ago
Jens Ulferts	f3458138fb	add safeguard to spec	9 years ago
Florian Kraft	cd39d0e88a	move the maximize window back to ui-select context ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	f0fcb7d6ea	force resizing of window before all js based tests ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	db5c4c2393	maximize the window for breaking test ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	5a8b9ba795	ensure page loaded before cuke	9 years ago
Oliver Günther	5ada719136	Consolidate Module menu in header navigation This effectively changes the following menus: ... **Top Menu** - Removed Administration item - Added Item 'Work Packages' -> /work_packages - Added Item 'News' -> /news - Added Item 'Time Sheet' -> /time_entries (if user has a project with view time log permission) **My Menu** - Added Administration item as first position With work packages, time entries, news now residing in the top menu, these buttons are superfluous in the projects overview and are also removed. Relevant work package: https://community.openproject.org/work_packages/20512	9 years ago
Jens Ulferts	485c67f747	rework focus specs for accessiblity ... Specing for focus seems to be unreliable when using css selectors in selenium. Therefore a custom matcher is introduced to try to work around the issues. Additionally, it makes the specs easier to read.	10 years ago