137 Commits (61357f50918fb20e841b04788f96a2b49d0e8df0)

Author	SHA1	Message	Date
ulferts	938c6e5619	exclude full text columns from attachment model ... Currently, the fulltext columns `fulltext`, `fulltext_tsv` and `file_tsv` are never displayed in the application. As such they are currently purely used internally when the are involved in the fulltext search. Having them included in the AR model Attachment will lead to a lot of data being loaded. Such a column can contain megabytes of data. This is costly twice: when fetching the data from the database and when instantiating the model in ruby. As the data is never displayed, they can be ignored for now using `ignored_columns`. This changes the SQL for fetching from `SELECT "attachments"."*" ...` to `SELECT "attachments"."id", "attachments"."file" ...` (without the excluded columns) The alternative would have been to create a new table for the fulltext information and this might still be an option once the requirements on the columns increase. For now, this change is simpler.	3 years ago
Oliver Günther	e9d7c374cc	[37868] Whitelist for attachment mime types and extensions on upload (#9431) ... * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract	3 years ago
Oliver Günther	d2ce834e23	[37866] Add attachment_created event and webhook (#9418) ... * [37866] Add attachment_created event and webhook * Remove other usages of direct attachment creation * Add attachment webhook spec * Fix other webhook specs * Fix attachment adding in mail_handler * Don't set content_type outside attachment#file= * Fix unrelated spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	3 years ago
Oliver Günther	fa3481523b	Avoid running oauth cleanup job after every authentication (#9241) ... * Avoid running oauth cleanup job after every authentication * Also run attachments job as 'cron' job	4 years ago
Markus Kahl	8c8b8bbfa7	create backups via UI (#9136) ... * create backups via UI * Fix import of modal service * introduced backup token and addressed remaining comments * allow disabling permissions * improvements - only make user wait to use backup token in if really necessary - notify admins of new backup token - disable 'include attachments' option in UI if unavailable - documentation - misc * spec fixes * fixed feature spec * allow setting capybara host in every case * removed unused style file * addressed review feedback, added further feature specs * polish (code climate) * Avoid empty attachments * Don't raise filesize validation for internal exports Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	4ad9ebc6ee	Fix/filename on direct upload (#8928) ... * linting * use Carrierwave's replacement for filename This avoids having the name altered by Carrierwave later on in the Attachments::FinishDirectUploadJob job where the file is fetched and then the attachment is stored. * separate cases for no attachment and no local file	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Markus Kahl	0c582c4f35	use create to be sure we have an id later	4 years ago
Markus Kahl	0792ed6443	fixed fog file uploader path in pending attachments	4 years ago
Markus Kahl	b85380f068	handle pending attachment validation errors	4 years ago
Markus Kahl	b483e6cd35	consider validation errors during pending attachment creation	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models ... Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	f37d6d563d	[24343] Allow PDFs to be served inline ... It still depends on the browser whether inline PDFs are allowed. In Firefox, you can configure this manually what should happen. In Chrome, I'm not sure if there is such an option. https://community.openproject.com/wp/24343	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230) ... Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Oliver Günther	22058d376b	Handle missing viewpoint_names and make snapshot filename unique ... Frontend created snapshots may not have a `viewpoint_name` property, which is currently being used in the XML exporter. It's better to export viewpoints with a unique name however, so I suggest we use the viewpoint UUID + .xml for the XML data, and UUID + .png (or whatever extension) for the associated snapshot.	5 years ago
ulferts	f844023b19	increase tsv extracted check resilience ... The data in the attachments table might be corrupted e.g. when: * A plugin was installed which had attachments defined * Some container type was defined that never was attachable In that case, the check now disregards those attachments on the check for whether they are tsv extracted	5 years ago
ulferts	8432877cdf	class method where intended	5 years ago
ulferts	e9fe3ede11	restict tsv extraction to work package	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	a7ed2e9da0	Rewrite jobs to use ActiveJob syntax	5 years ago
Markus Kahl	bfe1e2003f	make external avatar URLs valid for 24h	5 years ago
ulferts	05a5a0fec6	custom text widget on my page	5 years ago
Markus Kahl	a33016a246	do not use filename in content disposition attachment since unicode may not work	5 years ago
Markus Kahl	6f287a512a	Make S3 serve attachment using the content disposition header	5 years ago
Markus Kahl	3240d3b24a	use complete content attachment disposition including file name	5 years ago
Markus Kahl	e94b98794f	inline plain text	5 years ago
Oliver Günther	26f26c9f6b	[30352] Schedule attachment extraction jobs for faster migration ... There are background jobs already for the text extraction, we can just make them async to ensure the initial migration runs as quickly as possible https://community.openproject.com/wp/30352 [ci skip]	6 years ago
Markus Kahl	bc5adfcba7	attachments for meeting contents (MeetingAgenda, MeetingMinutes)	6 years ago
Wieland Lindenthal	3cee485f46	Revert "Revert "Merge pull request #6964 from opf/spike/bim-bcf"" ... This reverts commit 766f958145.	6 years ago
Wieland Lindenthal	766f958145	Revert "Merge pull request #6964 from opf/spike/bim-bcf" ... This reverts commit 20525deede, reversing changes made to 27eb788f69.	6 years ago
Oliver Günther	b367437131	BCF Import and exporBCF Import and export ... [ci skip]	6 years ago
Oliver Günther	f2ceec1c78	Set DJ priorities and lower max attempts	6 years ago
Jens Ulferts	57c8aeb5aa	add job to cleanup uncontainered attachments	7 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Jens Ulferts	ce21ee20f7	cached representers	7 years ago
Wieland Lindenthal	b5de6add68	Do not allow attachment filters unless TSVector is available. No MySQL/MariaDB support.	7 years ago
Wieland Lindenthal	c8d610e2ba	Satisfy rubucop	7 years ago
Wieland Lindenthal	7636aede9c	Provide second rake task that updates text extractions even for those that have already been extracted.	7 years ago
Wieland Lindenthal	643e945b85	- Remove configuration option for attachment search ... - Remove attachment search from global search as it is currently incompatible - Add rake task for indexing attachments that have not been indexed yet - Make the attachments filters a EE feature.	7 years ago
Wieland Lindenthal	f2ebad3915	WIP: attachment search	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	26332c446b	[25739] Allow copying of attachments in wiki and work package (#5889) ... * [25739] Allow copying of attachments in wiki and work package https://community.openproject.com/wp/25739 * [25769] Fix duplicate wiki menu item On creation, a wiki always gets its default wiki menu item. we don't need that upon copying however, since the wiki menu items will be copied. [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Markus Kahl	9fc18f6bf6	must be a path if we can't parse it as an URI ... also even if it was an URI, it's no good if it's invalid	8 years ago
Oliver Günther	47cf64f46e	Avoid checking for Hash on params	8 years ago
Markus Kahl	7f88ba5b22	removed attachments#show; only #download remains	9 years ago
Markus Kahl	c7c6bc2e6a	prevent unnecessary s3 access to see if file is readable	9 years ago
Mohamed Wael Khobalatte	0e72ec4243	Move to ruby1-9 syntax once and for all	9 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params ... We no longer need attr_accessible.	9 years ago