openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	3ac7490c01	Fix static paths of Frontend PathHelper	9 years ago
Alex Dik	0ec5698380	Move activity entry directive to components	9 years ago
Oliver Günther	2ee7465138	Fix tab order on activity tab This restores a hierarchical tab order in the activity tab. Elements are browsed as follows: 1. The activity wrapper, with an `aria-label` set to 'Activity number {number}' 2. The author of that activity 3. (When comment given): The quote and edit button, whose labels were improved	9 years ago
Alex Dik	a3c4bcfbce	Remove save callback	9 years ago
Oliver Günther	d3d6cd60ee	Temporarily store promises until they are resolved The original commit simply stored promises into the cache, which seemed to work in browsers but failed with karma/PhantomJS. I'm not yet certain why that is, but I wanted to get rid of complex objects in sessionStorage anyway, so this commit does: * temporarily store running promises for a given key * cache the resolved data directly	9 years ago
Oliver Günther	64d5b399c5	Experiment with angular-cache One prominent example where we can employ frontend-side caching is the fetching of associated users in activities. For a large number of comments of the same user, that user is retrieved once per activity, which causes a drastic overhead. This commit introduces a simple wrapper around angular-cache to store values in the sessionStorage.	9 years ago
Jens Ulferts	760edcd414	extract activity-link to directive and reuse it for all activities	9 years ago
Jens Ulferts	233ce258f9	fix activity anchors * provide an ID to have a valid anchor target * remove sref work araund as we are always targeting the full screen view	9 years ago
Oliver Günther	e88deb8556	Fix errors when editing comments This addressed an invalid event handler that causes a TypeError within jQuery and corrects a scoping error that leads to comments being updated with their original/unchanged texts. Relevant work package: https://community.openproject.org/work_packages/21578	9 years ago
Oliver Günther	de96916dac	Minor corrections This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	7f602664fc	Allow focussing an element after work package has been updated This commit allows comments or fields to specify a callback after the work package has been updated. This is currently used to scroll to the element (such as the inserted comment), whenever the work package has loaded.	9 years ago
Oliver Günther	9bd4e06d29	Use promises in submitFields methods to defer updating As submitting comments and fields in one go requires work packages to be submitted first, we can use promises to ease the processing of each and abort early, e.g., when the WP couldn't be updated, we don't want to submit the comment.	9 years ago
Oliver Günther	d1a1020097	Workaround for focus event on user activity It seems that the user activity doesn't correctly handle blur events. I do not know why, but to provide a workaround, I've forced setting the focus for the quote and edit buttons.	9 years ago
Oliver Günther	7cd7697fab	Replace autogrow with angular-elastic angular-elastic provides us with an option to always insert an additional newline to provide smoother animations. This also changes animations to CSS rather than `jQuery.animate`.	9 years ago
Henriette Dinger	27c60cf667	Incorporate review feedback * Notification when comment is created * Better binding to editing comments * Quote with inserted text fixed	9 years ago
Oliver Günther	51509e6b34	Editing of comments with in-place button styles and preview This commit changes the comment edit and cancel buttons to reflect the in-place editing style. Also allows previewing of edited comments and also shows a notification-box when comments are edited.	9 years ago
Oliver Günther	0883cf9834	Replace exclusive-edit with transcluded comment directive This commit removes the somewhat superfluous exlusiveEditController in favor of event-based passing of quoted text to the correct comment field. The comment directive now decides for itself whether it wants to be placed above or below the activities and uses transclusion for that purpose. Editing comments is now no longer exlusive, but that shouldn't be necessary anyway.	9 years ago
Henriette Dinger	01d47ea851	Editable comment field This provides the basic functionality to deliver a comment field in the in-place editing style. Adds the `autogrow` plugin This still breaks a number of features currently, such as formatted previewing.	9 years ago
Oliver Günther	1e11547af3	Better localized revision link using dynamically compiled date and href	9 years ago
Oliver Günther	a1de855db8	Add missing href to resource	9 years ago
Oliver Günther	d9d784e5cf	Move activities out of tabs This moves activity templates and directives in their own namespaces / module. Also adds a single activity entry for overview and activity, which itself selects the correct directive for the given activity object.	9 years ago

21 Commits (650b5f41596507ed23cf31c9c4b50b9fb8f3a33d)