266 Commits (650b5f41596507ed23cf31c9c4b50b9fb8f3a33d)

Author	SHA1	Message	Date
Tim Habermaas	0be7cc7d24	Fix karma specs.	9 years ago
Tim Habermaas	7059dcc1a6	[WIP] [skip ci] fix some karma specs	9 years ago
Henriette Dinger	64be47f600	Fix broken spec	9 years ago
Henriette Dinger	ee31ccdccf	Exchange classes and labels: delete, remove	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	51509e6b34	Editing of comments with in-place button styles and preview ... This commit changes the comment edit and cancel buttons to reflect the in-place editing style. Also allows previewing of edited comments and also shows a notification-box when comments are edited.	9 years ago
Oliver Günther	0883cf9834	Replace exclusive-edit with transcluded comment directive ... This commit removes the somewhat superfluous exlusiveEditController in favor of event-based passing of quoted text to the correct comment field. The comment directive now decides for itself whether it wants to be placed above or below the activities and uses transclusion for that purpose. Editing comments is now no longer exlusive, but that shouldn't be necessary anyway.	9 years ago
Oliver Günther	0aed8bb310	Test for comment input	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications ... This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Jens Ulferts	c26773e5f8	split method to avoid boolean flag	9 years ago
Jens Ulferts	52b1f75d5c	remove no longer required attachment directives	9 years ago
Jens Ulferts	2d081b97fb	filter directories before uploading ... Uploading directories is not possible. When dragging a directory to the dropzone, the direcory is flattened so that the files in the directory will be accepted, but the directory itself is ignored.	9 years ago
Oliver Günther	14e74596a3	Allow multiple toolbars to exist, extend toolbar functionality ... Previously, toolbars were thought to be unique on a page and thus identified by id. As repository now contains multiple, this was changed to class-based selectors. This commit also adds functionality in toolbars for: * Including select2 fields (proper scaling). To avoid too small selects, toolbar select2 fields are at least 150px wide * Including inline labels in toolbars * Prepended and appended inputs * Icon-only icons (they require font-size changes and a small offset)	9 years ago
Jan Sandbrink	b41e96a8af	Adapt frontend-specs to new embedding ... just realized that those are 12k lines of C&P activities. I reduced the amount to a less insane (but still not quite sane) ~1k lines... It might be a better idea to automatically generate those mocks. This would be: - more consistent - more up-to-date with real data - less error-prone (b.c. less copypasta)	9 years ago
Florian Kraft	d8bd557743	remove focus statement ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	cb0c85a795	add some basic tests ... These tests are mostly concerned with the data layer and expected and actual responses from the APIv3. Also, a controller skeleton test is included Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	adb0e1802c	remove old controller tests for watchers tab ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	3e25adfcbb	do not only tests the WatchersService ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	07058738a1	handle injections to watchers service properly and add tests ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Henriette Dinger	ca02263058	updated icon font, fixed broken specs and design bugs	9 years ago
Henriette Dinger	e895b1eb99	replaced the picture with icons in TimeSheets, Workflow/Summary	9 years ago
Jens Ulferts	f4b820553a	allows for creating error notifications with only an error message	9 years ago
Jens Ulferts	aadf639e68	remove helper method no longer needed	9 years ago
Jens Ulferts	6658334bb3	specs for api-notifications-service	9 years ago
Jens Ulferts	e691fe0050	adapt karama tests	9 years ago
Oliver Günther	ae4679c67b	Remove revision unit test example that requires compile	9 years ago
Oliver Günther	9d0e4f0738	Add unit test for revision activity	9 years ago
Jens Ulferts	8d19fec246	disabling test failing on travis	9 years ago
Jens Ulferts	f6dfcda01a	provide the configuration upon compile ... This hopes to fix a test failure only occuring on travis.	9 years ago
Jens Ulferts	af14a4509b	reduce duplication in directive test	9 years ago
Jens Ulferts	d3b5e3ee8f	unit testing inplace editor dropdown directive	9 years ago
Jan Sandbrink	c42e41702d	add spec for hiding details on first journal	9 years ago
Florian Kraft	9d679cb68f	update tests and fix codestyle problems ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	7e65456b02	add a test for the work package attachments service ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	a2dda34bc6	add Notification Box directive test ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	54e3702b7f	add basic tests for NotificationsDirective ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	50372dac69	add tests to verify NotificationsService ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	0578ad4b90	correct the conversion service to actually work ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jan Sandbrink	22dd30beb4	let karma test stubs look more like the real thing	10 years ago
Jan Sandbrink	b2de1c89b8	fix karma tests	10 years ago
Jens Ulferts	687149dfed	consider all dates without a timezone (i.e. local) on the front end	10 years ago
Florian Kraft	3b4026e20c	fix issues found by hound ... [ci skip]	10 years ago
Florian Kraft	289d1e8230	add a test for the newly added category service	10 years ago
Florian Kraft	9b3b876c27	add a path helper test ... checks the newly added paths for the PathHelper	10 years ago
Alex Coles	8256ba1014	Add count to work packages toolbar filter button ... User Story # 19669 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	c1c29d9e35	Add/update Copyright headers in frontend app ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Oliver Günther	65db6dee96	Fix work package CSS rule affecting syntax highlighter ... In the dynamic work package sidebar, user comments are addressed by CSS using span.comment in _activities_tab.sass. Unfortunately, this exact rule is CodeRay picks up the same rule, which causes the syntax highlighting of comments to be wrong. This commit renames the WP rule to .user-comment instead. Relevant work package: https://community.openproject.org/work_packages/19638	10 years ago
Florian Kraft	6f644f0f1e	cleanup test object structure	10 years ago
mhirtie	bfdff4699c	Fix showing of parents on details pane.	10 years ago
mhirtie	6772390ad2	Rebased on @0xF013's branch	10 years ago