102 Commits (6532d4a31fe6cf57d17ba9616a278befe59a8717)

Author	SHA1	Message	Date
Jens Ulferts	f3622b2ac8	remove code duplication	6 years ago
Jens Ulferts	77b4863d09	fix journalizing detection for multi field cfs	6 years ago
Oliver Günther	42584aeae3	[28186] Fix formatting journal details in no_html_mode ... https://community.openproject.com/wp/28186 [ci skip]	6 years ago
Henriette Dinger	e064bb7af8	Increase contrast between differences in journal (#6194) ... [ci skip]	7 years ago
Jens Ulferts	b3a11a0fd9	replace deprecated references to changes in after_save hooks	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag ... Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
ulferts	9414241dfb	show error message if activity cannot be saved (#5678) ... [ci skip]	7 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465) ... * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
ulferts	c9bd9c238e	replace some occurances of alias_method_chaining (#5449) ... [ci skip]	8 years ago
Markus Kahl	f5a57e3f42	list custom field normalisation and multi select	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	2264d5a345	format floats in journals accoriding to the locale	9 years ago
Mohamed Wael Khobalatte	0e72ec4243	Move to ruby1-9 syntax once and for all	9 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params ... We no longer need attr_accessible.	9 years ago
Jens Ulferts	4ed191d659	removes duplicate safeguard for polymorphic association ... The 'journable_type' check is added by AR itself because of the polymorphic association (:as=>:journable)	9 years ago
Jan Sandbrink	aaf4637138	Ensure that concurrent version updates play well together	9 years ago
Alexander Bach	a8e1aadec7	replace changed_data by details ... working towards making the alias obsolete...	9 years ago
Jan Sandbrink	d8cfa271cd	try to improve readability of JournalManager ... - using useful names - using rubys awesome syntax to avoid nested list accesses (e.g. k[0][1])	9 years ago
Alexander Bach	3053d0f875	Add more positivity	9 years ago
Jan Sandbrink	3e82f24402	improve readability of JournalChanges	9 years ago
Jan Sandbrink	6a0ef38f5f	extract get_changes into own module	9 years ago
Alexander Bach	5fea667954	Return recipients as users instead of mail addresses	9 years ago
Alexander Bach	8c51577e37	Clear up method name	9 years ago
Alexander Bach	196b5e049e	Move comment	9 years ago
Jan Sandbrink	3a87b269fa	allow to fetch aggregated journals for a journable ... - this should be faster (or at least easier to optimize) than applying a WHERE to the whole scope - also starting to diverge from using classic ActiveRecord in aggregated journals	9 years ago
Jan Sandbrink	953ad6d15f	change aggregated_journals on AaJ to be a method ... - a "real" relation involves cascading updates that are not intended for _aggregated_ journals	9 years ago
Jan Sandbrink	d6533b100c	first spike for aggregatable journals	9 years ago
Jan Sandbrink	a59b361222	remove dead code	9 years ago
Alexander Bach	7e0c7c352e	Move event to fire after its sure that a journal will stay	9 years ago
Alex Coles	3abb8c7fa4	Remove unloadable from lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	53524637ec	Migrate acts_as_journalized has_many to lambda ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a6c54cb25f	Migrate AR finder/query methods in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a6212fb304	Fix syntax (w/Rubocop) in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	e02599c121	Make acts_as_journalized retry journal saves ... Since 2c735943, validation errors are raised and propagate. Uniqueness validations in the application code are generally prone to race conditions. Previous commit e8c2ce06 should help mitigate against this scenario. Nevertheless there are still problems setting a unique, initial version for a given scope: this patch attempts to work-around this situation. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	abc2b25ab3	style	10 years ago
Jan Sandbrink	9b9785ca0c	invert conditions for better readability	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	ca2a1a5afc	Prefer #map over #collect in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	45297523c2	Fix syntax (w/Rubocop) in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e7400af52a	Use 1.9+ Hash syntax in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Hagen Schink	a9b9f2c46a	Make long WP change information accessible	10 years ago
Alex Coles	23d14e94a9	Fix whitespace in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Michael Frister	2c7359436a	acts_as_journalized: Use save! instead of save ... This should prevent journals silently not being saved on validations errors.	11 years ago
Michael Frister	f079e4bcdd	Clean up acts_as_journalized SaveHooks	11 years ago
Alexey Fedorov	f4775c6a40	[fix #4928] Made journal notes shown in search. ... - Added tests and specs for bug #4928 - Examined bug - Added debug output to examine event contents - Examined journals - Added highlight_first helper - Used last_journal instead of #journals.last - Fixed Journalized#last_journal to work when eager loading messed up search - Fixed how journals are sorted when they are loaded (by version instead of created_at) - Added notes anchor when required - Added notes anchor when required - Note anchor uses version of journal note itself, not version of work package - Fixed failed test in functional/wiki_controlller_test.rb:WikiControllerTest #test_update_stale_page_should_not_raise_an_error - Fixed spec failures. - Converted search helper test -> spec, removed test file. - Moved helper methods from string to controller - Fixed search controller spec. - Temporary added isolated suite run to travis for work_package_activity_provider_spec - Removed temporary job for travis.	11 years ago
Markus Kahl	930ae39df3	Revert "use static routing in journal formatters" ... This reverts commit b0215db3d8.	11 years ago
Markus Kahl	b0215db3d8	use static routing in journal formatters	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago