openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	ccca8641e8	Refactor selection state to handle additional elements	7 years ago
Oliver Günther	ed8baccc3b	[25615] Render content of additional hierarchy rows Renders additional hierarchy elements as regular citizens of the table. To this end, we need to load all ancestors when the hierarchy mode is enabled. This PR combines the WP loading of the relation columns service with the required WPs of additional hierarchies into a separate service. Additionally, whenever the hierarchy mode is turned on, we now need to visibly refresh the results.	7 years ago
Oliver Günther	8113ed9d19	Show relation rows as regular members of the table Still WIP: - Relation column is rendered as all other rows (indicator for dropdown), which is confusing	7 years ago
ulferts	df99cf15c3	fix wp subject display in ff (#5640 ) * fix wp subject display in ff The subject used to be hidden because the width calculation was off. Instead of tempering with the width calculcation, I decided to use float instead so that we end up with fewer objects having their width calculated in js * fix being able to double click on hierarchy area * add comments on pointer-events [ci skip]	8 years ago
Oliver Günther	568518d6a3	Move QueryColumn interface into its own class	8 years ago
Oliver Günther	7d62d846a2	Implement relation columns as secondary render pass	8 years ago
Oliver Günther	ac46271c59	[25430] Set the width of the remaining space next to hierarchy indicator (#5613 ) This allows inline edit fields to retain the whole remaining size next to the hierarchy indicator. https://community.openproject.com/projects/openproject/work_packages/25430/activity?query_id=916 [ci skip]	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465 ) * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	ebdad784cd	[25415] Add ancestor groups always when inserting extra rows (#5587 ) The hierarchy render pass uses ancestor groups to identify which rows belong to a certain hierarchy group for simple selector-based hiding/expanding of nested groups. For extra added rows, these groups were only added when the ancestor was not yet added to the list, causing them to not respond to collapsing the ancestor group. [ci skip]	8 years ago
Oliver Günther	e20ef8fc71	[25411] Never render extra parents in timeline (#5584 ) Currently, hierarchy mode does NOT load extra parents that are not part of the results table (marked grey). As they are not loaded, the timeline doesn't have any information to draw them with. However, IF the workPackages state _had_ the value of the work package (e.g., because it's open in split view or it is part of a relation), it would still be rendered. This PR avoids rendering these rows at all times. [ci skip]	8 years ago
Oliver Günther	3e16b86009	[25312] Refresh the complete table side on column changes (#5527 ) * [25312] Refresh the complete table side on column changes After the integration of the timeline into the table, it was too costly to refresh the table (and re-initialize the timeline) for everytime the column were changed, so only each row was refreshed. Since the timeline is now separate, we can refresh them invidividually when being careful that this results in now row changes (such as changes to the columns) * Don't fire the timeline unsubscribe subject when refreshing table only [ci skip]	8 years ago
Oliver Günther	4ad0647aac	Fix missing rendered call in hierarchy render pass	8 years ago
Oliver Günther	3216ddf27d	Implement rendered update for group collapse changes	8 years ago
Oliver Günther	3c60de4b59	Note which of the work packages are hidden	8 years ago
Oliver Günther	0a7e5291a3	Use orderedRows in rendered state	8 years ago
Oliver Günther	63cdc2f40c	Extract render passes for all modes This allows us to use them similar to a service result object to fill the new rendered state.	8 years ago
Oliver Günther	f3acaaa996	[25173] Fix render order in timeline rows when inserting into existing hierarchy	8 years ago
Oliver Günther	3d7abbfff4	Fix hierarchy mode mirroring in timeline	8 years ago
Oliver Günther	13e27febcd	[251939 Render clamp-style parent in timeline only when children visible When no children is visible in the timeline, don't use the `clamp-style` to render the parent.	8 years ago
Oliver Günther	d4edded12a	Render timeline cells as part of the rows building process [ci skip]	8 years ago
Oliver Günther	1b7800c1c8	[25170] When parent is visible, defer rendering of children below them When sorting, the hierarchy mode currently moves parent elements above their children regardless of their actual position in the table. Preferably, if parent elements are contained in the table results, their children (and any recursive children) should be moved below them. This way, the actual sorting of the table isn't destroyed by the hierarchy mode.	8 years ago
Oliver Günther	ac2ded3f04	Refactor implementation into correct builders This bugged me for a while, so fixing it now before addressing more issues in the hierarchy builder	8 years ago

25 Commits (668306b12f427c3eb0f5d00fd4af396b9f0ed3a8)