248 Commits (675975ac9fcd77806aeff959ab9cd23f98354855)

Author	SHA1	Message	Date
Christophe Bliard	b50855a955	Use ServiceResult factory methods where possible ... All was automatic through the use of `rubocop --autocorrect --only OpenProject/UseServiceResultFactoryMethods app lib lib_static modules spec`.	2 years ago
Christophe Bliard	c6e44141db	Remove :stubbed_work_package factory ... Using build_stubbed(:work_package) works equally well. Relates to commit e1607a6116	2 years ago
Christophe Bliard	48a4f1b6ad	lint with rubocop --autocorrect (safe cops only)	2 years ago
Christophe Bliard	76f9aa760d	reevaluate module availability on each call	3 years ago
Christophe Bliard	2356dfc133	test that :if in module declaration controls module availability ... and make rubocop happier	3 years ago
Christophe Bliard	a33524ef6d	remove ruby magic comment for utf-8 ... ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless	3 years ago
Wieland Lindenthal	727f304cc9	Fix BIM seeder spec to account for new TeamPlanner queries	3 years ago
ulferts	d18f60aefe	replace assignable column on role	3 years ago
Christophe Bliard	bc8d423ec2	update copyright information for 2022	3 years ago
Oliver Günther	790341f709	Don't open split view on click unless already open	3 years ago
Christophe Bliard	d17d31eca7	Fix argument alignment since f08bea3467 for modules specs ... The FactoryBot.* prefix has been removed in f08bea3. Since then rubocop complains about Layout/ArgumentAlignment. This commit fixes it.	3 years ago
ulferts	a3fc906ff8	ensure using .create for cf representer initialization	3 years ago
Oliver Günther	f08bea3467	Remove FactoryBot.* prefix where applicable	3 years ago
ulferts	cb63949c58	replace deprecated File.exists?	3 years ago
ulferts	e63eebeca0	only keyword parameters on service calls	3 years ago
Wieland Lindenthal	466eaff6ac	[#40187] Uploaded IFC Model can't be set as Standard Model (#9984) ... https://community.openproject.org/work_packages/40187	3 years ago
Eric Schubert	b38e806ed8	[#40267] Opening viewpoints on mobile ... - https://community.openproject.org/work_packages/40267 - removed mobile alternative for details routes for bcf module - added style for details page on mobile resolutions - fixed unwanted href after clicking card ui-state-link	3 years ago
Eric Schubert	80f0378d67	[#39772] fixed broken spec	3 years ago
Eric Schubert	537230a214	[#39772] added query editing feature spec	3 years ago
Eric Schubert	4cefa8f92e	[#39772] rebuild bcf module routes ... - https://community.openproject.org/work_packages/39772 - merged all view states of bcf module into single base route - kept create_new and details routes - major renaming bim -> bcf	3 years ago
Wieland Lindenthal	20c7a578f1	[#30583] Introduce module specific views for BIM module (#9954) ... * [#30583] Introduce module specific views for BIM module https://community.openproject.org/work_packages/30583 * Extend TypeFilter specs to cover additional allowed values for BIM	3 years ago
Wieland Lindenthal	28571eac26	Fix updating conversion_status in Update Service	3 years ago
Wieland Lindenthal	69fd660a10	Ensure that IfcModel's conversion status is reset on update ... Set the status to pending and delete potential error messages.	3 years ago
Wieland Lindenthal	ebab8bb49c	Save for each IFC model what state its conversion to XKT is in. (#9751) ... * Save for each IFC model what state its conversion to XKT is in. Display the status and, if present, the error message to the users * Set conversion_state on migration * Add converion error messages to the ifc models list. * Extend ifc conversion spec to cover conversion status and message * Extend view spec to cover conversion status * Satisfy rubocop * Improve readability of migration code:	3 years ago
Benjamin Bädorf	3aaac1c7ce	Rename most notification to toaster instances (#9765) ... * Rename most notification to toaster instances * Frontend builds * Fix spec build * Rename more notification elements to toaster * Rename toaster-box to op-toast * Fix op-toast-container * Rename toasters upload progress * Try fixing page.rb toaster check * Fix some specs, break some others * Correctly overwrite toast_type * Fix more specs * Fix one more notification to toaster rename * Fix linting errors, harmonize naming more * Remove byebug debugging statement * Remove byebug debugging statement * Rename notification in the backend, too * Rename more instances of notifications to toastService * Rename backend back to notification since bundle gems expect it there * expect_toaster -> expect_toast Co-authored-by: Henriette Darge <h.darge@openproject.com>	3 years ago
Oliver Günther	2fcfa3ed3f	Remove retry as diskfile is already accessible	3 years ago
Oliver Günther	8e67070af3	Reschedule conversion job when direct upload not yet finished	3 years ago
Wieland Lindenthal	7273bdfab5	Allow downloading IFC files (#9750) ... * Allow downloading IFC files * Download file instead of showing the content in a new tab * Simplify to use original file name * Simple approach: keep orinal file names for now Renaming the IFC files before downloading is possible but out of scope at the moment. * Satisfy rubocop Co-authored-by: Henriette Darge <h.darge@openproject.com>	3 years ago
Oliver Günther	33acdd765a	Fix import name	3 years ago
Oliver Günther	eb0feb52d2	Fix exporting with a tempfile	3 years ago
Eric Schubert	9122884110	[#39144] fixed PR issues ... - removed some linter issues - fixed expected data from request tests	3 years ago
Eric Schubert	f8923ad238	fixed bim navigation spec, again	3 years ago
Eric Schubert	3e5cd88c94	fixed feature spec selector	3 years ago
Eric Schubert	c8a35f97da	[39451] remove base64 snapshot data from bcf vp ... - https://community.openproject.org/work_packages/39451 - remove base64 data after converted to snapshot attachement and before storing into database - added migration to remove snapshot data from current data	3 years ago
Eric Schubert	0ab5b5a164	[#39184] Switching viewer dropdown fails to load (#9763) ... * [#39184] Switching viewer dropdown fails to load - https://community.openproject.org/work_packages/39184 - ifc viewer is now only initialized after view is initialized * Fix bim nav spec to check for xoekit init Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
Eric Schubert	a3ac4f4112	[#38981] Integrate latest Xeokit version v2.3.6 (#9712) ... * [#38981] Integration of v2.3.1 of xeokit viewer - restyled toolbar - added properties panel - moved focus warning icon - restructured viewer container * [#38981] Switch style to not blue panel * Fix: Open properties tab on context menu click. * Update npm-schrinkwrap to use lockfileVErsion 1. * Fix: Make info buttons use correct observable for active state. * [#38981] Fixes on bcf viewer - hide info button if no model is loaded - reduce font size in properties panel * [#38981] fixed viewer styles on mobile * [#38981] fixed spec selector * Bump Xeokit Bim Viewer to 2.3.2 - Fixes infos in the properties tab * [#38981] aligned porperties tab values to OP tables * bump xeokit-bim-viewer to version 2.3.6 * [#38981] fixed table wrap layout Co-authored-by: Eric Schubert <e.schubert@openproject.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
Oliver Günther	b33d4e78ad	Ensure the importer executes under the given user (#9713) ... Since the attachment services now depend on a user for authorization, but the viewpoint snapshot is assigned explictily through snapshot.viewpoint=, there is no way to pass the current_user explicitly. Instead, log in the given user for the course of the import process	3 years ago
Oliver Günther	0b5da9b9e1	Give access to the issue project when trying to save a viewpoint (#9707)	3 years ago
Oliver Günther	af5e2e8494	Add spec for regular uploads as well	3 years ago
Eric Schubert	b23a3638f7	[#38960] Viewpoint files must end with .bcfv ... - https://community.openproject.org/work_packages/38960 - changed file extension from xml to bcfv	3 years ago
Wieland Lindenthal	3a4687ff9f	[#38954] IFC upload not working since attachment whitelisting ... * Saving the IFC file (at least during local upload): Validation of permissions for creating attachments fail as the project on which to check for permissions is missing * During conversion saving XKT file fails as it not an uploaded file and thus method `original_filename` is not present https://community.openproject.org/work_packages/38954	3 years ago
Eric Schubert	78c4531d1c	[#38833] Fixed PR issues ... - fixed some rubocop issues - added parameter declaration to comments api - added readonly flag to readonly records	3 years ago
Oliver Günther	b3ab397c94	Fix expects in specs after whitelist bypass	3 years ago
Oliver Günther	2d3a246fa4	Add create contract spec	3 years ago
Oliver Günther	4d1efab3c6	Fix content of viewpoint image to get correct content type	3 years ago
Oliver Günther	9e1dc1d50e	Set snapshot through attachment service	3 years ago
Oliver Günther	8a881cb20c	Fix uploader being changed by system	3 years ago
Oliver Günther	582579729e	Replace ifc models attachment handling with services	3 years ago
Oliver Günther	6ff21c6b96	Fix export job for bim	3 years ago
Eric Schubert	d6b87a2210	[#38833] BCF API Comments Service ... - https://community.openproject.org/work_packages/38833 - added requests tests - added check for expected body length - added representer and api for bcf_comments - added create and set attributes service for bcf_comments - added migration for comment hierarchy - added create and update service for journals	3 years ago