137 Commits (68bceb2d2631ee9ea9be2111774f1d8486d24c2a)

Author	SHA1	Message	Date
Tim Habermaas	ed23d6eb7f	Fix links from work packages table to fullscreen view.	9 years ago
Tim Habermaas	e5fceb38be	Fix non-camelcased name. ... Thanks, @houndci.	9 years ago
Tim Habermaas	bc5df6e051	Point work package link from table to new angular show view.	9 years ago
Oliver Günther	d5a3b21049	Scroll to element only when visible ... Introduces a simple helper plugin to determine whether an element is `visible()`.	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	7f602664fc	Allow focussing an element after work package has been updated ... This commit allows comments or fields to specify a callback after the work package has been updated. This is currently used to scroll to the element (such as the inserted comment), whenever the work package has loaded.	9 years ago
Oliver Günther	9bd4e06d29	Use promises in submitFields methods to defer updating ... As submitting comments and fields in one go requires work packages to be submitted first, we can use promises to ease the processing of each and abort early, e.g., when the WP couldn't be updated, we don't want to submit the comment.	9 years ago
Oliver Günther	8da4ac0d63	Restore empty description submit	9 years ago
Oliver Günther	c3589353cb	Scroll to textarea controls when editing and space available	9 years ago
Henriette Dinger	27c60cf667	Incorporate review feedback ... * Notification when comment is created * Better binding to editing comments * Quote with inserted text fixed	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Oliver Günther	5732eee3d3	Propagate and distribute field and comment submits in WP Field Service ... This commit allows parallel saving of comments and fields, however this currently results in a conflicting modification due to two saves with thes same lock version.	9 years ago
Oliver Günther	0883cf9834	Replace exclusive-edit with transcluded comment directive ... This commit removes the somewhat superfluous exlusiveEditController in favor of event-based passing of quoted text to the correct comment field. The comment directive now decides for itself whether it wants to be placed above or below the activities and uses transclusion for that purpose. Editing comments is now no longer exlusive, but that shouldn't be necessary anyway.	9 years ago
Oliver Günther	0aed8bb310	Test for comment input	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications ... This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Henriette Dinger	01d47ea851	Editable comment field ... This provides the basic functionality to deliver a comment field in the in-place editing style. Adds the `autogrow` plugin This still breaks a number of features currently, such as formatted previewing.	9 years ago
Jens Ulferts	c26773e5f8	split method to avoid boolean flag	9 years ago
Jens Ulferts	2d081b97fb	filter directories before uploading ... Uploading directories is not possible. When dragging a directory to the dropzone, the direcory is flattened so that the files in the directory will be accepted, but the directory itself is ignored.	9 years ago
Oliver Günther	528e2f92e2	Load preselected work package when required	9 years ago
Alexander Bach	c0c726cc15	Reset WP id for details pane display	9 years ago
Jens Ulferts	27f05acbc7	allow keyboard access to watcher delete	9 years ago
Jens Ulferts	adb27e589e	open ui-select upon watcher adding clicked	9 years ago
Jens Ulferts	ad3dd7f27d	allow keyboard access for attachment deletion	9 years ago
Florian Kraft	bf33466964	use a several parts from inplace edit to change add watcher workflow ... Watchers can now be added like assignees. The component now has its own implementation of the trigger component, based on edit and display pane of the work package form. Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	d9f67f6266	insert translations ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	07058738a1	handle injections to watchers service properly and add tests ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	64daddf767	remove dead code and provide helpers for the array sets ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	64ba83a718	make watchers removable ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	f47418de07	provide a method of adding watchers ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	6025a1b0e5	add a lookup directive ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	aadf639e68	remove helper method no longer needed	9 years ago
Florian Kraft	728efb6372	check for the existance of files in a work package ... This will check for existing files first. It will also cache the initial call and force reload only on demand Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	df2a5fb02a	only show errors when there are errors to be shown ... Errors were alwas shown by accident. As the EditableFieldsState object is not cleared upon successful request, using `finally` would show the error once more for a successful api call. Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	2fe9e49b47	correct test for new error notification ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	1faff1dada	show the errors when the requests have completed ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	df95780ef5	sneak in a fix for the attachments ... this will corect an error thrown when a validaiton error happens - the form will, in certain edge cases try to submit the work package files which can be empty at times. Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	93a3b2a56e	intitial display of error messages via the notification service ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	c26a58fe2c	apply interactive-table to work-packages-table	9 years ago
Jens Ulferts	d7b0ef28bd	extraxt column highlighting into own directive ... The directive is usable for every table and is used right away by the work packages table.	9 years ago
Jens Ulferts	611255dd0a	initialize files to prevent operations on undefined	9 years ago
Jens Ulferts	a3595873fa	separating viewmodel and view logic	9 years ago
Jens Ulferts	bb3f9fdc6c	consolidate duplicate code	9 years ago
Jens Ulferts	3232a3d21b	sort version by name	9 years ago
Florian Kraft	9d679cb68f	update tests and fix codestyle problems ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	54e3702b7f	add basic tests for NotificationsDirective ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	0578ad4b90	correct the conversion service to actually work ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	98f2fa852c	clean up semicolon madness ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	29e5916067	show an error notification instead of prolonging the file list ... this will show files which cannot be uploaded in an error list in a notification instead of using the file list. Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	acedeb9604	do not ask the api for attachments when nothing changes ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	cac48d3bae	wrap the size definition into a helper method ... the directive should not really care about whether an attachment is kB or MB in size. Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago