5524 Commits (6a2ab0b20043e88508d1698c7e6b1da210958572)

Author	SHA1	Message	Date
Travis CI User	860b5c4213	update locales from crowdin [ci skip]	4 years ago
Travis CI User	fa85b45c63	update locales from crowdin [ci skip]	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944) ... * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
Travis CI User	7ccc01d091	update locales from crowdin [ci skip]	4 years ago
Travis CI User	62351cd8b2	update locales from crowdin [ci skip]	4 years ago
Travis CI User	d1df2ff8aa	update locales from crowdin [ci skip]	4 years ago
Travis CI User	3ce6aaf070	update locales from crowdin [ci skip]	4 years ago
Travis CI User	1cd0300e32	update locales from crowdin [ci skip]	4 years ago
Travis CI User	94d9853d3f	update locales from crowdin [ci skip]	4 years ago
Travis CI User	c46c5dc7aa	update locales from crowdin [ci skip]	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943)	4 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937) ... * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	769be47723	[35815] Add visible show page for all users to groups (#8949) ... To that end, move the show group routes out of /admin, that requires we use a different path helper for it as `group_path` will still link to the first admin resource.	4 years ago
Travis CI User	8ec0fa8a87	update locales from crowdin [ci skip]	4 years ago
Wieland Lindenthal	efbd3e9b41	Placeholder user backend (#8935) ... * Add missing copyright note to AnonymousUser [ci skip] * Addin PlaceholderUser model and its associations * Ensure PlaceholderUser do not "leak out" uncontrolled * Extract Associations for User and PlaceholderUser. - remove obsolete #assigned_issues - remove obsoete #:responsible_for_issues - add specs and factory for PlaceholderUser Adding specs to PlaceholderModel * Migration: enforce uniqueness of lastname for Group and PlaceholderUser * Remove obsolete callback `after_add` on groups association. The association of principals and groups still had a callback `after_add` that called a method `user_added` on the group. That method was not defined anymore as it was removed in commit d93ff52a27. * Move validation for #groupname to the right spec. * Cleanup placeholder and group specs * Remove Setting `workpackage_group_assignment` * Refactoring: Extract assignable scope from Project to Member * Refactor: Add Member scope not_locked. * deprecate hacky scope * remove wp_group_assignment specific test case Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Travis CI User	908958780d	update locales from crowdin [ci skip]	4 years ago
Travis CI User	fac11f6091	update locales from crowdin [ci skip]	4 years ago
Travis CI User	2a978d9237	update locales from crowdin [ci skip]	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code ... Found via `codespell v2.1.dev0`	4 years ago
Travis CI User	2de9166070	update locales from crowdin [ci skip]	4 years ago
Travis CI User	16ae98128c	update locales from crowdin [ci skip]	4 years ago
Travis CI User	021abc1e5d	update locales from crowdin [ci skip]	4 years ago
Travis CI User	cedd26a7b6	update locales from crowdin [ci skip]	4 years ago
Travis CI User	177a4d7534	update locales from crowdin [ci skip]	4 years ago
Travis CI User	6a83b02651	update locales from crowdin [ci skip]	4 years ago
Travis CI User	97ec6c3656	update locales from crowdin [ci skip]	4 years ago
Travis CI User	b2da607524	update locales from crowdin [ci skip]	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Travis CI User	e4375d17e0	update locales from crowdin [ci skip]	4 years ago
Travis CI User	e8ded8b7af	update locales from crowdin [ci skip]	4 years ago
Aleix Suau	055086577d	Fix/34711 swap background colors of sum rows and group rows (#8767) ... * Total sums row: changed title and moved above 'create wp' row * Tests fixed * Total sum row: no height when void + overflow ellipsis on title * Total sums row: changed title and moved above 'create wp' row * Show 'Total Sum' full-width * Total sums row: changed title and moved above 'create wp' row * Tests fixed * Total sum row: no height when void + overflow ellipsis on title * Total sums row: changed title and moved above 'create wp' row * Show 'Total Sum' full-width	4 years ago
Travis CI User	b6342d2b9d	update locales from crowdin [ci skip]	4 years ago
Travis CI User	47817fb0f3	update locales from crowdin [ci skip]	4 years ago
Travis CI User	b44bb24b7e	update locales from crowdin [ci skip]	4 years ago
Travis CI User	dccc74971f	update locales from crowdin [ci skip]	4 years ago
ulferts	d497575c49	remove patch made superfluous by rails upgrade	4 years ago
Travis CI User	1093bb1181	update locales from crowdin [ci skip]	4 years ago
Travis CI User	1b5f100fe1	update locales from crowdin [ci skip]	4 years ago
Travis CI User	bb62398263	update locales from crowdin [ci skip]	4 years ago
Travis CI User	a4c6acd47a	update locales from crowdin [ci skip]	4 years ago
Travis CI User	f71d8ff79a	update locales from crowdin [ci skip]	4 years ago
Travis CI User	87726fea88	update locales from crowdin [ci skip]	4 years ago
Travis CI User	585836e0a1	update locales from crowdin [ci skip]	4 years ago
Travis CI User	3ea7b0809f	update locales from crowdin [ci skip]	4 years ago
Travis CI User	419c9955bd	update locales from crowdin [ci skip]	4 years ago
Travis CI User	eda9a53bf5	update locales from crowdin [ci skip]	4 years ago
Travis CI User	ca3148992c	update locales from crowdin [ci skip]	4 years ago
Travis CI User	7acd27ee47	update locales from crowdin [ci skip]	4 years ago
Travis CI User	d1f4d9f7bb	update locales from crowdin [ci skip]	4 years ago