136 Commits (6a2ab0b20043e88508d1698c7e6b1da210958572)

Author	SHA1	Message	Date
Oliver Günther	fa6b801ae4	Avoid opening card too soon ... this might fix the version_board_spec.rb	3 years ago
Oliver Günther	59fb3995cd	Filter archived subprojects from board (#9295)	4 years ago
Oliver Günther	5956ede030	[37107] render tabs in component (#9236) ... * Render work package tabs in one component * Move standard tabs into tab service * Move tab-count styles mostly into its own component style * Fix frontend specs * Remove unused texts * Fix routing to split view from button * Fix context menu not opening the tabbed view * Fix watcher tab counter not receiving an rxjs subscription * Fix selector * Fix clicking on relation link to fullscreen * Make WP tabs an instance of scrollable-tabs * Convert the tabs from .tabrow to its own BEM block * Refactor other usages of tabrow into op-tab-row * Fix frontend specs * Make wp modal tabs use scrollable-tabs * Fix disabled tab selectors * Restore scrollability of tabs * Fix import and change detection of graph modal * Fix selector in wp relations spec * Rename tab-count to match component style * Remove narrow style * Fix bem modifier style * Fix styles of scrollable tabs * Fix tab for time entry autocompleter	4 years ago
ulferts	b813e8b93f	Fix/bump gems (#9259) ... * bump aws-partitions * bump database_cleaner-active_record * bump rb-fsevent * bump recaptcha * bump sentry-ruby & sentry-ruby-core * bump terminal-table * bump date_validator * bump factory_bot & factory_bot_rails * avoid eager loading models via factories	4 years ago
Oliver Günther	0d949ed752	[36726] Handle multiselect values when trying to apply filter values (#9182) ... * [36726] Handle multiselect values when trying to apply filter values This will ensure that multi-select CFs will not get their value overridden to a filter value when it already has one of the selected values. https://community.openproject.org/wp/36726 * Add spec to test filter is not applied in boards	4 years ago
Oliver Günther	6dc662b1e4	[36243][30226] Different avatars for placeholders and groups (#9169) ... * Fix members autocompleter to allow hrefs * Add rendering of different avatar types * Remove unused code in backend avatar rendering * Add very basic test that the avatar gets customized per type * Allow avatar rendering in the CreateAutocompleter * Restructure avatars into BEM css * Remove avatar-classes in favor of passing size from backend * Remove to avoid confusion We use tracking with both href and , and was introduced to avoid a property called href to be overridden, but that was never a problem before. So from now we can safely use .href * Fix broken principal avatar in user activity * Ensure filters get updated even if the form is not reloaded There was a bug in conditionallyLoadForm that checked the property of link (always undefined) and would thus always reload a form. What we actually need is a form that gets reloaded only when the query link changes, but still update services from the updated query, such as filters * Adapt specs to changes classes * Rename op-principal-avatar to op-avatar	4 years ago
Oliver Günther	57034bc7d6	[35744] Use case-insenstive string comparison for action boards (#9112) ... https://community.openproject.com/work_packages/35744	4 years ago
Benjamin Bädorf	beb4e6ba50	Refactor/user avatar to principal (#9069) ... * Fix some ium stylings * Extend create service to also test with empty names * Add PrincipalLike type to pass around non-created placeholder refs * Add icon-context * Move principal rendering to its own module * Fix emit create new placeholder to principals * Revert op-principal for now * Add memberships form API to properly post * Fix types for returned principals * Move untilDestroyed in role * Filter input if not string in role-search * Pass correct inputs to success component * Return principal after saving membership * Fix small stuff around the ium * Fix the way HalResources are selected and passed * Move principal module to be exported by common * Disable quotemark in tslint until eslint is enabled * Fix image path in success * Adapt modal to run all steps in one within the modal helper component * Several fixes to modals * Fix ium success component styles, * Registration modal y-overflow * Add SMTP parameters to .env.example * Add disabled option to op-option-list, disabled placeholder users for non-ee instances * Add correct ee link to placeholder user option * Fix build * Removed unused sass files * Fix principal search not found indicator, added placeholder add image * Fix enterprise edition url, use dirty instead of touched check * Use backend class names for frontend principal types * Fix duplicate import and principal type usage * Also disable banners if with_ee is present in test * Extend specs for placeholders * Fix disabled attribute * Extend spec WIP * Improved inline-validation styles, fixed more PrincipalType usages * Add group happy path test, fix more PrincipalType usage * Fix a translation * Revert line deletion * Rewrite same spec examples into shared examples * Fix name of shared example * Dont run assets:clean to remove angular assets * Output whether assets are there at all * Update user-avatar usages to principal * Fix some op-principal usages * Fix principal typing * Remove ls of non-existent directory * Rename more user-avatar instances * Avatars now render correctly * Fix an op-principal instance, default to avatar class for avatars * Always add principal id to default principal tag * Small fixes to op-principal * Fix multiline user display * Dirty fix for capybara click events * Update avatar sizing * Fixed some specs * Fix unit specs * Added op-link styles * Fix add placeholder image link * Remove byebug debugger statements Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Aleix Suau	44cf9e0c5e	Epic/placeholder users frontend (#8977) ... * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Open invite user modal from user selection * Remove console and debugger calls * Opening modal from CreateAutocompleterComponent * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Refactor/op modal (#8978) * Initial modal refactoring * Updated modal imports * More modal module imports * Fix one more import * Fixed some styles * Fixed failing modal specs * Fix more spec selectors * Fix more specs * Updated backend modals * Improved code style * Fix export modal styles * Fix wiki export modal * Fix more specs * Fix webhooks modal * Added loading indicator back into modals * Fixed wp preview modal * InviteUserButtonComponent in * InviteUserButtonComponent in * InviteUserButtonComponent in MultiSelectEditFieldComponent and SelectEditFieldComponent * Remove extraneous module * Add Dragula import * Remove empty spec * Fix option-list component * Remove group creation from invite user modal * Write feature spec * Fix TS errors * Add Placeholder and Group apis to the frontend * Better api typing * Remove unnecessary interface * Remove group creation call Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Benjamin Bädorf <hello@benjaminbaedorf.eu>	4 years ago
ulferts	b8ca382d34	Group API (#9034) ... * include group members into resource * GET /api/v3/groups endpoint * POST /api/v3/groups * PATCH /api/v3/groups/:id * DELETE /api/v3/groups/:id	4 years ago
Aleix Suau	8dd5ebfc9f	Fix/34840 filter out not allowed board lists (#8983) ... * Refactor * Added pageSize=0 to make the calls lighter * Refactor * Added pageSize=0 to make the calls lighter * Safe operator on board.queries * Tests failing * Tests failing * Debugging failing test * fix setting up the tests * continue integration test on board error messages * linting Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	a9a83f2dbc	Revert "[34840] Unclear error message when subproject column for action board cannot be displayed due to missing permissions (handling this bug in another way) (#8852)" ... This reverts commit 55fa5a1803.	4 years ago
Behrokh Satarnejad	55fa5a1803	[34840] Unclear error message when subproject column for action board cannot be displayed due to missing permissions (handling this bug in another way) (#8852) ... * hiding the columns with errors in parent componenet * changing the way of fetching data * avoid showing the error box * filter valid data at the beginning of fetching the whole data * handling the situation where there isn't any list * hiding the columns with errors in parent componenet * changing the way of fetching data * Proposed RxJs solution * Refactor * Specs Co-authored-by: Aleix Suau <info@macrofonoestudio.es>	4 years ago
ulferts	1e53c4f2fa	Fix/bump gems (#8850) ... * bump webmock * bump rubocop * bump listen * bump grape * bump erubi * bump airbrake-ruby * bump aws-sdk-sns * bump parallel_tests * bump aws-partitions * bump aws-sdk-core * attempt to stabilize flickering spec	4 years ago
ulferts	cf5d955042	specific i18n key for invalid filter values	4 years ago
Oliver Günther	b111115e1a	Allow to set the model name in the errors	4 years ago
bsatarnejad	8a0c727b0e	solve the travis errors	4 years ago
Behrokh Satarnejad	d35b2eea42	change som text in board creation modal (#8696)	4 years ago
Wieland Lindenthal	afab7713be	Flaky feature spec. Trying to give it more time to find.	4 years ago
Behrokh Satarnejad	35da772864	[34070] Improve board creation modal (#8639) ... * adding images to tile of each board * Add path helper to resolve images * improve the new board modal display * solve travis check errors * reduce additional unnecessary code Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
bsatarnejad	37f390b162	reduce additional unnecessary code	4 years ago
bsatarnejad	a9233e8e2c	solve travis check errors	4 years ago
Oliver Günther	e5c40d030b	[34063] Prevent child to be moved into its own column ... https://community.openproject.com/wp/34063	4 years ago
Markus Kahl	59f6de21c6	copy dashboards with all widgets and updated references where necessary	4 years ago
Oliver Günther	c4648f65b3	Allow referencing work packages in action boards	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling ... Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
Oliver Günther	b50f04a9b1	Add unassigned value for the assignee action board ... Allows extension of the filter values with an empty !* type filter that is also remembered as a "null" ID column for the board list selection.	4 years ago
Oliver Günther	d64e46c955	Add better texts for subtasks and subprojects board	4 years ago
Oliver Günther	f98f98e833	Fix tests	4 years ago
Oliver Günther	9055654991	Add spec for subtasks	4 years ago
Behrokh Satarnejad	f3ec94857a	Change the new board modal to be selected in tile mode in collaboration with task number [33864] (#8524) ... * Change the new board modal to be selected in tile mode * change the test of selecting a board * changing the style of tiles * create a component for tile-view * a test for the tile-view component * remove additional f from test * making changes in styles * Changing methods of adding icons, text and description to tiles * Some minor styling changes - Use primary-color-dark so the color matches the theme - Use flex for positioning of icon + label - Remove unused / unnecessary styles * correct the errors in checks * solving Travis check issues * Ensure test checks for title case Co-authored-by: Oliver Günther <mail@oliverguenther.de> [ci skip]	4 years ago
Oliver Günther	5dbb9eadc5	Add a spec	4 years ago
Oliver Günther	b778a77719	Test correct permission to move between subprojects	4 years ago
Oliver Günther	5c15a5a930	Fix spec to correctly test for path	4 years ago
bsatarnejad	e3ca009eff	in test, we should login as admin to delete a WP	4 years ago
bsatarnejad	6e5ecd339b	solve code climate errors	4 years ago
bsatarnejad	de47f50a42	fixing back rout after deleting wp in boards module	4 years ago
Oliver Günther	ea43caafa7	Add spec for copying of boards	4 years ago
Oliver Günther	e911ebb76d	Correctly create board queries so they are manual sorted ... If they do not get the sort criteria applied, the test will not assume they are manually sorted	4 years ago
bsatarnejad	e1d461cf8b	removing Trailing whitespace	4 years ago
bsatarnejad	57aeafede7	removing Trailing whitespaces	4 years ago
bsatarnejad	ab961be36e	writing a test for navigating from full view to details view of wp in boards module	4 years ago
Henriette Darge	86070a96fa	Fix typo which prevented any update event to pass the map. Thus the cards did not update.	5 years ago
Oliver Günther	c4ca024e36	Add specs for action boards moved by split view	5 years ago
Oliver Günther	16764ce5f7	Add spec for opening details view from boards	5 years ago
Henriette Darge	7b87beb8ae	[33073] Add notification message to board when there are no options to add (#8325) ... * Show warning when there are no options to add as list * Add test case for showing a warning when no member is available to add as a board list [ci skip]	5 years ago
Oliver Günther	f4668e2e77	[33090] Rename continue button to add in boards modal ... https://community.openproject.com/wp/33090	5 years ago
Oliver Günther	41e52a69a4	Correctly load groups trough hrefs ... We used the user service which does not allow loading groups. https://community.openproject.com/wp/33072	5 years ago