333 Commits (6a7aab70ff8a36ca64a4a36be6d44ba18b717a09)

Author	SHA1	Message	Date
Oliver Günther	24b663948d	Avoid using gon for boards permissions	6 years ago
Oliver Günther	5431f39f54	[29199] Correctly pass permission to identify new WP button ... https://community.openproject.com/wp/29199 [ci skip]	6 years ago
Wieland Lindenthal	fd88776ceb	Add relations tables to Types via form configuration (#6773) ... * WIP: PrecedesFilter and FollowsFilter for WorkPackages * Create Type Form Groups per Query Type * generalize filters on relations avoiding alias * fix flickering spec * Rename dependency represeners for Follower and Predecessor Filters * Allow configuring templated queries within query configuring modal * Use `{id}` as templated value, instead of a now deprecated `templated` string * Rewrite ParentFilter to follow same structure as other relation filters. * Set Follower and Predecessor filters as hidden in Frontend * Default query shall show closed WPs, too * Remove relation filter type selection from form configuration view as we extend query configuration modal instead. * Allow ExternalQueryConfiguration to be more specific and prepend relation filters in its modal. * Quick unrelated fix on the way: the instruction text should start below the columns input and not to the right of it * - Add all missing relation filters. - Use verbs for naming instead of nouns to stay consistent with UI. * fix typo * Add relation filters to hidden filters and fix a rebase bug * Typo in docs * Fix broken rebase conflict resolution * Add part of and includes filter * adding specs for relation filters * rename RelatesFilter to RelatesToFilter * Rename shared example as direction does not matter anymore. * Fix spec for IncludesFilter * Fix name conflict for `includes` by calling typed_dag's `direct` later. * Fix shared filter examples as the parent filter does not get added per default anymore. * Fix spec after renaming PredecessorFilter to PrecedesFilter * Fix integration spec for type configuration form * Add filter dependency specs * Differentiate between WorkPackageFormChildrenQueryGroup and WorkPackageRelationQueryGroup types * Create inline-create for relation tables * Rewrite filters to use actual relation_type as key * Reload relations on change, change symbols * Fix relation filter i18n strings * Test presence of all relation filters frontend. * Extend integration test for form configuration to not only cover hierarchy, but also undirectional and directional relation types. * Consistent naming of filter dependency representer files * Satisfy codeclimate * Add missing copyright notes * Fixing PartofFilter and its specs * Reverse relation direction when created inline * WIP integration test for Relation Query Component and Children Query Component. * Correctly reload children tables when refreshed * Fix FilterOnUndirectedMixin * Fix removing of relation from embedded table after reload * Adding intergration tests for removing and adding relation or children, initiated form either embedded table or relations tab. * Fix specs * Fix implementation of duplicates and duplicated They are reversed in typed_dag and causes confusion [ci skip]	6 years ago
Oliver Günther	5b49b33b21	Prepare for core integration	6 years ago
Oliver Günther	326a9f5430	Block attachment modification	6 years ago
Oliver Günther	3ba6913960	Implement read-only work package attributes based on status	6 years ago
Oliver Günther	3807bc4f7f	[28446] Rename due date to finish date ... https://community.openproject.com/wp/28446	6 years ago
Oliver Günther	3a69c1a6d8	[28452] Avoid adding a CF multiple times to eager loaded WPs ... If there is a custom field that is for_all, and it occurs multiple times in the custom_fields_projects join table, it will be added multiple times to the work packages availabe CFs. https://community.openproject.com/wp/28452	6 years ago
Oliver Günther	8438848838	[28435] Fix custom field with is_for_all eager loading ... When a custom field is `is_for_all`, and in the join table from custom fields to projects, there exist a value to project A (e.g., before the CF was marked is_for_all in the first place): Lookups to the work packages in Project B with eager loading will result in this custom field missing, because the `LEFT OUTER JOIN` in usages have already mapped it to Project A. https://community.openproject.com/wp/28435	6 years ago
Jens Ulferts	804d59c735	use correct subclass link for assignee and responsible	6 years ago
Jens Ulferts	c1853a5cdd	fix expected namespace for groups on assignee and responsible property	6 years ago
Oliver Günther	b08a5874f5	Remove project responsible and type	6 years ago
Jens Ulferts	146e358b50	enable uploading attachments for budgets	6 years ago
Jens Ulferts	319f33e924	remove textile	6 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Oliver Günther	e55b16c52e	[#27692] Keep overridden budgets in the budget subforms ... They were overridden because the items are being mass assigned. https://community.openproject.com/wp/27692	7 years ago
ulferts	e1027189bb	eager load associated work packages of relations (#6315) ... [ci skip]	7 years ago
Jens Ulferts	26320fe614	eager load for relations	7 years ago
Jens Ulferts	d04b86da9c	introduce custom eager loading for work package list ... Reduces the amount of AR models instantiated when handing wp#index requests by: * Calculating part of the checksum for caching in the db. This is done by using the id and the updated_at/on field of associated models whose representation is cached in the wp representer. * Reusing instantiated models for multiple associations. e.g instances of Project are used in various places (the work package itself, it's ancestors and children). Instead of using Rails' eager loading which would instantiate a project potentially once for every association path, the code now assigns the same instance to all those associations. Additionally, the commit streamlines the creation of custom field injected representers. Now only one class is created for all work packages when before it would be one class for every uniq set of custom fields. On top of that, the class can be reused if the set of custom fields does not change.	7 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot ... Removes the deprecation	7 years ago
Oliver Günther	61afac09cc	FactoryGirl => FactoryBot (belongs to opf/openproject#6304)	7 years ago
ulferts	eefbb413e7	performant visible condition on relations query (#6290) ... [ci skip]	7 years ago
Jens Ulferts	9150cb5daa	ensure cacheability of work_package_representer	7 years ago
Jens Ulferts	ce21ee20f7	cached representers	7 years ago
Jens Ulferts	17d7d2c511	handle query saving, updating, deletion	7 years ago
Jens Ulferts	5a5e3494f9	turn attribute group into dedicated object	7 years ago
Jens Ulferts	a33b0bbbbd	WIP - return Query as an attribute group ... * only default query for now * only returned when no custom configuration is applied * start to turn attribute groups into ressources	7 years ago
Jens Ulferts	6d359cb02d	turn attribute groups into array of objects	7 years ago
Jens Ulferts	9bf5d05fdb	add description on custom action ... * turn custom action into fully fledged resource * add description to custom action model * load custom action resource on mouse over and display in title	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Jens Ulferts	42e5933545	improve wp#index performance by eager loading custom actions	7 years ago
Jens Ulferts	77370d58ad	document custom actions	7 years ago
Jens Ulferts	886273ee86	initial implementation of conditions - status	7 years ago
Jens Ulferts	92ce554e53	configurable actions on custom actions	7 years ago
Jens Ulferts	71d4e6a02a	generate workflow buttons dynamically from wp resource ... The information in the wp resource is still static, though.	7 years ago
Jens Ulferts	690e0ffc60	wp create/update/destroy via services	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag ... Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
Oliver Günther	ab9a9baee7	[26002] Add date as writable when type is milestone (#5804) ... https://community.openproject.com/wp/26002 [ci skip]	7 years ago
ulferts	c5d5b88cbb	adapt to altered representers api (#295) ... [ci skip]	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732) ... * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
Edward Betts	437bbd51bf	correct spelling mistakes (#5748) ... [ci skip]	7 years ago
ulferts	65c7db3120	avoid side effects on calls to attribute_groups (#5677) ... Without the deep_dup, the call to attribute_groups used to alter the type's attribute_groups deeply nested attribute_groups property. As a result, the second call to attribute_groups would be different from the first one. This became most apparent when rending the schema for a couple of work packages all sharing the same type. As the type was reused to render the schema, but the project might have changed, only the first schema for the type was accurate, while subsequent schemas for that type lacked attributes [ci skip]	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465) ... * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
ulferts	8b823a6861	bump rails to 5.0.3 (#5544) ... * bump rails to 5.0.3 * adapt specs * fix specs * avoid naming conflict in association method Because of https://github.com/rails/rails/pull/28246, association methods can currently collide [ci skip]	8 years ago
Wieland Lindenthal	313271eef2	Adding links to create_form_representer for creating WPs globally	8 years ago
Wieland Lindenthal	b992ab0c4c	Improve wording in spec	8 years ago
Wieland Lindenthal	4ff86f019e	Adding specs for create project form representer	8 years ago
Wieland Lindenthal	50ff9a243b	Move link to project's custom field settings to collection representer	8 years ago
Jens Ulferts	f96d4a0c19	be more forgiving to plugins in spec	8 years ago
Oliver Günther	c407cc6941	Add identifier to export representations used for icons [core] ... This adds an explicit icon reference to the representation links to avoid the frontend having to fiddle with the keys to provide the icons. Instead, the link object may receive an optional identifier to uniquely identify the link. I deem that useful in other situations, so I added it directly into HalLink.	8 years ago