74 Commits (6a8d7cf806602ee808ba1b3f34a7ff018082992d)

Author	SHA1	Message	Date
Oliver Günther	980447ab51	Prevent backtracking regexp in MessagesController (#9447)	3 years ago
Oliver Günther	8365f575cb	Prevent backtracking regexp in MessagesController (#9447)	3 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944) ... * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765) ... * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230) ... Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
ulferts	0479d8359c	remove commented out code	5 years ago
ulferts	70a29885d5	fix topic attachment upload	5 years ago
ulferts	ffc131695a	use services/contracts for forum messages	5 years ago
Henriette Dinger	1a443e0d30	Highlight correct menu item	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	c5994d3b9b	Rename Boards to Forums	6 years ago
Oliver Günther	9b3b573a95	Output format.any ... [ci skip]	6 years ago
Jens Ulferts	97ad5e0008	reenable previews	6 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Oliver Günther	ab4f9b7ed5	Replace settings and boards remotes with actual responses	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	af2018fb5d	ActionController::Parameter is no longer a hash ... Thus, we need to cast ourselves	8 years ago
Oliver Günther	fe0e8dd919	Rename before_filter to before_action	8 years ago
Henriette Dinger	0f00d0452c	Add flash message for successfull deletion	9 years ago
Mohamed Wael Khobalatte	a1bf92212d	Fix legacy and cucumber specs failing because of strong params	9 years ago
Mohamed Wael Khobalatte	d2349cf819	Delete Redmine's safe_attributes implementation ... It was an early implementation of strong_parameters, more or less. Going forward, we should strive to make the whitelisting of attributes a controller responsibility only.	9 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params ... We no longer need attr_accessible.	9 years ago
Alex Coles	e02eb0181d	Migrate AR finder/query methods in controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Markus Kahl	d26382362f	jQuery all the way	10 years ago
Markus Kahl	deae307c19	fixed quoting ... Element IDs were out of sync. Added feature spec.	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	bb0e6e6aa5	Fix syntax (w/Rubocop) in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	336446c59d	Use 1.9+ Hash syntax in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Hagen Schink	3a58ad5cb4	Fix preview	11 years ago
Hagen Schink	43cc5f677e	Fix preview	11 years ago
slawa	a070cee3d7	Fix sticky date set	11 years ago
slawa	42c2f1f24a	Save sticky date if sticky is set	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago
Hagen Schink	9b5f8c3d41	Fixes message attachment add/remove	11 years ago
Hagen Schink	49b39639f9	Fixes inital message attachment journal issue	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Martin Czuchra	8b37d26b2c	Changes defaults in MessagesController.	11 years ago
Jens Ulferts	6c720a8d5d	changes the last controllers to will_paginate ... Uses page_param and per_page_param calculation from PaginationHelper for all of the controllers Adapts the api views	12 years ago
Jens Ulferts	54b604b494	uses will_paginate for boards and messages	12 years ago
Jens Ulferts	21459a384f	provide every possible file with a short copyright notice ... This was done using the rake task: rake copyright:update	12 years ago
Philipp Tessenow	ec3829e11b	be careful with nested namespace'd controllers in our controllers	12 years ago
Jens Ulferts	8c6973dcee	resourcifies messages aka. topics	12 years ago
Jean-Philippe Lang	4156485090	Prevent mass-assignment vulnerability when adding/updating a forum message (#922).	13 years ago
Felix Schäfer	e77ee2f9f8	Correct forum quoting ... Backport of 58a7182e	13 years ago
Holger Just	91070236db	Set source encoding to UTF-8	13 years ago
Holger Just	07185fb169	[#436] Remove trailing whitespace	14 years ago
Eric Davis	99507a0391	[#197] Upgrade the copyright in the code files	14 years ago