openproject

Commit Graph

Author	SHA1	Message	Date
Jan Sandbrink	17940bf02c	change validation of WP children - do not add error on a symbol called :#123 (123 is the childrens ID) - this is against the semantics of ActiveRecord::Errors - creating symbols in a loop used to be a bad idea (might be better today) - it breaks error messages in the APIv3 (which is due to APIv3 working beyond the borders of AR errors, not the best of ideas...) - use :base instead, the place for unlocatable errors - include the fact that #123 refers to a child element in the error message Basically I feel that this makes the children validation cleaner and better. But somehow I fear, that there is some code out there that depends on the fact that error keys like :#123 existed...	9 years ago
Jan Sandbrink	b374ebdd7f	store messages alongside error symbols - allows to skip translation part in ErrorBase - allows to have correct translations containing placeholder values	9 years ago
Jan Sandbrink	a9d28d3fb6	fix some errors uncovered by specs - bad default values - missing attribute sanitation - style	9 years ago
Jan Sandbrink	6c9bd3c63f	apply a hack to fix an error	9 years ago
Jan Sandbrink	bd484a9fbe	include punctuation in error locales	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Jan Sandbrink	c7207f0330	resort errors in WP contracts - use attributes as keys and error messages as value - AM errors immediately turn message symbols into translated strings, this makes them hardly processable -> patch some helper methods onto AM::Errors and everything is fine forever	9 years ago
Alex Coles	1bf90d2ff1	Revert "Add patch to fix Rails' hash types with Ruby 2.1.1" Rails 4.0.x `Hash` subclasses have been patched to deal with this behaviour change: https://github.com/rails/rails/pull/14198/ This reverts commit `8d6ae91d8b`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	fea5478893	Remove unloadable from initializers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jens Ulferts	301ea48d63	add missing i18n key It used to work because Rails falls back to "timelines" by itself. But this prvented I18n.	9 years ago
Alex Coles	79f8ec9aee	Remove Uglifier, disable JS compression	9 years ago
Alexander Bach	18ebdc9a9e	Some settings cleanup	9 years ago
Alexander Bach	984f3dcc4a	Add setting for journal aggregation time	9 years ago
Florian Kraft	c783b47a64	fix routing for index action Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Mihail Maxacov	4788c863cc	cancel button buff	9 years ago
Mihail Maxacov	6e965d9e3d	buttons and functional view	9 years ago
Mihail Maxacov	76521e956e	barely breathing wp form	9 years ago
Jonas Heinrich	694db62ff7	Removes german locales	9 years ago
Markus Kahl	6fa07f060f	fixed default realm	9 years ago
Markus Kahl	a770bf762c	follow warden default, which is true for store	9 years ago
Markus Kahl	3865ce4f1f	polish	9 years ago
Markus Kahl	bcd981df5c	consider X-Authentication-Scheme; opt scoped realm	9 years ago
Oliver Günther	e0af219a36	Fix invalid time sheet link This adds specs for top menu items	9 years ago
Toshi MARUYAMA	90e89f97c9	Revert "Temp. silence deprecation warnings in test env" This reverts commit `d4444cfe5e`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	c030b08cb2	Fix syntax (w/Rubocop) in Rails routes, config Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Florian Kraft	396ef0b024	use clear value label [ci skip] Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Florian Kraft	15ece51581	add the no value label to linked embedded fields Also, use a different label for the clear option Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Jens Ulferts	01f62ce9d6	open help in new tab Please note that the implementation of what to do on target='_blank' is browser specific but they should open up a new tab. Alternatively they can open up a new window. The specification can be found here: http://www.w3.org/html/wg/drafts/html/master/browsers.html#browsing-context-names	10 years ago
Florian Kraft	67588eed91	change default value for footer link [ci skip] Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Oliver Günther	99098c375c	Fix for module items pointing to wrong routes in some cases The global routes defined in Module menu items are being overridden to their project counterparts in some cases. Related work package: https://community.openproject.org/work_packages/20613	10 years ago
Jan Sandbrink	430c7f7f46	remove redundant localization [ci skip]	10 years ago
Jan Sandbrink	36468cf8c4	add item to reach time entries to project menu	10 years ago
Oliver Günther	af181577f3	Allow overriding the html title for accessible help	10 years ago
Oliver Günther	5ada719136	Consolidate Module menu in header navigation This effectively changes the following menus: Top Menu - Removed Administration item - Added Item 'Work Packages' -> /work_packages - Added Item 'News' -> /news - Added Item 'Time Sheet' -> /time_entries (if user has a project with view time log permission) My Menu - Added Administration item as first position With work packages, time entries, news now residing in the top menu, these buttons are superfluous in the projects overview and are also removed. Relevant work package: https://community.openproject.org/work_packages/20512	10 years ago
Oliver Günther	60a2bd6a0f	Reduce space needed by search and help top menu item This commit changes two top menu items: 1. Search is by default collapsed to its magnifier icon - Upon clicking it, it is expanded and focus given to the search field - Clicking any hierarchy not in below the wrapper, the search is collapsed again 2. The help button remains as a '?' icon, and loses the caption. Relevant work package: https://community.openproject.org/work_packages/20540	10 years ago
Alex Coles	c7ef9bd060	Replace PlainTextInterceptor with BaseMailer This replaces the solution in `78e8fc38`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Florian Kraft	85d55809fd	use new icons in respective menus Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Alex Coles	acbf4611be	Disable concurrency in test environment Works-around the following issue in integration specs: RuntimeError (Circular dependency detected while autoloading constant MyClass) See: https://robots.thoughtbot.com/how-to-fix-circular-dependency-errors-in-rails-integration-tests Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ac8fa05e30	Fix routing to MyController#reset_(api\|rss)_key Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5916c1995e	Update Rails configs: initializers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	dab73aadff	Update Rails configs: environments Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	f29144fda5	Update Rails configs: application.rb Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	3d30080d12	Update Rails configs: boot.rb Based on freshly-generated Rails 4.0.13 application. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	2640852fe3	Fix MembersController#autocomplete_for_member routing * make routing less convoluted (as in `18835799`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	0a0f6c7b6c	Interpolate attribute in confirmation error string Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	18835799dd	Make ProjectsController#types use PATCH * make routing less convoluted: switch to a regular member route. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ae97716087	Make MyController#account use PATCH Now routes form helper-generated request correctly. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e4d1f7f7d7	Make WikiController#update_parent_page use PATCH Now routes form helper-generated request correctly. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ab0864062e	Make WikiController#rename use PATCH Now routes form helper-generated request correctly. http://weblog.rubyonrails.org/2012/2/26/edge-rails-patch-is-the-new-primary-http-method-for-updates/ Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago

... 7 8 9 10 11 ...

2629 Commits (6e50a038770001abf4f0f4a9b68814caee55ff3a)