216 Commits (6f37e3db9f1e4dbcf0802f993fd75985252964c0)

Author	SHA1	Message	Date
Jens Ulferts	a1812699f0	validate actions	7 years ago
Oliver Günther	8fa78e4b5a	Fix more specs	7 years ago
Oliver Günther	7dc9df3aee	Adapt specs to factory pattern	7 years ago
Oliver Günther	941ed90b6a	Extract Custom Field mixin and subfilters ... Allows re-use of custom field filters in different contexts, with additional logic per custom field type (e.g., user with me values)	7 years ago
ulferts	d90513b968	hack availability of wp id filter (#6036) ... The id filter is currently implemented as a stub. It is usable from the wp api but using it via the query api and by that via the front end fails intentionally as we currenlty have no solution to display the potentiall filter values efficiently. As there could be thousands of possible values, this problem is quite hard. This hack circumvents the problem by not showing the filter in the query representer. The filter is applied but the user will not be informed of the existence of the filter or its values. As this is more of an easter egg, this is probably ok for now. [ci skip]	7 years ago
Markus Kahl	8f4139578a	available budgets depend on project	7 years ago
Wieland Lindenthal	4e22681e78	User mentions feature (#5897) ... * Extend syntax for linking users via their ID * Allow login names for linking user profiles. * User require_relative for legacy tests * Add specs for login name based user links; Fixes other specs, too. * Notify mentioned users * Notify linked users; - require quotes for login names in user links as login names can contain spaces, dots that are typical word boundaries - Adding specs * For the decision who gets notified due to mentions only the visibility permissions of the recipient are relevant. * Rubucop satisfaction * Add autocomplete for user names to work pack package descriptions and activity - Uses API V3 Principals endpoint. - Extends API endpoint with name filter and name order. - Make it activate when user types an "@" or a "user#" - Still for work packages only. * Directly show a list of users after typing '@' and allow navigating list with cursor keys * Add an '@' before the rendered user link * Adopting spec as WP autocompleter now expects whitespace before hash sign * Adding spec for using user autocompleter * Introduce magic pageSize of 0 for maximum length * Add id filter for principals * Allow pagination for principals and protect from falling back to a too low default value * Fixing specs * fixing typo in spec * Add magic number 0 for user custom fields * Add a toParams method for ApiV3FilterBuilder * User ApiV3FilterBuilder in path helper service * Add test for mentions principals to path helper * WIP * Convert auto complete helper to TS [ci skip]	7 years ago
Oliver Günther	fdfb41b327	[26069] Allow passing of me-value link for principal filters again ... The 'me' value is currently automatically normalized to the current user, making it impossible to store queries that reference the current user whenever accessing the query as before.	7 years ago
Oliver Günther	75d2f010ba	[25108][26176] Assigned_to filter returns group values ... Since 7.0.0, the `assigned_to is <user>` filter also returns work packages assigned to a group that `<user>` belongs to. Since this is misleading and judged a bug by several customers, instead add a new filter that provides exactly this behavior, while using `assigned_to` only for the exact value specified there. https://community.openproject.com/wp/26176 https://community.openproject.com/wp/25108	7 years ago
Oliver Günther	ddcf35f3f7	Fix invalid value_objects being passed to representer ... There are queries that seem to pass values not available in APIv3 path helper to the instance representer. ``` Original error: #<NoMethodError: undefined method `anonymous_user' for API::V3::Utilities::PathHelper::ApiV3Path:Class Did you mean? anonymous?> Stacktrace: /opt/openproject/lib/api/v3/queries/filters/query_filter_instance_representer.rb:82:in `block (2 levels) in <class:QueryFilterInstanceRepresenter>' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:38:in `map' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:38:in `map' /opt/openproject/lib/api/v3/queries/filters/query_filter_instance_representer.rb:80:in `block in <class:QueryFilterInstanceRepresenter>' ```	7 years ago
Oliver Günther	ed1a0c87de	[25999] Make timeline labels configurable ... https://community.openproject.com/wp/25999	7 years ago
Oliver Günther	e02a65e372	[26141] Use valid subset of query to save it (#5859) ... https://community.openproject.com/wp/26141 [ci skip]	7 years ago
Oliver Günther	ece6fa5d23	[26128] Fix local jump error (#5856) ... [ci skip]	7 years ago
ulferts	0c1c8d443a	don't use project as cache key if project is nil (#5806) ... [ci skip]	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732) ... * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
ulferts	7ad39ec35f	Fix/cache query representers (#5711) ... * cache various query representers json representation * sort by * columns * group by * filter instance schemas * fix custom option path [ci skip]	7 years ago
Oliver Günther	aa386f994d	[25606] Saving query with nil group_by does not apply it (#5684) ... This was caused by the groupBy deserialization only applying when it is non-nil [ci skip]	7 years ago
Jens Ulferts	5982ede894	adapt to altered representable interface	7 years ago
ulferts	5165906e11	fix saving boolean cf filters, use representer for filter parsing (#5660) ... * fix saving boolean cf filters, use representer for filter parsing * patch roar to allow linked_reseource definitions This enables us to get rid of dedicated representers for links sections when the representer is used for parsing [ci skip]	7 years ago
ulferts	f4b36edccb	Feature/save zoom in query 7 1 (#5637) ... * Implement timeline zoom level as query enum * Implement query zoom handling in frontend Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query. * Extend feature spec for zoom saving * Refactor URLParamsHelper into TS service * Fix comparison in table query services * Remove reference to allowedValues [ci skip]	8 years ago
Oliver Günther	2c0ebf0a6e	Add relationType to relationOfType column ... So we can avoid matching the id/href in the frontend.	8 years ago
ulferts	55695ed756	adds query columns by relation type (#5625) ... [ci skip]	8 years ago
ulferts	cea23ce333	Fix/sort version filter options (#5630) ... * have version filter options ordered by name * Fixes filter options on global queries (returned types instead of versions) * Adds the name order to be available generally * code prettification [ci skip]	8 years ago
ulferts	20dd8a6e0a	Feature/work package id filter (#5614) ... * add filter for work packages by id to query * hide the id filter in front end As we do not yet have satisfying means to display the filter values for selection, we hide the filter and use it internally only [ci skip]	8 years ago
ulferts	ace7098eb3	add relations columns to query (#5606) ... * add relations columns to query * refactory query columns * rename QueryColumn to QueryColumn::Property QueryColumn is now only an abstract supertype [ci skip]	8 years ago
Oliver Günther	6b372acae6	Implement timeline zoom level as query enum	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465) ... * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
ulferts	d9aab230fd	Fix/empty filters on export (#5579) ... * place empty filter set in representation url This will allow the empty filter set to override the default filter (status - open) * remove now unused method * persist having no filter in the url params Otherwise, the default filter (status - open) will reappear on reload [ci skip]	8 years ago
ulferts	86c2f3d59d	Fix/increase query api robustness (#5574) ... * removes unavailable filters on valid_subset! * remove invalid columns on valid_subset! * cleanup query form and collection * code prettification * add status to spec in order to have valid queries [ci skip]	8 years ago
ulferts	2a71172837	prepare the query before reading results (#5547) ... * prepare the query before reading results * use string for list cf filter value because all other list filter also use a string * handle invalid group, columns, sort on query read [ci skip]	8 years ago
ulferts	a4198c9722	add showHierarchies to query payload representer (#5551) ... [ci skip]	8 years ago
Jens Ulferts	8de39cb30a	refactor to reduce method complexity	8 years ago
Jens Ulferts	a41707c2ad	fix saving cf filters	8 years ago
Wieland Lindenthal	50ff9a243b	Move link to project's custom field settings to collection representer	8 years ago
Wieland Lindenthal	8eb93c1a6a	Add link to work package list	8 years ago
Jens Ulferts	ac983fc0a9	include user in query eager loading	8 years ago
Jens Ulferts	1fe880ad1b	prevent query filters loosing their context	8 years ago
Jens Ulferts	a4ae0e9b65	allow active, invited and registered users to be filter values	8 years ago
Jens Ulferts	abc685b71e	adapt backlogs type filter to core changes	8 years ago
Jens Ulferts	3c6a93283b	simple code prettifications	8 years ago
Jens Ulferts	fbe791cce2	adapts the cost object filter to changes made in the core	8 years ago
Jens Ulferts	a6936de10a	escape query operators in url	8 years ago
Jens Ulferts	8a08856748	replace string object by custom option for list custom fields	8 years ago
Jens Ulferts	33545b9e39	refactor query filter statements into distinct classes	8 years ago
Jens Ulferts	6f31e15941	fix reloading dependency representers in dev mode	8 years ago
Oliver Günther	7144f28662	[24972] Make hierarchy mode state part of query	8 years ago
Oliver Günther	34d029d055	[24575] Instrument timeline visibility state through query	8 years ago
Jens Ulferts	7918aa496c	avoid n+1 queries by using already loaded columns	8 years ago
Jens Ulferts	d5de0d25db	use built in method to prevent NoMethodError	8 years ago
Jens Ulferts	69d2083987	define DateTime filter dependency	8 years ago