openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	5bbca1a37b	Use deliver_later to avoid raising errors in copy job Drive-by fix for https://community.openproject.org/wp/42962	2 years ago
ulferts	3f8ca13830	rubocop autofix for cops added in 1.31.0	2 years ago
Christophe Bliard	48a4f1b6ad	lint with rubocop --autocorrect (safe cops only)	2 years ago
Christophe Bliard	a33524ef6d	remove ruby magic comment for utf-8 ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless	3 years ago
Christophe Bliard	bc8d423ec2	update copyright information for 2022	3 years ago
Markus Kahl	f83f96a172	elevated prio for jobs users might wait for	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
Oliver Günther	f50297227b	[34444] Projects copy APIv3 (#9149 ) * Create copy project endpoint * Add representers * Add _meta representer for copy module information * Add Meta payload representer * Extract parsing of copy attributes into service * Extract enqueue job for projects copy * Keep request object available in the bodied endpoint this allows us to access grape (e.g., for redirecting) * Add DelayedModify endpoint that redirects to job status * Use DelayedModify endpoint for copying projects * Add api paths for form/copy * Disable cache on ProjectCopyPayload * Add spec * Add resource spec * Extend schema for meta * Extend docs * Don't pass service result, but state as meta to forms * Use copy dependencies for naming copy options in API * Add description property for counting * Remove unused action attribute * Skip writable checks on meta property for payloads * Use prepend to allow create(...) usage with meta * Extend copy spec with custom fields usage * Add spec for copy flags * Add todos * Pass errors correctly to copy settings * Remove invalid parameters to copy that are now caught through project service * Remove duplicated validation * Linting * Make count a human readable, formattable description string * Make source count string readable * Provide the source project for generating the counts * Extract copying of attachments into sepearate dependent services This will allow the API to dynamically generate a copy association schema from each dependent service * Add spec for copy schema representer * Add payload representer spec * Also validate the model to pass the validations when copying * Make description optional and add note to schemas.apib * Add send_notifications to representer * Allow to configure sendNotifications * Allow bodied to receive a state process callback That allows us to manage the meta state on the API level, not on the service level * Make other services compatible with BaseCallable * Fix params passing from BaseCallable Wrapping a single hash into kwargs obviously loses their key indifference and we can't expect all services to use a single params object. Older services use kwargs * Copy wiki page with parent_id This will save some memory instead of memoizing the entire wiki page * Fix typo * Default to true for all copy associations That means if only a true value is passed, all other options will still be true * Do not try to copy attachments if the base dependency wasnt copied * Ensure null identifier gets rendered * Fix paths to the form and commit * Change redirect to an URL * Extend documentation on meta properties as table * Ensure we pass a default params if incoming params are nil Now that SetAttributes needs to splat params, they do no longer correctly get the no-param-default behavior of Ruby, so we need to explictly assign a default params hash * Fix expect for trailing path	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Oliver Günther	b7f93b96cf	Better error handling if project copy dependencies fails The project copying can succeed but with errors of some dependencies, this commit modifies the modal to show these errors instead of automatically redirecting.	4 years ago
Oliver Günther	605f6b8355	Refactor copy project into service	4 years ago
Oliver Günther	45fc54b7e0	Allow jobs to define a title for the job status modal	4 years ago
Oliver Günther	d0c0fdd871	Correctly upsert statuses in all cases In case of tests, jobs never are running through the 'queued' step. This causes jobs to be missing in later updates. To avoid this, ensure that we just use upsert, which is faster anyway.	4 years ago
Oliver Günther	58562e7379	Let CopyProjectJob redirect to the target project	4 years ago
Oliver Günther	b8bc50bb8d	Make copy project job store a status	4 years ago
Oliver Günther	6c6a05c784	Ensure we set templated to false when copying	4 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	3dabb46dd9	allow copying projects without parent project reference	5 years ago
Oliver Günther	a7ed2e9da0	Rewrite jobs to use ActiveJob syntax	5 years ago
ulferts	57f7da4f39	reuse project services in controller	5 years ago
Oliver Günther	5c311e488d	[30309] Fix saving duplicate enabled modules and rendering wrong errors https://community.openproject.com/wp/30309	5 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308 ) * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
Oliver Günther	369b668e64	Make ProjectsController#destroy use background worker + service [ci skip]	6 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	c405b3977d	Improve error output when copying project fails	8 years ago
Oliver Günther	ab6e7ebf10	Increase logging for copy project job [ci skip]	8 years ago
Markus Kahl	92506216d3	use common base class for jobs	8 years ago
Jens Ulferts	8f1c5d76b7	allow parent project to be set on copy	8 years ago
Oliver Günther	9db305439d	[22158] Fix CopyProjectJob notifications * Actually send copy job notifications * Skip enqueuing notifications when mails are disabled Aggregated journal notifications are sent after a delay, after which the actual job has long completed.	9 years ago
Stefan Botzenhart	e7490c1988	Fix copy project After switching to strong parameters mass assignment for project params is not supposed to work without permitting params. We now pass a normal hash instead of a ActionController::Params hash. Otherwise we get an ActiveModel::ForbiddenAttributesError All errors on the job are being rescued and logged to a separate file. Normally rescueing all errors on Exception is not something you want to do but as the job has an ensure block you won't know about any failures.	9 years ago
Mohamed Wael Khobalatte	d2349cf819	Delete Redmine's safe_attributes implementation It was an early implementation of strong_parameters, more or less. Going forward, we should strive to make the whitelisting of attributes a controller responsibility only.	9 years ago
Oliver Günther	02807e02a8	Refactor CopyProjectJob to class	9 years ago
Jan Sandbrink	715c664cbe	generalize module included in all delayed jobs now also applies to other activities one might want to execute before all delayed jobs (as discussed with @ulferts)	9 years ago
Jan Sandbrink	10d61b01e7	let delayed jobs reset the request store This is especially neccessary since our Settings use the request store to determine, whether they need to invalidate the cache key. If the request store was never reset, the settings in our delayed jobs would be cached at an old value forever (until the next restart).	9 years ago
Alex Coles	ea713284a8	Fix syntax (w/Rubocop) in workers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Markus Kahl	ba7d247817	use IDs in CopyProjectJob; send mail synchronously also moved the job into the workers directory	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Alex Coles	6fe9535b1f	Fix syntax (w/Rubocop) in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Ion Biziiac	a54a3c28ff	Fix unclear error message when copying project	10 years ago
slawa	22a4bb420b	initialize user current to avoid failing of copy project process	10 years ago
Alex Coles	c695ca4ea8	Fix whitespace in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Hagen Schink	39085a1037	Fix subproject copy	10 years ago
Hagen Schink	d1c165f657	Set user locale for copy project	10 years ago
Hagen Schink	8c144050e4	Move copy project implementation to DJ	11 years ago

41 Commits (6f4dcf81e9df982f6f2fcfc300ccf1c6cbe92c78)