71 Commits (71574a738bebc1b5ea63a4a034cfbd1608e0cfc8)

Author	SHA1	Message	Date
Oliver Günther	7908c7eebe	Validate a separate params contract	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
ulferts	20a9f91a22	ensure project status is saved (#9325) ... aweseome_nested_set, used for maintaining the project hierarchy, reloads the project after saving. Any change to an associated model, e.g. the status, is lost upon reloading. Thus, saving of the status needs to take place before saving the project. This is safe to do since it is carried out in a transaction and all the validations are run for the status as well. https://community.openproject.org/work_packages/37464	4 years ago
ulferts	6cda6ad4fd	enforces dependent project modules being active (#9311) ... Project modules, e.g. calendar can define dependencies, e.g. work packages. An error message is now displayed if a user enables a project module without the dependency being active in the project as well. Also fixes a serious bug in the Shared::ServiceContext module. Whenever a failing service result is returned, every change to the database is to be rolled back. This was not true when a model was provided since the changes where carried out within an inner transaction	4 years ago
ulferts	0eae14072e	translate "overview" copy option	4 years ago
Oliver Günther	6c75e16dc4	[37140] Use acts_as_url to generate unique slug for identifier (#9250) ... * Use acts_as_url to generate unique slug for identifier * Re-enable project identifier spec now handled in backend * Add integration spec for set attribute service * Adapt spec for new empty identifier * Avoid double error messages for empty identifier acts_as_url may return an empty string depending on the name, but the empty presence validation will suffice in this case, we don't need the invalid validation * Fix stubbed errors object accessed by acts_as_url * Avoid trying to get the upstream unique attribute in case of errors * Remove sequential_project_identifiers setting * Adapt spec to review feedback	4 years ago
Oliver Günther	2adce94853	Implement copy form in formly (#9218) ... * Implement copy form in formly * Add meta property handling to dynamic form * Remove copy projects controller, merge into projects * Fix copying of container attachments * Fix project copy path * Fix remainder of copy spec	4 years ago
Oliver Günther	71b330ea80	[37026] Add new project form with template selection (#9193) ... * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * Provide DynamicFieldsService in root so it can be used independently * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * _isResourceSchema based on parent?.location * Scope DynamicFieldsService to DynamicFormComponent * Added backend validation method to FormsService * Remove form from DynamicForm when not isStandaloneForm * Allow multiple form keys to validate * Remove form from non standalone forms * Remove duplicated button * Fix: dynamic form with ng-template not showing validations * DynamicForm programatic validation * Add new project component that posts to the copy form * Hide the submit button input * Unify ckeditor spacings with other dynamic-form elements * Basic fixes to invalid dynamic form fields * Load the templated projects with newly added action * Fix invalid styles for dynamic inputs * Updates to form styles, add op-form and op-fieldset * Soften inputs to 2px * Update input styles globally * Redirect to job status modal when response is job status * fix: load projects routes * Collapsible groups working * Fix: setTimeout datepicker to wait DOM ready * resourceId added to project settings form * fieldsLayoutConfig * formUrl & formHttpMethod @Inputs * Avoid replacing non ending '/form' strings * formUrl @Input * @Input model * identifier hidden * Populate the model * Add new project component * Tests removed * Show create message when creating new resource * Change location to rails * Add field_name helper for testing * Add form field helper classes and fix tests * Remove templated from copy for now * Fix more tests * Reset toolbar from dev * Skip identifier test * Set overflow to visible when expanded * Fix more tests * Rename data-field-name to data-qa-field-name * Review feedback * Uncollapse group fields when they contains errors * Fix text spec * Remove instantiate template service * Remove unnecessary ProjectController#create Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	4 years ago
Oliver Günther	2896afe6c4	Assign project identifier in backend (#9196) ... * Introduce localizable slug url Stringex currently works only with english strings for wiki. But that default is actually confusing. Instead, add an explicit localizable helper that receives the locale and sets the stringex backend locale temporarily * Generate a default identifier in the backend * Remove JS based identifier updating * Remove identifier attribute * Add button to change identifier * Adapt tests to changed identifier * Linting * Fix invalid selector	4 years ago
Oliver Günther	06bcfbbb06	Add user job to provide system user with privileges (#9191)	4 years ago
ulferts	9ba51e7db0	fix touching the project on archiving/unarchiving (#9187) ... Without the touch, the cached project representers are not updated	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958) ... * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	f50297227b	[34444] Projects copy APIv3 (#9149) ... * Create copy project endpoint * Add representers * Add _meta representer for copy module information * Add Meta payload representer * Extract parsing of copy attributes into service * Extract enqueue job for projects copy * Keep request object available in the bodied endpoint this allows us to access grape (e.g., for redirecting) * Add DelayedModify endpoint that redirects to job status * Use DelayedModify endpoint for copying projects * Add api paths for form/copy * Disable cache on ProjectCopyPayload * Add spec * Add resource spec * Extend schema for meta * Extend docs * Don't pass service result, but state as meta to forms * Use copy dependencies for naming copy options in API * Add description property for counting * Remove unused action attribute * Skip writable checks on meta property for payloads * Use prepend to allow create(...) usage with meta * Extend copy spec with custom fields usage * Add spec for copy flags * Add todos * Pass errors correctly to copy settings * Remove invalid parameters to copy that are now caught through project service * Remove duplicated validation * Linting * Make count a human readable, formattable description string * Make source count string readable * Provide the source project for generating the counts * Extract copying of attachments into sepearate dependent services This will allow the API to dynamically generate a copy association schema from each dependent service * Add spec for copy schema representer * Add payload representer spec * Also validate the model to pass the validations when copying * Make description optional and add note to schemas.apib * Add send_notifications to representer * Allow to configure sendNotifications * Allow bodied to receive a state process callback That allows us to manage the meta state on the API level, not on the service level * Make other services compatible with BaseCallable * Fix params passing from BaseCallable Wrapping a single hash into kwargs obviously loses their key indifference and we can't expect all services to use a single params object. Older services use kwargs * Copy wiki page with parent_id This will save some memory instead of memoizing the entire wiki page * Fix typo * Default to true for all copy associations That means if only a true value is passed, all other options will still be true * Do not try to copy attachments if the base dependency wasnt copied * Ensure null identifier gets rendered * Fix paths to the form and commit * Change redirect to an URL * Extend documentation on meta properties as table * Ensure we pass a default params if incoming params are nil Now that SetAttributes needs to splat params, they do no longer correctly get the no-param-default behavior of Ruby, so we need to explictly assign a default params hash * Fix expect for trailing path	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961) ... * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code ... Found via `codespell v2.1.dev0`	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	2ad215fed1	add milestone type filter for default project gantt query (#8869)	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765) ... * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
ulferts	f511f8d4f5	set default role when copying project as non admin (#8824)	4 years ago
ulferts	d5e490efda	set the copying user to be the author of attachments (#8822)	4 years ago
ulferts	ae2edad19b	Fix/copy project wiki notifications (#8777) ... * rename to convey applicability to all journal notifications * adapt journal completed job to handle wiki content * remove empty module * create wiki_content mail service * introduce copy/create service and contract for wiki pages * specify set attributes and create contract for wiki pages * copy the content attributes * use wiki page create service when copying wiki * introduce specifc service for copying wiki pages The contract disables checks for permissions on the wiki page. The copy_projects permission should suffice to copy everthing in a project * copy wiki pages top down to rewrite hierarchy * limit copied attachments to copied type	4 years ago
Oliver Günther	6984a63b43	Do the same thing for overview dependency	4 years ago
Oliver Günther	6a3e136909	Actually output the errors even on success	4 years ago
Oliver Günther	8db5e90193	[34312] Update and use default settings for gantt query ... https://community.openproject.com/wp/34312	4 years ago
Oliver Günther	24005a9e6d	[34000] Ensure user custom fields can be copied ... User CFs were not copiable because they depend on project members being copied. They need to be overridable in the copy form however, so we need to be able to set this before and after members are copied. The only option is to allow visible members to be selected there. https://community.openproject.com/wp/34000	4 years ago
Oliver Günther	4aad0c8b72	Generate URL params for gantt view and insert projects	4 years ago
Markus Kahl	59f6de21c6	copy dashboards with all widgets and updated references where necessary	4 years ago
Oliver Günther	becefba1c4	Allow template to set the default advanced settings once selected ... Previously, advanced settings were simply hidden when project templates were selected. This however prohibits setting/overriding certain attributes, such as the parent project. This commit results in: - Selecting a template will reload the page - When advanced settings were opened, confirms from the user that the page should be reloaded - The template is being applied to the new project to ensure the attributes are being used - The user can then override or delete whatever params she wnats	4 years ago
Oliver Günther	b7f93b96cf	Better error handling if project copy dependencies fails ... The project copying can succeed but with errors of some dependencies, this commit modifies the modal to show these errors instead of automatically redirecting.	4 years ago
ulferts	8656c2664b	fix archiving projects via api ... When archiving, we need to assume the old `active` status to see if any modifications can be made. On top of that, whenever that status is changed the archive/unarchive service needs to be called as well so that e.g. the child projects are also archived	4 years ago
Oliver Günther	2523040abf	Improve lookup of versions and work package user assignments	4 years ago
Oliver Günther	9c0ed65c55	Make dependent services use project.(association).create when possible	4 years ago
Oliver Günther	cbe57a9e32	Add common \`should_copy?\` method for the project copy service	4 years ago
Oliver Günther	ace6af5b4e	Refactor archive service to use model from BaseContract	4 years ago
Oliver Günther	5b308c53ac	Fix params[:only] check for wiki dependent service	4 years ago
Oliver Günther	2271b79fc6	Correctly base all services on base_contracted with a model ... BaseContracted service uses a `model` reference that it doesn't define itself, neither does some of the dependent services. To avoid this, make sure the BaseContracted gets an optional model attribute that can be set.	4 years ago
Oliver Günther	01954c26bc	Refactor copy services to use shared state	4 years ago
Oliver Günther	582e9dce07	Retain the public attribute AFTER the SetAttributeservice ... The public attribute gets reset in the SetAttributeService	4 years ago
Oliver Günther	95d1549858	Move legacy project copy spec to service spec	4 years ago
Oliver Günther	0230f41385	Retain order in copied work packages if query is manually sorted	4 years ago
Oliver Günther	605f6b8355	Refactor copy project into service	4 years ago
Oliver Günther	ddcefeebf7	Linting	4 years ago
Oliver Günther	58562e7379	Let CopyProjectJob redirect to the target project	4 years ago
Oliver Günther	af78b4aedf	Dont call #delete on status params ... This removes it from params on subsequent calls after the SetAttributesService. Extends the test to ensure the assigning of status over a template is working.	4 years ago
Oliver Günther	6c6a05c784	Ensure we set templated to false when copying	5 years ago
Oliver Günther	9173cd82d7	Move available templates method into contract	5 years ago
Oliver Günther	382befc8be	Run CopyProjectJob for instantiating template with pararms	5 years ago
Oliver Günther	e165eb34e7	Create separate service/contract for instantiation of templates	5 years ago
Oliver Günther	467b1860ae	Add templated property to projects	5 years ago